Bug#929912: unblock: ltsp/5.18.12-3

[Cyril Brulebois]

Niels Thykier  (2019-06-04):
> Control: tags -1 confirmed d-i
> 
> Vagrant Cascadian:
> > Please unblock package ltsp
> > 
> > unblock ltsp/5.18.12-3
> 
> Looks good to me, CC'ing KiBi for a d-i ack before completing the unblock.

No objections, thanks.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#929912: unblock: ltsp/5.18.12-3

[Niels Thykier]

Control: tags -1 confirmed d-i

Vagrant Cascadian:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> X-Debbugs-Cc: vagr...@debian.org, debian-b...@lists.debian.org
> 
> Please unblock package ltsp
> 
> This fixes two release-critical bugs, an important bug, and updates
> the debconf translation for Dutch.
> 
> Builds from unsigned CDs failed due to changes in apt being more
> strict regarding unsigned repositories. This is fixed by passing the
> --trust-file-mirror option introduced in ltsp-build-client upstream,
> but not added to the default arguments for the ltsp-client-builder
> .udeb. This .udeb is not used in the default debian-installer images,
> and thus should have no impact on them.
> 
> The tool to build an LTSP chroot environment failed to detect the
> codename in buster now that /etc/debian_version contains a version,
> instead passing the version of Debian "10" to debootstrap, resulting
> in a failure to build. The upstream fix was to switch back to using
> lsb_release, and the patch applied to this version.
> 
> An important issue in the arguments for mounting loopback images was
> discovered and fixed upstream, ensuring read-only mounts which might
> otherwise lead to filesystem inconsistancies with ext4 or other
> writeable filesystems, and fixing a typo in the loop argument passed
> to mount. The upstream patch is included in this version.
> 
> Additionally, the Dutch debconf message translation was included in
> this version.
> 
> [...]
> 
> unblock ltsp/5.18.12-3
> 
> 
> Thanks for all your work on releasing Debian!
> 
> 
> live well,
>   vagrant
> 

Looks good to me, CC'ing KiBi for a d-i ack before completing the unblock.

Thanks,
~Niels

Bug#929912: unblock: ltsp/5.18.12-3

[Vagrant Cascadian]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: vagr...@debian.org, debian-b...@lists.debian.org

Please unblock package ltsp

This fixes two release-critical bugs, an important bug, and updates
the debconf translation for Dutch.

Builds from unsigned CDs failed due to changes in apt being more
strict regarding unsigned repositories. This is fixed by passing the
--trust-file-mirror option introduced in ltsp-build-client upstream,
but not added to the default arguments for the ltsp-client-builder
.udeb. This .udeb is not used in the default debian-installer images,
and thus should have no impact on them.

The tool to build an LTSP chroot environment failed to detect the
codename in buster now that /etc/debian_version contains a version,
instead passing the version of Debian "10" to debootstrap, resulting
in a failure to build. The upstream fix was to switch back to using
lsb_release, and the patch applied to this version.

An important issue in the arguments for mounting loopback images was
discovered and fixed upstream, ensuring read-only mounts which might
otherwise lead to filesystem inconsistancies with ext4 or other
writeable filesystems, and fixing a typo in the loop argument passed
to mount. The upstream patch is included in this version.

Additionally, the Dutch debconf message translation was included in
this version.

diff -Nru ltsp-5.18.12/debian/changelog ltsp-5.18.12/debian/changelog
--- ltsp-5.18.12/debian/changelog   2018-12-24 17:30:09.0 -0800
+++ ltsp-5.18.12/debian/changelog   2019-05-29 13:02:07.0 -0700
@@ -1,3 +1,23 @@
+ltsp (5.18.12-3) unstable; urgency=medium
+
+  * ltsp-client-builder: Add --trust-file-mirror to ltsp-build-client
+options to fix builds from unsigned CDs (Closes: #929735).
+
+ -- Vagrant Cascadian   Wed, 29 May 2019 13:02:07 -0700
+
+ltsp (5.18.12-2) unstable; urgency=medium
+
+  [ Frans Spiesschaert ]
+  * [INTL:nl] Dutch translation of debconf messages (Closes: #924103).
+
+  [ Vagrant Cascadian ]
+  * Add patch to fix loop mounting and ensure mount is read-only. Thanks
+to Alkis Georgopoulos.
+  * Add patch to fix codename detection (Closes: #925173). Thanks to
+Wolfgang Schweer.
+
+ -- Vagrant Cascadian   Mon, 27 May 2019 04:58:46 -0700
+
 ltsp (5.18.12-1) unstable; urgency=medium
 
   * New upstream version.
diff -Nru ltsp-5.18.12/debian/ltsp-client-builder.templates 
ltsp-5.18.12/debian/ltsp-client-builder.templates
--- ltsp-5.18.12/debian/ltsp-client-builder.templates   2018-12-24 
17:15:33.0 -0800
+++ ltsp-5.18.12/debian/ltsp-client-builder.templates   2019-05-29 
12:23:24.0 -0700
@@ -29,7 +29,7 @@
 
 Template: ltsp-client-builder/build-client-opts
 Type: string
-Default: --mirror file:///media/cdrom --security-mirror none --updates-mirror 
none --accept-unsigned-packages
+Default: --mirror file:///media/cdrom --security-mirror none --updates-mirror 
none --accept-unsigned-packages --trust-file-mirror
 # Only used for preseeding arguments to ltsp-client-builder.
 Description: for internal use: arguments for ltsp-build-client:
  this option is meant to be used with debconf preseeding.
diff -Nru 
ltsp-5.18.12/debian/patches/correct-typo-in-ltsploop-avoid-ext4-journal-p.patch 
ltsp-5.18.12/debian/patches/correct-typo-in-ltsploop-avoid-ext4-journal-p.patch
--- 
ltsp-5.18.12/debian/patches/correct-typo-in-ltsploop-avoid-ext4-journal-p.patch 
1969-12-31 16:00:00.0 -0800
+++ 
ltsp-5.18.12/debian/patches/correct-typo-in-ltsploop-avoid-ext4-journal-p.patch 
2019-05-27 04:55:58.0 -0700
@@ -0,0 +1,24 @@
+From 5dcca1e8dcd864669ffa1cb36d89f832077a7243 Mon Sep 17 00:00:00 2001
+From: Alkis Georgopoulos 
+Date: Sat, 25 May 2019 09:49:38 +0300
+Subject: Debian: correct typo in ltsploop, avoid ext4 journal
+ playback errors.
+
+---
+ client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop 
b/client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop
+index 595e56ba..12bc4601 100755
+--- a/client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop
 b/client/Debian/share/initramfs-tools/scripts/nfs-bottom/ltsploop
+@@ -45,5 +45,5 @@ if [ -f "${rootmnt}/${ltsploop}" ]; then
+mount -o move ${rootmnt} /ltsploop
+mkdir -p ${rootmnt}
+# TODO filesystem detection
+-   mount -o ltsploop -t ${ltsploopfs} /ltsploop/${ltsploop} ${rootmnt}
++   mount -o loop,ro -t ${ltsploopfs} /ltsploop/${ltsploop} ${rootmnt}
+ fi
+-- 
+2.20.1
+
diff -Nru ltsp-5.18.12/debian/patches/fix-codename-detection.patch 
ltsp-5.18.12/debian/patches/fix-codename-detection.patch
--- ltsp-5.18.12/debian/patches/fix-codename-detection.patch1969-12-31 
16:00:00.0 -0800
+++ ltsp-5.18.12/debian/patches/fix-codename-detection.patch2019-05-27 
04:54:47.0 -0700
@@ -0,0 +1,33 @@
+From