Bug#931580: pbuilder: SOURCE_ONLY_CHANGES=yes fails to work with pdebuild-internal

[Mattia Rizzolo]

Control: tag -1 pending

On Sat, Dec 11, 2021 at 06:41:01PM +0100, Francesco Poli wrote:
> Control: tags -1 - pending
> 
> 
> On Sat, 11 Dec 2021 17:22:53 +0100 Mattia Rizzolo wrote:
> 
> [...]
> > You're right.
> > Well, now I also successfully fought my laziness and tried it, and it
> > works here, so I committed to master, pending release.
> 
> Thank you, but... nope... it does *not* work here!   :-(
> 
> 
> I again see a '_source.changes' file and the pdebuild crashes again:
> 
>   I: removing directory /home/my_user_name/var/cache/pbuilder/build//81958 
> and its subdirectories
>   cat: ../apt-listbugs_0.1.36_source.changes: No such file or directory
>   E: No .changes file(s) can be found; debsign not done.


ahem yes.  I was blinded by the log.

try again, apologies.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#931580: pbuilder: SOURCE_ONLY_CHANGES=yes fails to work with pdebuild-internal

[Mattia Rizzolo]

On Sat, Dec 11, 2021 at 04:21:05PM +0100, Francesco Poli wrote:
> I applied that patch to my installed package pbuilder/0.231 (without
> applying any other more recent commits, since they seem to be
> unrelated: is that right?).

Yeah, that's right.

> The patch applies cleanly to both files ('pdebuild' and
> 'pdebuild-internal'), but it fails to work, unfortunately!
[...]
> At the end of build process (after running the hooks), pdebuild should
> take care of the generated files, by copying them to ${BUILDRESULT} and
> by signing the ones which needs GPG signatures.
> Well, it crashes with the following error:
> 
>   I: removing directory /home/my_user_name/var/cache/pbuilder/build//12062 
> and its subdirectories
>   /usr/bin/pdebuild: line 75: get822files: command not found
>   E: No .changes file(s) can be found; debsign not done.
> 
> 
> Please test it yourself (my sid chroot configuration is in the [original]
> bug report).

You're right.
Well, now I also successfully fought my laziness and tried it, and it
works here, so I committed to master, pending release.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#931580: pbuilder: SOURCE_ONLY_CHANGES=yes fails to work with pdebuild-internal

[Mattia Rizzolo]

Hi Francesco,

On Fri, Nov 26, 2021 at 07:15:37PM +0100, Francesco Poli wrote:
> On Sat, 14 Dec 2019 18:05:39 +0100 Francesco Poli wrote:
> > > Please apply my patch, so that pdebuild-internal users may generate
> > > source .changes files.
> > 
> > Is there any progress on this?
> > I really would like to see my patch accepted into pbuilder.
> 
> Hello again,
> I have updated my patch to support SOURCE_ONLY_CHANGES=yes for
> pdebuild-internal users. It is attached to this message.

I had a look at your patch, but there was one point I didn't like, which
was that I didn't want that to include calling dpkg-genchanges both in
and outside of pdebuild-internal.

Also, I disliked that pdebuild was parsing .changes file on its own,
something that proved hard enough and with enough corner cases that I
had to write a helper function.  Unfortunately, pdebuild-internal is not
really maintained, so I also noticed plenty of other things I didn't
like (for example: it doesn't seem to support Rules-Requires-Root ...).

Anyhow, I made a patch, but I'd rather you tested it, instead of me who
I think never run pdebuild-internal.
Could you please have a shot at this:
https://salsa.debian.org/pbuilder-team/pbuilder/-/commit/91aa02567a9bc14cdf2bc180c7829e9bacb525fd.patch
?

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#931580: pbuilder: SOURCE_ONLY_CHANGES=yes fails to work with pdebuild-internal

[Francesco Poli]

On Sun, 07 Jul 2019 22:43:46 +0200 Francesco Poli (wintermute) wrote:

[...]
> I hereby release my patch under the same terms as pbuilder itself,
> that is to say, under the terms of the GNU GPL v2 or later.
> 
> 
> Please apply my patch, so that pdebuild-internal users may generate
> source .changes files.

Is there any progress on this?
I really would like to see my patch accepted into pbuilder.

Please note that I prepared a number of uploads with my modified
version of pdebuild and everything seems to have worked without any
issue.

Thanks again for your time.
Bye.

-- 
 http://www.inventati.org/frx/
 There's not a second to spare! To the laboratory!
. Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE


pgpkCdWMTFceZ.pgp
Description: PGP signature

Bug#931580: pbuilder: SOURCE_ONLY_CHANGES=yes fails to work with pdebuild-internal

[Francesco Poli (wintermute)]

Package: pbuilder
Version: 0.230.4
Severity: normal
Tags: patch

Hi!

I read in the [documentation] that [source only uploads] are recommended.
No, it's more than that: since the release of buster, they seem to be
[mandatory] for bullseye.

[documentation]: 
[source only uploads]: 
[mandatory]: 


I tried to set SOURCE_ONLY_CHANGES=yes in my sid chroot configuration
file:

  $ cat ~/.pbuilder/sid.conf
  export HOME=/home/my_user_name
  DISTRIBUTION="sid"
  COMPONENTS="main"
  MIRRORSITE="http://deb.debian.org/debian;
  APTCACHE="${HOME}/var/cache/pbuilder/aptcache/${DISTRIBUTION}/"
  APTCACHEHARDLINK="no"
  AUTOCLEANAPTCACHE="yes"
  BASETGZ="${HOME}/var/cache/pbuilder/${DISTRIBUTION}-base.tgz"
  BUILDPLACE="${HOME}/var/cache/pbuilder/build/"
  BUILDRESULT="${HOME}/var/cache/pbuilder/result/${DISTRIBUTION}/"
  HOOKDIR=""
  DEBBUILDOPTS="-i -I"
  SOURCE_ONLY_CHANGES="yes"
  BINDMOUNTS=""
  USE_PDEBUILD_INTERNAL="yes"
  DEBOOTSTRAPOPTS[0]="--variant=buildd"
  DEBOOTSTRAP="debootstrap"
  EXTRAPACKAGES="gnupg debian-archive-keyring"
  USEPROC="yes"
  USEDEVPTS="yes"
  USEDEVFS="no"
  REMOVEPACKAGES="lilo elilo grub-legacy grub-pc"
  BUILDSOURCEROOTCMD="fakeroot"
  PBUILDERROOTCMD="sudo"
  BUILDUSERID=""
  BUILDUSERNAME="pbuilder"
  export DEBIAN_FRONTEND="noninteractive"
  AUTO_DEBSIGN="yes"
  PKGNAME_LOGFILE="yes"
  PKGNAME_LOGFILE_EXTENSION=".buildlog"
  export debian_chroot="pbuild$$"

but it fails to have any effect.

The fact is that I use pdebuild-internal and the generation of the
source .changes file is not implemented for this operation mode,
as [confirmed] by James Clarke.

[confirmed]: 

The attached patch implements the optional generation of the source
.changes file for pdebuild-internal operation mode.
It also implements the signing of all the generated .changes file
(both the binary and source .changes file, if both were generated;
only one of them, if one was generated).
Please note that, the --no-re-sign option is passed to debsign
from the second invocation on, in order to avoid breaking the
checksums of any previously signed .changes file.
See also bug [#906063], which is related to checksum breaking
(I don't know if my patch also fixes that bug, though...).

[#906063]: 

I hereby release my patch under the same terms as pbuilder itself,
that is to say, under the terms of the GNU GPL v2 or later.


Please apply my patch, so that pdebuild-internal users may generate
source .changes files.

Thanks for your time!
Bye.



-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (800, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages pbuilder depends on:
ii  debconf [debconf-2.0]  1.5.71
ii  debootstrap1.0.114
ii  dpkg-dev   1.19.7

Versions of packages pbuilder recommends:
ii  devscripts  2.19.5
ii  eatmydata   105-7
ii  fakeroot1.23-1
ii  iproute24.20.0-2
ii  net-tools   1.60+git20180626.aebd88e-1
ii  sudo1.8.27-1

Versions of packages pbuilder suggests:
pn  cowdancer   
pn  gdebi-core  

-- debconf information excluded


source_only_for_pdebuild_internal.diff.gz
Description: application/gzip