Bug#935364: debhelper: dh_clean doesn't print info about files listed in debian/clean being removed, even with DH_VERBOSE
On 01/09/2019 08:57, Niels Thykier wrote: > Control: tags -1 moreinfo unreproducible > > On Thu, 22 Aug 2019 00:10:08 +0200 =?utf-8?q?Cl=C3=A9ment_Hermann?= > wrote: >> Package: debhelper >> Version: 12.5.3 >> Severity: normal >> >> Hi, >> >> while working on a package, I had trouble finding out why some file were >> disapearing without any reason and no entry in build log, despite using >> DH_VERBOSE. >> >> Looking at the code, it's because >> glob_expand_error_handler_silently_ignores is used, I guess to avoid >> warning about not being able to remove non-existing files. >> > > > Hi, > > I cannot reproduce the issue from the description. When I run dh_clean > with verbose it lists files/directories being removed. > > """ >> dh_clean -v foo >> rm -f debian/debhelper-build-stamp >> rm -rf debian/.debhelper/ >> rm -f -- debian/debhelper.substvars debian/dh-systemd.substvars foo >> debian/files >> ^^^ >> rm -fr -- debian/debhelper/ debian/tmp/ debian/dh-systemd/ >> [...] > """ > > (see ^^^ line) > > Can you provide a concrete example where it does not work? Hi, Apparently I missed the file when looking at my buildd logs. I tried to reproduce the issue, and it's actually here, just lost in the middle of the "rm" line. I probably was so confused about this file disappearing I wasn't able to "grep" properly (or even to set DH_VERBOSE env var) ;) Sorry for the noise. Cheers, nodens
Bug#935364: debhelper: dh_clean doesn't print info about files listed in debian/clean being removed, even with DH_VERBOSE
Control: tags -1 moreinfo unreproducible On Thu, 22 Aug 2019 00:10:08 +0200 =?utf-8?q?Cl=C3=A9ment_Hermann?= wrote: > Package: debhelper > Version: 12.5.3 > Severity: normal > > Hi, > > while working on a package, I had trouble finding out why some file were > disapearing without any reason and no entry in build log, despite using > DH_VERBOSE. > > Looking at the code, it's because > glob_expand_error_handler_silently_ignores is used, I guess to avoid > warning about not being able to remove non-existing files. > > It would be nice if dh_clean would print something about files being > removed, at least when DH_VERBOSE=1. IMO, warnings about > non-existing files are OK if DH_VERBOSE is used. > > What do you think? I didn't really look at a possible patch yet, I > wanted to discuss it first. > > Cheers, > > -- > nodens > > [...] Hi, I cannot reproduce the issue from the description. When I run dh_clean with verbose it lists files/directories being removed. """ > dh_clean -v foo > rm -f debian/debhelper-build-stamp > rm -rf debian/.debhelper/ > rm -f -- debian/debhelper.substvars debian/dh-systemd.substvars foo > debian/files > ^^^ > rm -fr -- debian/debhelper/ debian/tmp/ debian/dh-systemd/ > [...] """ (see ^^^ line) Can you provide a concrete example where it does not work? Thanks, ~Niels
Bug#935364: debhelper: dh_clean doesn't print info about files listed in debian/clean being removed, even with DH_VERBOSE
Package: debhelper Version: 12.5.3 Severity: normal Hi, while working on a package, I had trouble finding out why some file were disapearing without any reason and no entry in build log, despite using DH_VERBOSE. Looking at the code, it's because glob_expand_error_handler_silently_ignores is used, I guess to avoid warning about not being able to remove non-existing files. It would be nice if dh_clean would print something about files being removed, at least when DH_VERBOSE=1. IMO, warnings about non-existing files are OK if DH_VERBOSE is used. What do you think? I didn't really look at a possible patch yet, I wanted to discuss it first. Cheers, -- nodens -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.2.0-2-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE=fr_FR.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages debhelper depends on: ii autotools-dev20180224.1 ii dh-autoreconf19 ii dh-strip-nondeterminism 1.5.0-1 ii dpkg 1.19.7 ii dpkg-dev 1.19.7 ii dwz 0.13-1 ii file 1:5.37-5 ii libdpkg-perl 1.19.7 ii man-db 2.8.6.1-1 ii perl 5.28.1-6 ii po-debconf 1.0.21 debhelper recommends no packages. Versions of packages debhelper suggests: ii dh-make 2.201901 -- no debconf information
