Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
On Wed, Jan 08, 2020 at 07:50:11PM +, Lajos Veres wrote: > I have checked this page and it mentions some problems: > https://qa.debian.org/debcheck.php?dist=unstable=misspell-fixer > > I believe it would be easy to disable dh_auto_test and remove kcov > from the dependencies. > make test generates a coverage report with kcov, but otherwise kcov is > not really neded. > Then I guess the debian/tests/control could run the same tests. Although I > am not really sure when. This applies only to some architectures which have few users, it would be a pity to lose tests for archs that are ok. A plan maximum would be to make the kcov B-Dependency arch-dependant: Build-Depends: kcov [amd64 arm64 armel armhf i386 ppc64el powerpc ppc64 x32] with dh_auto_test having an: if which kcov >/dev/null; then dh_auto_test; fi but this requires a bit of testing on different archs. > Does this make sense? > (Does this problem has any importance at all?) The package is arch:all, and no one really is going to build it on some obscure architecture. After all, the code has no compiled parts. Thus, I'd just ignore the problem. Debcheck has a load of other false positives anyway. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ A MAP07 (Dead Simple) raspberry tincture recipe: 0.5l 95% alcohol, ⣾⠁⢠⠒⠀⣿⡁ 1kg raspberries, 0.4kg sugar; put into a big jar for 1 month. ⢿⡄⠘⠷⠚⠋⠀ Filter out and throw away the fruits (can dump them into a cake, ⠈⠳⣄ etc), let the drink age at least 3-6 months.
Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
Hi, I have checked this page and it mentions some problems: https://qa.debian.org/debcheck.php?dist=unstable=misspell-fixer I believe it would be easy to disable dh_auto_test and remove kcov from the dependencies. make test generates a coverage report with kcov, but otherwise kcov is not really neded. Then I guess the debian/tests/control could run the same tests. Although I am not really sure when. Does this make sense? (Does this problem has any importance at all?) Thank you! Best regards, -- Lajos Veres vla...@gmail.com 07927 460 778
Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
On Mon, 30 Dec 2019, Adam Borowski wrote: > On Mon, Dec 30, 2019 at 12:00:31AM +, Lajos Veres wrote: > > I have just uploaded a newer version: > > https://mentors.debian.net/package/misspell-fixer > > https://mentors.debian.net/debian/pool/main/m/misspell-fixer/misspell-fixer_0.2-1.dsc > > Hi! Thanks for checking it. > While the only change I disagree with is removal of Vcs-Browser, the I misunderstood first this: https://www.debian.org/doc/debian-policy/upgrading-checklist.html#version-4-4-1 --- A package control file must not have more than one Vcs- field. --- Anyway I have just reverted it. > changelog really should contain something other than: > * Debian packaging tweaks. > > That line could cover anything but "New upstream release"... > > Could you please mention what actually got changed? Yes. Done. (The main bits of the new upstream release are the packaging tweaks. I have described them a little better. I hope I have not misunderstood anything. :) I have just uploaded a newer version with the fixes to the same place. Best regards, Lajos > > Meow! > -- Lajos Veres vla...@gmail.com 07927 460 778
Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
On Mon, Dec 30, 2019 at 12:00:31AM +, Lajos Veres wrote: > I have just uploaded a newer version: > https://mentors.debian.net/package/misspell-fixer > https://mentors.debian.net/debian/pool/main/m/misspell-fixer/misspell-fixer_0.2-1.dsc Hi! While the only change I disagree with is removal of Vcs-Browser, the changelog really should contain something other than: * Debian packaging tweaks. That line could cover anything but "New upstream release"... Could you please mention what actually got changed? Meow! -- ⢀⣴⠾⠻⢶⣦⠀ A MAP07 (Dead Simple) raspberry tincture recipe: 0.5l 95% alcohol, ⣾⠁⢠⠒⠀⣿⡁ 1kg raspberries, 0.4kg sugar; put into a big jar for 1 month. ⢿⡄⠘⠷⠚⠋⠀ Filter out and throw away the fruits (can dump them into a cake, ⠈⠳⣄ etc), let the drink age at least 3-6 months.
Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
Thanks. I have just uploaded a newer version: https://mentors.debian.net/package/misspell-fixer https://mentors.debian.net/debian/pool/main/m/misspell-fixer/misspell-fixer_0.2-1.dsc I hope I have not missed anything. Best regards, Lajos On Sun, 29 Dec 2019, Adam Borowski wrote: > On Sat, Dec 28, 2019 at 10:25:59PM +, Lajos Veres wrote: > > I have made some small modifications partially to address your > > recommendation and the excuses listed here: > > https://tracker.debian.org/pkg/misspell-fixer > > > > - I have removed the mentioned files. > > https://github.com/vlajos/misspell-fixer/commit/0aeb0ea73e7ce5b0e3c8500886abc57168c8b78c > > - Updated the standards-version. > > https://github.com/vlajos/misspell-fixer/commit/81d9894d8875913cf0d397c99eb88a04a8d50dca > > - Added Multi-Arch: foreign. > > https://github.com/vlajos/misspell-fixer/commit/4f51acf15f22a2ec58a1c317b4563483f6282aa4 > > > > But unfortunately most of the remaining excuses are a little unclear for > > me... > > Could you please help me to understand them? > > > > > Rejected due to piuparts regression - > > > https://piuparts.debian.org/sid/source/m/misspell-fixer.html > > > > If I follow the link it says: > > piuparts-result: failed-testing 0.1-1 > > > > And when I follow this link as well: > > https://piuparts.debian.org/sid/state-failed-testing.html#misspell-fixer > > It claims, among others, that basically every file on the system has > disappeared. That's nonsense. Looks like that part of the infrastructure > made a boo-boo. > > A package with no preinst/postinst/prerm/postrm can't possibly fail piuparts > testing -- it carries only static files that are added/removed by dpkg. You > have no Replaces that'd allow a file conflict, and your package is a leaf > one with no bogus symlinks that could possibly redirect something else. > > And, it passes piuparts on my box. > > > > Migration status for misspell-fixer (- to 0.1-1): BLOCKED: > > > Rejected/violates migration policy/introduces a regression > > > > Is this one just the end result of the others? > > Yeah. > > > > Not built on buildd: arch all binaries uploaded by kilobyte, a new > > > source-only upload is needed to allow migration > > > > This buildd related error message is also not really clear for me. Should > > I do something differently? > > According to new Release Team's rules, only packages built on the official > infrastructure are allowed to the new release, and the first upload can't > possibly be. Until someone implements a better way, every package has to be > built twice, and arch:all don't currently allow automated rebuilds. > > This means, you need to make another upload. > > And for this reason I did not wait until nits like the redundant files are > fixed: that second upload is a good opportunity to fix them. > > > > > > > There are minor issues such as: > > > > > * unused file debian/misspell-fixer-docs.docs > > > > > * redundant debian/README.source (Homepage: is a field it two other > > > > > files > > > > > already) > > > Meow! > -- Lajos Veres vla...@gmail.com 07927 460 778
Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
On Sat, Dec 28, 2019 at 10:25:59PM +, Lajos Veres wrote: > I have made some small modifications partially to address your > recommendation and the excuses listed here: > https://tracker.debian.org/pkg/misspell-fixer > > - I have removed the mentioned files. > https://github.com/vlajos/misspell-fixer/commit/0aeb0ea73e7ce5b0e3c8500886abc57168c8b78c > - Updated the standards-version. > https://github.com/vlajos/misspell-fixer/commit/81d9894d8875913cf0d397c99eb88a04a8d50dca > - Added Multi-Arch: foreign. > https://github.com/vlajos/misspell-fixer/commit/4f51acf15f22a2ec58a1c317b4563483f6282aa4 > > But unfortunately most of the remaining excuses are a little unclear for me... > Could you please help me to understand them? > > > Rejected due to piuparts regression - > > https://piuparts.debian.org/sid/source/m/misspell-fixer.html > > If I follow the link it says: > piuparts-result: failed-testing 0.1-1 > > And when I follow this link as well: > https://piuparts.debian.org/sid/state-failed-testing.html#misspell-fixer It claims, among others, that basically every file on the system has disappeared. That's nonsense. Looks like that part of the infrastructure made a boo-boo. A package with no preinst/postinst/prerm/postrm can't possibly fail piuparts testing -- it carries only static files that are added/removed by dpkg. You have no Replaces that'd allow a file conflict, and your package is a leaf one with no bogus symlinks that could possibly redirect something else. And, it passes piuparts on my box. > > Migration status for misspell-fixer (- to 0.1-1): BLOCKED: > > Rejected/violates migration policy/introduces a regression > > Is this one just the end result of the others? Yeah. > > Not built on buildd: arch all binaries uploaded by kilobyte, a new > > source-only upload is needed to allow migration > > This buildd related error message is also not really clear for me. Should > I do something differently? According to new Release Team's rules, only packages built on the official infrastructure are allowed to the new release, and the first upload can't possibly be. Until someone implements a better way, every package has to be built twice, and arch:all don't currently allow automated rebuilds. This means, you need to make another upload. And for this reason I did not wait until nits like the redundant files are fixed: that second upload is a good opportunity to fix them. > > > > There are minor issues such as: > > > > * unused file debian/misspell-fixer-docs.docs > > > > * redundant debian/README.source (Homepage: is a field it two other > > > > files > > > > already) Meow! -- ⢀⣴⠾⠻⢶⣦⠀ A MAP07 (Dead Simple) raspberry tincture recipe: 0.5l 95% alcohol, ⣾⠁⢠⠒⠀⣿⡁ 1kg raspberries, 0.4kg sugar; put into a big jar for 1 month. ⢿⡄⠘⠷⠚⠋⠀ Filter out and throw away the fruits (can dump them into a cake, ⠈⠳⣄ etc), let the drink age at least 3-6 months.
Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
Thank you. I have made some small modifications partially to address your recommendation and the excuses listed here: https://tracker.debian.org/pkg/misspell-fixer - I have removed the mentioned files. https://github.com/vlajos/misspell-fixer/commit/0aeb0ea73e7ce5b0e3c8500886abc57168c8b78c - Updated the standards-version. https://github.com/vlajos/misspell-fixer/commit/81d9894d8875913cf0d397c99eb88a04a8d50dca - Added Multi-Arch: foreign. https://github.com/vlajos/misspell-fixer/commit/4f51acf15f22a2ec58a1c317b4563483f6282aa4 But unfortunately most of the remaining excuses are a little unclear for me... Could you please help me to understand them? > Rejected due to piuparts regression - > https://piuparts.debian.org/sid/source/m/misspell-fixer.html If I follow the link it says: piuparts-result: failed-testing 0.1-1 And when I follow this link as well: https://piuparts.debian.org/sid/state-failed-testing.html#misspell-fixer it says: misspell-fixer:all (0, 0) (Lajos Veres ) dependency grep is successfully-tested So I see only a success message. I tried to decypher this log: https://piuparts.debian.org/sid/fail/misspell-fixer_0.1-1.log I see a big list after this line: ERROR: FAIL: After purging files have disappeared: But I cannot really figure out how could misspell-fixer's purge remove them. When I install the package, removed it, then tried to purge I received this: $ apt-get install misspell-fixer ... $ apt-get remove misspell-fixer ... $ dpkg --purge misspell-fixer dpkg: warning: ignoring request to remove misspell-fixer which isn't installed And this line appears in the above log with a warning. Could this cause this problem somehow? > Migration status for misspell-fixer (- to 0.1-1): BLOCKED: Rejected/violates > migration policy/introduces a regression Is this one just the end result of the others? Or is there some other issues I do not see? > Not built on buildd: arch all binaries uploaded by kilobyte, a new > source-only upload is needed to allow migration This buildd related error message is also not really clear for me. Should I do something differently? I believe the "too young" will be fixed by time. And I guess the "not considered" is the result of the others. Sorry for bothering you with these ones... Best regards, Lajos Veres On Tue, 24 Dec 2019, Adam Borowski wrote: > On Tue, Dec 24, 2019 at 11:21:15AM +, Lajos Veres wrote: > > Thank you. > > Do I understand well that removing those 2 files would fix these issues? > > Yeah. > > > On Mon, 23 Dec 2019, Adam Borowski wrote: > > > There are minor issues such as: > > > * unused file debian/misspell-fixer-docs.docs > > > * redundant debian/README.source (Homepage: is a field it two other files > > > already) > > > > > > but, I've uploaded to NEW as is. > > > Meow! > -- Lajos Veres vla...@gmail.com
Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
On Tue, Dec 24, 2019 at 11:21:15AM +, Lajos Veres wrote: > Thank you. > Do I understand well that removing those 2 files would fix these issues? Yeah. > On Mon, 23 Dec 2019, Adam Borowski wrote: > > There are minor issues such as: > > * unused file debian/misspell-fixer-docs.docs > > * redundant debian/README.source (Homepage: is a field it two other files > > already) > > > > but, I've uploaded to NEW as is. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ A MAP07 (Dead Simple) raspberry tincture recipe: 0.5l 95% alcohol, ⣾⠁⢠⠒⠀⣿⡁ 1kg raspberries, 0.4kg sugar; put into a big jar for 1 month. ⢿⡄⠘⠷⠚⠋⠀ Filter out and throw away the fruits (can dump them into a cake, ⠈⠳⣄ etc), let the drink age at least 3-6 months.
Bug#941947: RFS: misspell-fixer/0.1-1 [ITP] -- Tool for fixing common misspellings, typos in source code
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "misspell-fixer" * Package name: misspell-fixer Version : 0.1-1 Upstream Author : Lajos Veres * URL : https://github.com/vlajos/misspell-fixer * License : BSD-3-clause * Vcs : https://github.com/vlajos/misspell-fixer Section : devel It builds those binary packages: misspell-fixer - Tool for fixing common misspellings, typos in source code To access further information about this package, please visit the following URL: https://mentors.debian.net/package/misspell-fixer Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/m/misspell-fixer/misspell-fixer_0.1-1.dsc Changes since the last upload: * Initial release (Closes: #895712) Regards, -- Lajos Veres vlajos+deb...@gmail.com
