Bug#942520: buster-pu: package oar/2.5.8-1
Le 30/03/2020 à 23:07, Adam D. Barratt a écrit : > On Fri, 2019-11-08 at 21:55 +, Adam D. Barratt wrote: >> Control: tags -1 + confirmed >> >> On Thu, 2019-10-17 at 15:48 +0200, Vincent Danjean wrote: >>> The default behavior of perl Storable::dclone function changed >>> in buster, setting a default maximum recursion in the structures >>> [1], [2]. >>> This change has not been spotted before the release, but now >>> that buster is released and that big clusters are switching to >>> buster, this bug has been found (before the release, oar was >>> tested only on smaller cluster). >>> So, we sould like to revert to the old behavior of >>> Storable::dclone >>> in the oar package (it is just two variables to set), so that >>> oar in buster still works on big cluster (> 1000 cores). >>> >> >> Please go ahead. > > Any news on that? Sorry, I forgot it. The package is ready (and in use in a local repo) we will upload it today. Regards, Vincent > Regards, > > Adam > -- Vincent Danjean GPG key ID 0xD17897FA vdanj...@debian.org GPG key fingerprint: 621E 3509 654D D77C 43F5 CA4A F6AE F2AF D178 97FA Unofficial pkgs: http://moais.imag.fr/membres/vincent.danjean/deb.html APT repo: deb http://people.debian.org/~vdanjean/debian unstable main
Bug#942520: buster-pu: package oar/2.5.8-1
On Fri, 2019-11-08 at 21:55 +, Adam D. Barratt wrote: > Control: tags -1 + confirmed > > On Thu, 2019-10-17 at 15:48 +0200, Vincent Danjean wrote: > > The default behavior of perl Storable::dclone function changed > > in buster, setting a default maximum recursion in the structures > > [1], [2]. > > This change has not been spotted before the release, but now > > that buster is released and that big clusters are switching to > > buster, this bug has been found (before the release, oar was > > tested only on smaller cluster). > > So, we sould like to revert to the old behavior of > > Storable::dclone > > in the oar package (it is just two variables to set), so that > > oar in buster still works on big cluster (> 1000 cores). > > > > Please go ahead. > Any news on that? Regards, Adam
Bug#942520: buster-pu: package oar/2.5.8-1
Control: tags -1 + confirmed On Thu, 2019-10-17 at 15:48 +0200, Vincent Danjean wrote: > The default behavior of perl Storable::dclone function changed > in buster, setting a default maximum recursion in the structures > [1], [2]. > This change has not been spotted before the release, but now > that buster is released and that big clusters are switching to > buster, this bug has been found (before the release, oar was > tested only on smaller cluster). > So, we sould like to revert to the old behavior of Storable::dclone > in the oar package (it is just two variables to set), so that > oar in buster still works on big cluster (> 1000 cores). > Please go ahead. Regards, Adam
Bug#942520: buster-pu: package oar/2.5.8-1
Control: tags -1 - moreinfo The package with the fix has been accepted in unstable. [and the fix itself has been used on some impacted cluster] Regards, Vincent Le 17/10/2019 à 16:15, Adam D. Barratt a écrit : > Control: tags -1 + moreinfo > > On 2019-10-17 14:48, Vincent Danjean wrote: >> The default behavior of perl Storable::dclone function changed >> in buster, setting a default maximum recursion in the structures >> [1], [2]. >> This change has not been spotted before the release, but now >> that buster is released and that big clusters are switching to >> buster, this bug has been found (before the release, oar was >> tested only on smaller cluster). >> So, we sould like to revert to the old behavior of Storable::dclone >> in the oar package (it is just two variables to set), so that >> oar in buster still works on big cluster (> 1000 cores). >> >> You can find in attachment the debdiff of our proposal. >> This would close #942467 > > This needs to be resolved in unstable before it can be considered for a > stable update. (oar currently has the same version in unstable ansd stable.) > > Regards, > > Adam -- Vincent Danjean GPG key ID 0xD17897FA vdanj...@debian.org GPG key fingerprint: 621E 3509 654D D77C 43F5 CA4A F6AE F2AF D178 97FA Unofficial pkgs: http://moais.imag.fr/membres/vincent.danjean/deb.html APT repo: deb http://people.debian.org/~vdanjean/debian unstable main
Bug#942520: buster-pu: package oar/2.5.8-1
Control: tags -1 + moreinfo On 2019-10-17 14:48, Vincent Danjean wrote: The default behavior of perl Storable::dclone function changed in buster, setting a default maximum recursion in the structures [1], [2]. This change has not been spotted before the release, but now that buster is released and that big clusters are switching to buster, this bug has been found (before the release, oar was tested only on smaller cluster). So, we sould like to revert to the old behavior of Storable::dclone in the oar package (it is just two variables to set), so that oar in buster still works on big cluster (> 1000 cores). You can find in attachment the debdiff of our proposal. This would close #942467 This needs to be resolved in unstable before it can be considered for a stable update. (oar currently has the same version in unstable ansd stable.) Regards, Adam
Bug#942520: buster-pu: package oar/2.5.8-1
Package: release.debian.org Severity: normal Tags: buster User: release.debian@packages.debian.org Usertags: pu Hi, The default behavior of perl Storable::dclone function changed in buster, setting a default maximum recursion in the structures [1], [2]. This change has not been spotted before the release, but now that buster is released and that big clusters are switching to buster, this bug has been found (before the release, oar was tested only on smaller cluster). So, we sould like to revert to the old behavior of Storable::dclone in the oar package (it is just two variables to set), so that oar in buster still works on big cluster (> 1000 cores). You can find in attachment the debdiff of our proposal. This would close #942467 Regards, Vincent [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?archive=no=912695 [2] https://rt.perl.org/Public/Bug/Display.html?id=133326 -- System Information: Debian Release: bullseye/sid APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'oldstable-updates'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386, armel, mipsel Kernel: Linux 5.2.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE=fr_FR.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) diff -Nru oar-2.5.8/debian/changelog oar-2.5.8/debian/changelog --- oar-2.5.8/debian/changelog 2019-01-04 21:06:58.0 +0100 +++ oar-2.5.8/debian/changelog 2019-10-17 15:31:19.0 +0200 @@ -1,3 +1,10 @@ +oar (2.5.8-1+deb10u1) buster; urgency=medium + + * Revert to stretch behavior for Storable::dclone perl function (Closes: +#942467) + + -- Vincent Danjean Thu, 17 Oct 2019 15:31:19 +0200 + oar (2.5.8-1) unstable; urgency=medium [ Pierre Neyron ] diff -Nru oar-2.5.8/debian/patches/00-fix-max-recursion-depth-in-perl-storable.patch oar-2.5.8/debian/patches/00-fix-max-recursion-depth-in-perl-storable.patch --- oar-2.5.8/debian/patches/00-fix-max-recursion-depth-in-perl-storable.patch 1970-01-01 01:00:00.0 +0100 +++ oar-2.5.8/debian/patches/00-fix-max-recursion-depth-in-perl-storable.patch 2019-10-17 15:31:19.0 +0200 @@ -0,0 +1,18 @@ +Fix Max. recursion depth with nested structures + +Due to a restriction implemented in Perl's Storable module +distributed in Buster, Storable::dclone prevent recursions that +were used before by oar. +Removing here this limitation, going back to the previous behavior. +--- a/sources/core/common-libs/lib/OAR/Schedulers/ResourceTree.pm b/sources/core/common-libs/lib/OAR/Schedulers/ResourceTree.pm +@@ -7,6 +7,9 @@ + use Storable qw(dclone); + #use Time::HiRes qw(gettimeofday); + ++$Storable::recursion_limit=-1; ++$Storable::recursion_limit_hash=-1; ++ + ### + # RESOURCE TREE MANAGEMENT # + ### diff -Nru oar-2.5.8/debian/patches/series oar-2.5.8/debian/patches/series --- oar-2.5.8/debian/patches/series 2019-01-04 21:06:58.0 +0100 +++ oar-2.5.8/debian/patches/series 2019-10-17 15:31:19.0 +0200 @@ -0,0 +1 @@ +00-fix-max-recursion-depth-in-perl-storable.patch
