Bug#943499: telegram-desktop: Disable building in big endian archs
Hi Mattia! On 19/10/27 02:30, Mattia Rizzolo wrote: > On Fri, Oct 25, 2019 at 11:51:34PM -0300, Lisandro Damián Nicanor Pérez Meyer > wrote: > > Today you tought me about this table, so using both things: > > > > Architecture: amd64 arm64 armel armhf i386 mips64el mipsel ppc64el hppa > > hurd-i386 ia64 kfreebsd-amd64 kfreebsd-i386 m68k riscv64 sh4 x32 > > These are only the current ones and it's going to need tweaking every > time we change the set of architectures debian builds for. Yes, but it does not happens so often. > There is really no good way to express "only LE archs" (similary to how > we don't have "only 64 bit archs"). Every time Architecture needs to be > anything which is not "any" or "all" it gets messy… It is. I guess dpkg developers must have a reason not to do it in another way, but... > Maybe, for clarity a check could be added in d/rules aborting the build > very early? While I admit it's really up to the maintainer I would *personally* see it as a hack... but that's just my point of view, feel free to implement it as you see it fits you better :-) Cheers, Lisandro.
Bug#943499: telegram-desktop: Disable building in big endian archs
On Fri, Oct 25, 2019 at 11:51:34PM -0300, Lisandro Damián Nicanor Pérez Meyer wrote: > Today you tought me about this table, so using both things: > > Architecture: amd64 arm64 armel armhf i386 mips64el mipsel ppc64el hppa > hurd-i386 ia64 kfreebsd-amd64 kfreebsd-i386 m68k riscv64 sh4 x32 These are only the current ones and it's going to need tweaking every time we change the set of architectures debian builds for. There is really no good way to express "only LE archs" (similary to how we don't have "only 64 bit archs"). Every time Architecture needs to be anything which is not "any" or "all" it gets messy… Maybe, for clarity a check could be added in d/rules aborting the build very early? -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#943499: telegram-desktop: Disable building in big endian archs
Hi Коля! On 19/10/25 09:51, Коля Гурьев wrote: > tags 943499 patch > stop > > 25.10.2019 17:12, Lisandro Damián Nicanor Pérez Meyer пишет: > > A removal for those archs has been asked in > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943467 but > > ideally the package should list the architectures it builds instead of > > being Arch: any. This will not > > waste buildds' time and also provide a clearer insight to people looking > > for this app in their archs. > > I agree with you, but dpkg does not seem to provide an easy way to > express such assertion that the package works only on little-endian > architectures. > > I tried to just list[1] all possible CPUs in the Architecture field, but > I do not understand its syntax. It looks like line breaks or comments > are not allowed. > > [1]: > https://salsa.debian.org/debian/telegram-desktop/commit/c22fa4f7cfb3105f3c9889d5342ff7aeeef68157 See https://www.debian.org/doc/debian-policy/ch-controlfields.html#architecture I normally take a look at buildd.debian.org and create the list from there: https://buildd.debian.org/status/package.php?p=telegram%2ddesktop Today you tought me about this table, so using both things: Architecture: amd64 arm64 armel armhf i386 mips64el mipsel ppc64el hppa hurd-i386 ia64 kfreebsd-amd64 kfreebsd-i386 m68k riscv64 sh4 x32 Cheers, Lisandro.
Bug#943499: telegram-desktop: Disable building in big endian archs
tags 943499 patch
stop
25.10.2019 17:12, Lisandro Damián Nicanor Pérez Meyer пишет:
> A removal for those archs has been asked in
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943467 but
> ideally the package should list the architectures it builds instead of being
> Arch: any. This will not
> waste buildds' time and also provide a clearer insight to people looking for
> this app in their archs.
I agree with you, but dpkg does not seem to provide an easy way to
express such assertion that the package works only on little-endian
architectures.
I tried to just list[1] all possible CPUs in the Architecture field, but
I do not understand its syntax. It looks like line breaks or comments
are not allowed.
[1]:
https://salsa.debian.org/debian/telegram-desktop/commit/c22fa4f7cfb3105f3c9889d5342ff7aeeef68157
Below is a copy of the commit.
commit c22fa4f7cfb3105f3c9889d5342ff7aeeef68157
Author: Nicholas Guriev
Date: Tue Oct 22 09:10:07 2019 +0300
Restrict supported architectures
diff --git a/debian/control b/debian/control
index 4fd34d9..ba7a6ec 100644
--- a/debian/control
+++ b/debian/control
@@ -35,7 +35,9 @@ Vcs-Git: https://salsa.debian.org/debian/telegram-desktop.git
Vcs-Browser: https://salsa.debian.org/debian/telegram-desktop
Package: telegram-desktop
-Architecture: any
+# Only little endian is supported. Cmd:
+# awk '/^\s*[^#]/ && $5 == "little" {print $1}' ../dpkg-1.19.7/data/cputable
+Architecture: i386 ia64 alpha amd64 arm arm64 mipsel mipsr6el mips64el
mips64r6el nios2 powerpcel ppc64el riscv64 sh3 sh4 tilegx
Depends: qt5-image-formats-plugins (>=5.5), ${misc:Depends}, ${shlibs:Depends}
Recommends: fonts-open-sans
Built-Using: ${cpplibs:Built-Using}
Bug#943499: telegram-desktop: Disable building in big endian archs
Source: telegram-desktop Version: 1.8.15-1 Severity: wishlist Hi! As discussed in https://salsa.debian.org/debian/telegram-desktop/commit/86d77755e0d40220e3d592b312d28315e134664f#note_116122 (expand the Modify-build-scripts.patch box) telegram-desktop upstream does not supports big endian architectures. A removal for those archs has been asked in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943467 but ideally the package should list the architectures it builds instead of being Arch: any. This will not waste buildds' time and also provide a clearer insight to people looking for this app in their archs. Thanks for considering it, Lisandro. -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'buildd-unstable'), (500, 'testing'), (1, 'experimental-debug'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386, arm64, armhf Kernel: Linux 5.3.0-1-amd64 (SMP w/2 CPU cores) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8), LANGUAGE=es_AR:es (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled -- no debconf information
