Bug#959388: [Pkg-privacy-maintainers] Bug#959388: torbrowser fails to start due to lacking fonts/* entry in apparmor

2020-05-07 Thread Santiago R.R.
El 07/05/20 a las 22:30, Roger Shimizu escribió:
> On Thu, May 7, 2020 at 9:41 PM Santiago R.R.  wrote:
> >
> > I have unsuccessfully tried to reproduce the bug in the same machine,
> > even removing my .local/share/torbrowser/ directory. I still see the
> > apparmor DENIED message in the logs, but torbrowser starts without
> > issues.
> 
> If you see the DENIED log in dmesg, the problem still exists.
> And if after the apparmor patch, the DENIED log gets gone, that tells
> us the patch is valid.
> 
> > So sorry if this bug is just noise.
> 
> Just double confirm my question above. and we'll decide whether to
> move forward to the pull-request.
> Thank you!

I can confirm I see the DENIED without the patch, if
.local/share/torbrowser/ is clean. No messages with the patch.

Cheers!

 -- S


signature.asc
Description: PGP signature


Bug#959388: [Pkg-privacy-maintainers] Bug#959388: torbrowser fails to start due to lacking fonts/* entry in apparmor

2020-05-07 Thread Roger Shimizu
On Thu, May 7, 2020 at 9:41 PM Santiago R.R.  wrote:
>
> I have unsuccessfully tried to reproduce the bug in the same machine,
> even removing my .local/share/torbrowser/ directory. I still see the
> apparmor DENIED message in the logs, but torbrowser starts without
> issues.

If you see the DENIED log in dmesg, the problem still exists.
And if after the apparmor patch, the DENIED log gets gone, that tells
us the patch is valid.

> So sorry if this bug is just noise.

Just double confirm my question above. and we'll decide whether to
move forward to the pull-request.
Thank you!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1



Bug#959388: [Pkg-privacy-maintainers] Bug#959388: torbrowser fails to start due to lacking fonts/* entry in apparmor

2020-05-07 Thread Santiago R.R.
El 05/05/20 a las 20:27, Roger Shimizu escribió:
> control: tags -1 +pending
> control: forwarded -1 
> https://github.com/micahflee/torbrowser-launcher/pull/468
> 
> Dear Santiago,
> 
> Thanks for your report and patch!
> 
> On Sat, May 2, 2020 at 4:51 AM Santiago R.R.  wrote:
> >
> > Package: torbrowser-launcher
> > Version: 0.3.2-10
> >
> > The attached patch seems to have fixed here the issue.
> 
> I guess you meet this issue because I fixed the language locale issue
> in previous upload.
> However I didn't reproduce this in my buster-bpo system. Maybe this
> only occurs in sid?

I have unsuccessfully tried to reproduce the bug in the same machine,
even removing my .local/share/torbrowser/ directory. I still see the
apparmor DENIED message in the logs, but torbrowser starts without
issues.

So sorry if this bug is just noise.

> 
> Anyway, I upstreamed your patch:
> - https://github.com/micahflee/torbrowser-launcher/pull/468
…

Thanks!

Cheers,

 -- S


signature.asc
Description: PGP signature


Bug#959388: [Pkg-privacy-maintainers] Bug#959388: torbrowser fails to start due to lacking fonts/* entry in apparmor

2020-05-05 Thread Roger Shimizu
control: tags -1 +pending
control: forwarded -1 https://github.com/micahflee/torbrowser-launcher/pull/468

Dear Santiago,

Thanks for your report and patch!

On Sat, May 2, 2020 at 4:51 AM Santiago R.R.  wrote:
>
> Package: torbrowser-launcher
> Version: 0.3.2-10
>
> The attached patch seems to have fixed here the issue.

I guess you meet this issue because I fixed the language locale issue
in previous upload.
However I didn't reproduce this in my buster-bpo system. Maybe this
only occurs in sid?

Anyway, I upstreamed your patch:
- https://github.com/micahflee/torbrowser-launcher/pull/468

> Thanks for maintaining torbrowser-launcher!

Thanks for using it.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1



Bug#959388: torbrowser fails to start due to lacking fonts/* entry in apparmor

2020-05-01 Thread Santiago R.R.
Package: torbrowser-launcher
Version: 0.3.2-10
Severity: important
Tags: patch

When trying to launch torbrowser, I got this:

type=1400 audit(1588360736.602:285): apparmor="DENIED"
operation="link" profile="torbrowser_firefox"

name="/home/user/.local/share/torbrowser/tbb/x86_64/tor-browser_es-ES/Browser/fonts/.uuid.LCK"
pid=368816 comm="firefox.real" requested_mask="l" denied_mask="l"
fsuid=1000 ouid=1000

target="/home/user/.local/share/torbrowser/tbb/x86_64/tor-browser_es-ES/Browser/fonts/.uuid.TMP-8RQs3m"

The attached patch seems to have fixed here the issue.

Thanks for maintaining torbrowser-launcher!

 -- S


-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 
'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.5.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=es_CO.UTF-8, LC_CTYPE=es_CO.UTF-8 (charmap=UTF-8), 
LANGUAGE=es_CO.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages torbrowser-launcher depends on:
ii  ca-certificates   20190110
ii  libdbus-glib-1-2  0.110-5
ii  python3   3.8.2-3
ii  python3-gpg   1.13.1-7+b1
ii  python3-pyqt5 5.14.2+dfsg-1+b1
ii  python3-requests  2.23.0+dfsg-2
ii  python3-socks 1.6.8+dfsg-1

Versions of packages torbrowser-launcher recommends:
ii  tor  0.4.2.7-1

Versions of packages torbrowser-launcher suggests:
ii  apparmor  2.13.4-1+b1

-- Configuration Files:
/etc/apparmor.d/torbrowser.Browser.firefox changed [not included]

-- no debconf information
--- torbrowser.Browser.firefox.orig	2020-05-01 21:38:49.701044777 +0200
+++ torbrowser.Browser.firefox	2020-05-01 21:38:39.40119 +0200
@@ -68,6 +68,7 @@
   owner @{torbrowser_home_dir}/TorBrowser/Data/Browser/profiles.ini r,
   owner @{torbrowser_home_dir}/TorBrowser/Data/Browser/profile.default/{,**} rwk,
   owner @{torbrowser_home_dir}/TorBrowser/Data/fontconfig/fonts.conf r,
+  owner @{torbrowser_home_dir}/fonts/* l,
   owner @{torbrowser_home_dir}/TorBrowser/Tor/tor px,
   owner @{torbrowser_home_dir}/TorBrowser/Tor/ r,
   owner @{torbrowser_home_dir}/TorBrowser/Tor/*.so mr,


signature.asc
Description: PGP signature