Bug#959791: horizon-eda FTCBFS: uses the build architecture pkg-config

2020-05-05 Thread Uwe Steinmann 
Upѕtream has changed the Makefile. The next release will have it.

This is the commit.

https://github.com/horizon-eda/horizon/commit/cfa44300b932e0a71228be3689c5be7d185f090c

  Uwe

-- 
  MMK GmbH, Fleyer Str. 196, 58097 Hagen
  uwe.steinm...@mmk-hagen.de
  Tel: 02331 840446Fax: 02331 843920


signature.asc
Description: PGP signature

Bug#959791: horizon-eda FTCBFS: uses the build architecture pkg-config

2020-05-05 Thread Helmut Grohne 
Hi,

On Tue, May 05, 2020 at 02:31:59PM +0200, Uwe Steinmann wrote:
> Would it help, if I ask upstream to use PKG_CONFIG instead?

Yes, that'd be a good idea, because the vast majority of projects use
that variable. It provides consistency across projects and thereby makes
it more intuitive to use.

There is no need to pass a PKG_CONFIG assignment via dh_auto_build as
debhelper takes care of that. (However, dh_auto_install still needs it
here.)

Helmut

Bug#959791: horizon-eda FTCBFS: uses the build architecture pkg-config

2020-05-05 Thread Uwe Steinmann 
On Tue, May 05, 2020 at 08:51:32AM +0200, Helmut Grohne wrote:
> horizon-eda fails to cross build from source, because it uses the build
> architecture pkg-config. The upstream Makefile actually makes pkg-config
> substitutable, but it uses the non-standard variable PKGCONFIG whereas
> dh_auto_build substitutes PKG_CONFIG. Beyond that, make install also
Would it help, if I ask upstream to use PKG_CONFIG instead?

  Uwe

-- 
  MMK GmbH, Fleyer Str. 196, 58097 Hagen
  uwe.steinm...@mmk-hagen.de
  Tel: 02331 840446Fax: 02331 843920


signature.asc
Description: PGP signature

Bug#959791: horizon-eda FTCBFS: uses the build architecture pkg-config

2020-05-05 Thread Helmut Grohne 
Source: horizon-eda
Version: 1.1.0-1
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: ftcbfs

horizon-eda fails to cross build from source, because it uses the build
architecture pkg-config. The upstream Makefile actually makes pkg-config
substitutable, but it uses the non-standard variable PKGCONFIG whereas
dh_auto_build substitutes PKG_CONFIG. Beyond that, make install also
needs to know about cross tools to avoid rebuilding things. Please
consider applying the attached patch to make horizon-eda cross
buildable.

Helmut
diff --minimal -Nru horizon-eda-1.1.0/debian/changelog 
horizon-eda-1.1.0/debian/changelog
--- horizon-eda-1.1.0/debian/changelog  2020-04-30 07:53:01.0 +0200
+++ horizon-eda-1.1.0/debian/changelog  2020-05-04 12:26:06.0 +0200
@@ -1,3 +1,12 @@
+horizon-eda (1.1.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
++ Pass pkg-config as PKGCONFIG.
++ Also pass cross tools to make install.
+
+ -- Helmut Grohne   Mon, 04 May 2020 12:26:06 +0200
+
 horizon-eda (1.1.0-1) unstable; urgency=medium
 
   * New upstream version
diff --minimal -Nru horizon-eda-1.1.0/debian/rules 
horizon-eda-1.1.0/debian/rules
--- horizon-eda-1.1.0/debian/rules  2020-01-17 14:12:27.0 +0100
+++ horizon-eda-1.1.0/debian/rules  2020-05-04 12:26:06.0 +0200
@@ -2,6 +2,7 @@
 # output every command that modifies files on the build system.
 export DH_VERBOSE = 1
 
+-include /usr/share/dpkg/buildtools.mk
 
 # see FEATURE AREAS in dpkg-buildflags(1)
 #export DEB_BUILD_MAINT_OPTIONS = hardening=+all
@@ -12,6 +13,7 @@
 # package maintainers to append LDFLAGS
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 export PREFIX=/usr
+PKG_CONFIG ?= pkg-config
 
 %:
dh $@
@@ -19,7 +21,10 @@
 
 override_dh_auto_build:
doxygen doxygen.config
-   dh_auto_build
+   dh_auto_build -- 'PKGCONFIG=$(PKG_CONFIG)'
+
+override_dh_auto_install:
+   dh_auto_install -- 'CXX=$(CXX)' 'PKGCONFIG=$(PKG_CONFIG)'
 
 override_dh_clean:
-rm -r docs