Bug#960448: openldap: Dynamically generate contact email

[Ryan Tandy]

Control: tag -1 pending

Fixed in git. Testing would be appreciated.

Bug#960448: openldap: Dynamically generate contact email

[Ryan Tandy]

Control: tag -1 - patch

On Tue, May 12, 2020 at 02:36:39PM -0300, Andreas Hasenack wrote:

-+WHOWHERE="Debian OpenLDAP Maintainers 
"
++WHOWHERE="$(grep ^Maintainer: debian/control | sed 's,Maintainer: ,,')"


Now I remember that I actually did try this initially.

The mkversion script is called from different parts of the build tree 
(by recursive make) and doesn't have easy access to $(top_srcdir).


The patch you've suggested just leaves WHOWHERE empty.

Bug#960448: openldap: Dynamically generate contact email

[Andreas Hasenack]

Package: openldap
Version: 2.4.50+dfsg-1
Severity: normal

Dear Maintainer,

slapd in debian sets the WHOWHERE value in d/p/set-maintainer-name to
"Debian OpenLDAP Maintainers
". It occurred to me that
in ubuntu we have that same value, which is incorrect. I propose a
dynamic way to set it:

--- a/debian/patches/set-maintainer-name
+++ b/debian/patches/set-maintainer-name
@@ -10,7 +10,7 @@
 -else
 -   WHOWHERE="$USER@$(uname -n):$(pwd)"
 -fi
-+WHOWHERE="Debian OpenLDAP Maintainers
"
++WHOWHERE="$(grep ^Maintainer: debian/control | sed 's,Maintainer: ,,')"

  cat << __EOF__
  /* This work is part of OpenLDAP Software .


This parses d/control to fetch the email address of the maintainer, so
it will be correct for both the Ubuntu and Debian packages. If you
prefer another way, like a conditional on ubuntu and debian, and use
hardcoded values instead of blindly taking whatever is in d/control,
let me know.

I looked for some tooling to parse d/control, but this simple parsing seems ok.