Bug#961532: devscripts: Missing package relation with pristine-tar (used by origtargz)

2020-05-25 Thread Christoph Berg
Re: Axel Beckert
> to my surprise the devscripts has no package relation with pristine-tar
> nor is it mentioned in devscripts' long package description despite
> origtargz uses it unconditionally. pristine-tar is though mentioned in
> the origtargz(1) man page and changelog.Debian.gz.
> 
> origtargz though ignores any errors from the pristine-tar (not sure if
> feature or bug ;-), so a missing pristine-tar binary is not noticed
> during usage as origtargz just falls back to other acquisition methods.

It intentionally ignores errors, it's really a best-effort tool to
look around where the tarball is.

Maybe it could be smarter by checking if there is a
origin/pristine-tar branch but pristine-tar isn't installed, though.

Christoph



Bug#961532: devscripts: Missing package relation with pristine-tar (used by origtargz)

2020-05-25 Thread Mattia Rizzolo
Control: severity -1 minor

On Mon, May 25, 2020 at 08:02:59PM +0200, Axel Beckert wrote:
> to my surprise the devscripts has no package relation with pristine-tar
> nor is it mentioned in devscripts' long package description despite
> origtargz uses it unconditionally. pristine-tar is though mentioned in
> the origtargz(1) man page and changelog.Debian.gz.
> 
> origtargz though ignores any errors from the pristine-tar (not sure if
> feature or bug ;-), so a missing pristine-tar binary is not noticed
> during usage as origtargz just falls back to other acquisition methods.

It's a documented feature.
origtargz tries to obtain the tarball, and just falls back through
several retrival methods.  As such, the pristine-tar is entirely
optional.

> I hence suggest as fix for this bug to add pristine-tar to either
> Suggests or Recommends and mention it in the long package description as
> optional (but IMHO for origtargz recommended) dependency of origtargz.

Done, as recommends. See the README file for a description of the whole
thing (which is then partially mirrored in the long description)

> So while the RC severity is theoretically correct due to a missing
> package relation, I have no issue if someone prefers to downgrade this
> bug to e.g. important as it IMHO is not needed to prepare a devscripts
> upload now just because of this bug report.

Indeed, RC is way too overblown for such optional feature :3


Thank you for your report!

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Bug#961532: devscripts: Missing package relation with pristine-tar (used by origtargz)

2020-05-25 Thread Axel Beckert
Package: devscripts
Version: 2.20.3
Severity: serious
Control: found -1 2.13.0

Hi,

to my surprise the devscripts has no package relation with pristine-tar
nor is it mentioned in devscripts' long package description despite
origtargz uses it unconditionally. pristine-tar is though mentioned in
the origtargz(1) man page and changelog.Debian.gz.

origtargz though ignores any errors from the pristine-tar (not sure if
feature or bug ;-), so a missing pristine-tar binary is not noticed
during usage as origtargz just falls back to other acquisition methods.

I hence suggest as fix for this bug to add pristine-tar to either
Suggests or Recommends and mention it in the long package description as
optional (but IMHO for origtargz recommended) dependency of origtargz.

So while the RC severity is theoretically correct due to a missing
package relation, I have no issue if someone prefers to downgrade this
bug to e.g. important as it IMHO is not needed to prepare a devscripts
upload now just because of this bug report.

BTW, I just checked, this issue is present since when origtargz has been
added to devscripts with version 2.13.0 from 2013. (How fitting. ;-) And
again regarding the RC severity, I'm also not sure if this really
validates stable updates in all supported releases.

-- Package-specific info:

--- /etc/devscripts.conf ---
Empty.

--- ~/.devscripts ---
DEBUILD_DPKG_BUILDPACKAGE_OPTS="-k2FF9CD59612616B5 -i -j3"
DSCVERIFY_KEYRINGS=/home/abe/.gnupg/pubring.gpg
DEBUILD_LINTIAN_OPTS="-iIE --pedantic"
DEBCHANGE_MULTIMAINT_MERGE=yes

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), 
(111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), 
(105, 'experimental-debug')
Architecture: amd64 (x86_64)

Kernel: Linux 5.6.0-1-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_WARN
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages devscripts depends on:
ii  dpkg-dev  1.19.7
ii  fakeroot  1.24-1
ii  file  1:5.38-5
ii  gnupg 2.2.20-1
ii  gnupg22.2.20-1
ii  gpgv  2.2.20-1
ii  libc6 2.30-8
ii  libfile-homedir-perl  1.004-1
ii  libfile-which-perl1.23-1
ii  libipc-run-perl   20200505.0-1
ii  libmoo-perl   2.004000-1
ii  libwww-perl   6.44-1
ii  patchutils0.3.4-2+b1
ii  perl  5.30.2-1
ii  pseudo [fakeroot] 1.9.0+git20190802+060058b-1
ii  python3   3.8.2-3
ii  sensible-utils0.0.12+nmu1
ii  wdiff 1.2.2-2+b1

Versions of packages devscripts recommends:
ii  apt 2.1.4
pn  at  
ii  curl7.68.0-1
ii  dctrl-tools 2.24-3+b1
ii  debian-keyring  2020.03.24
ii  dput-ng [dput]  1.29
ii  equivs  2.3.0
ii  libdistro-info-perl 0.23
ii  libdpkg-perl1.19.7
ii  libencode-locale-perl   1.05-1
ii  libgit-wrapper-perl 0.048-1
ii  libgitlab-api-v4-perl   0.25-1
ii  liblist-compare-perl0.53-1
ii  liblwp-protocol-https-perl  6.07-2
ii  libsoap-lite-perl   1.27-1
ii  libstring-shellquote-perl   1.04-1
ii  libtry-tiny-perl0.30-1
ii  liburi-perl 1.76-2
ii  licensecheck3.0.47-1
ii  lintian 2.76.0
ii  man-db  2.9.1-1
ii  patch   2.7.6-6
ii  python3-apt 2.1.3
ii  python3-debian  0.1.37
ii  python3-magic   2:0.4.15-4
ii  python3-requests2.23.0+dfsg-2
ii  python3-unidiff 0.5.5-2
ii  python3-xdg 0.26-3
ii  strace  5.5-3
ii  unzip   6.0-25
ii  wget1.20.3-1+b2
ii  xz-utils5.2.4-1+b1

Versions of packages devscripts suggests:
ii  adequate  0.15.2
ii  autopkgtest   5.13.1
ii  bls-standalone0.20151231+b1
ii  bsd-mailx [mailx] 8.1.2-0.20180807cvs-1+b1
ii  build-essential   12.8
ii  check-all-the-things  2017.05.20+nmu1
pn  cvs-buildpackage  
ii  debhelper 13.1
ii  devscripts-el 40.4
ii  diffoscope145
ii  disorderfs0.5.10-1
pn  dose-extra
ii  duck  0.13.1
ii  faketime  0.9.7-3
ii  gnuplot   5.2.8+dfsg1-2
ii  gnuplot-qt