Bug#962074: blender: crash in an assertion and doubt about CMAKE_BUILD_TYPE

2020-07-04 Thread Antonio Ospite
On Tue, 30 Jun 2020 14:01:50 +0200
Fabian Greffrath  wrote:

> Hi there,
> 
> Am 2020-06-30 13:49, schrieb Matteo F. Vescovi:
> > I'm spending few days of [VAC] so I'm afk.
> > Feel free to provide me a patch to fix the issue and I'll more than
> > happy to apply it to the package once I'm back, as already done in the
> > past. ;-)
> 
> will adding the line
> 
> export DEB_CPPFLAGS_MAINT_APPEND = -DNDEBUG
> 
> to debian/rules already do the fix?
> 
>   - Fabian

Thanks Fabian, this is viable as a minimum fix indeed.

The intent of my original report was also to ask Matteo if he had an
opinion about building with CMAKE_BUILD_TYPE=Release instead, since I
may not be familiar with all the implications.

But yeah, let's play it safe and go with the -DNDEBUG fix.

There is another issue with 2.83.0+dfsg as apparently something
changed upstream about fonts installation, I think the following commits
break some assumptions in
debian/patches/0004-locales_directory_install.patch:
https://github.com/blender/blender/commit/68e341e9d59ae917eba992591f4f60660f6c58ff
https://github.com/blender/blender/commit/d7514914894e9c96c9eab21fb625a2021aaa71cb

I opened an MR which should fix both issues:
https://salsa.debian.org/multimedia-team/blender/-/merge_requests/2

Thanks,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?



Bug#962074: blender: crash in an assertion and doubt about CMAKE_BUILD_TYPE

2020-06-30 Thread Fabian Greffrath

Hi there,

Am 2020-06-30 13:49, schrieb Matteo F. Vescovi:

I'm spending few days of [VAC] so I'm afk.
Feel free to provide me a patch to fix the issue and I'll more than
happy to apply it to the package once I'm back, as already done in the
past. ;-)


will adding the line

export DEB_CPPFLAGS_MAINT_APPEND = -DNDEBUG

to debian/rules already do the fix?

 - Fabian



Bug#962074: blender: crash in an assertion and doubt about CMAKE_BUILD_TYPE

2020-06-30 Thread Matteo F. Vescovi
Ciao Antonio!

Il lun 29 giu 2020, 21:27 Antonio Ospite  ha scritto:

> Package: blender
> Version: 2.83.1+dfsg-1
> Followup-For: Bug #962074
>
> Dear Maintainer,
>
> the crasher is still there in 2.83.1+dfsg-1, could you please consider
> adjusting the Cmake building flags to avoid it?
>
> A couple of alternative solutions are mentioned in the original report,
> let me know if that report is confusing and if you prefer a summary of
> the situation.
>

I'm spending few days of [VAC] so I'm afk.
Feel free to provide me a patch to fix the issue and I'll more than happy
to apply it to the package once I'm back, as already done in the past. ;-)

Cheers.

mfv

>


Bug#962074: blender: crash in an assertion and doubt about CMAKE_BUILD_TYPE

2020-06-29 Thread Antonio Ospite
Package: blender
Version: 2.83.1+dfsg-1
Followup-For: Bug #962074

Dear Maintainer,

the crasher is still there in 2.83.1+dfsg-1, could you please consider
adjusting the Cmake building flags to avoid it?

A couple of alternative solutions are mentioned in the original report,
let me know if that report is confusing and if you prefer a summary of
the situation.

Thanks,
   Antonio

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), 
LANGUAGE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages blender depends on:
ii  blender-data  2.83.1+dfsg-1
ii  fonts-dejavu  2.37-2
ii  libavcodec58  7:4.3-2
ii  libavdevice58 7:4.3-2
ii  libavformat58 7:4.3-2
ii  libavutil56   7:4.3-2
ii  libboost-locale1.71.0 1.71.0-6+b2
ii  libc6 2.30-8
ii  libfftw3-double3  3.3.8-2
ii  libfreetype6  2.10.1-2
ii  libgcc-s1 10.1.0-4
ii  libgl11.3.1-1
ii  libglew2.12.1.0-4+b1
ii  libgomp1  10.1.0-4
ii  libilmbase24  2.3.0-6
ii  libjack0 [libjack-0.125]  1:0.125.0-3+b1
ii  libjemalloc2  5.2.1-1
ii  libjpeg62-turbo   1:1.5.2-2+b1
ii  libopenal11:1.19.1-1+b1
ii  libopencolorio1v5 1.1.1~dfsg0-6+b1
ii  libopenexr24  2.3.0-6
ii  libopenimageio2.1 2.1.16.0~dfsg0-1
ii  libopenjp2-7  2.3.1-1
ii  libopenvdb7.0 7.0.0-3+b1
ii  libosdcpu3.4.33.4.3-3
ii  libosdgpu3.4.33.4.3-3
ii  libpcre3  2:8.39-13
ii  libpng16-16   1.6.37-2
ii  libpython3.8  3.8.3-1
ii  libsdl2-2.0-0 2.0.12+dfsg1-1
ii  libsndfile1   1.0.28-8
ii  libspnav0 0.2.3-1+b2
ii  libstdc++610.1.0-4
ii  libswscale5   7:4.3-2
ii  libtbb2   2020.2-2
ii  libtiff5  4.1.0+git191117-2
ii  libx11-6  2:1.6.9-2+b1
ii  libxfixes31:5.0.3-2
ii  libxi62:1.7.10-1
ii  libxml2   2.9.10+dfsg-5+b1
ii  libxrender1   1:0.9.10-1
ii  libxxf86vm1   1:1.1.4-1+b2
ii  zlib1g1:1.2.11.dfsg-2

blender recommends no packages.

blender suggests no packages.

-- no debconf information
-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?



Bug#962074: blender: crash in an assertion and doubt about CMAKE_BUILD_TYPE

2020-06-02 Thread Antonio Ospite
Package: blender
Version: 2.82.a+dfsg-1+b2
Severity: normal
Tags: upstream

Dear Maintainer,

I ran into the upstream bug T75822[1] which is caused by an assertion.

TBH being able to reproduce that bug with the blender executable shipped
in Debian was a little surprising because it is supposed to only happen
in debug builds.

The assertion is enabled in Debian because dh runs cmake with
CMAKE_BUILD_TYPE=None which in particular results in NDEBUG not being
defined, which makes asserts() to run.

It turns out that  having CMAKE_BUILD_TYPE=None by default is on
purpose[2] to make sure that cmake does not blindly override global
compilation flags if the packager didn't ask that explicitly, some
discussion can be found in [3].

My direct concern would be to just have blender not crashing, and
upstream is working on a fix[4] for that.

However the issue also raised a question about whether a Release build
type should be used for the blender Debian executable; or if at least
assertions should be disabled by defining NDEBUG.

The upstream maintainer for the linux platform would also be
interested[5] in this.

Do you have an opinion?

Thanks,
   Antonio

[1] https://developer.blender.org/T75822
[2] 
https://sources.debian.org/src/debhelper/13.1/lib/Debian/Debhelper/Buildsystem/cmake.pm/#L16
[3] https://github.com/ros-infrastructure/bloom/issues/327
[4] https://developer.blender.org/D7595
[5] https://developer.blender.org/T75822#942660

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.6.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), 
LANGUAGE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages blender depends on:
ii  blender-data  2.82.a+dfsg-1
ii  fonts-dejavu  2.37-2
ii  libavcodec58  7:4.2.2-1+b1
ii  libavdevice58 7:4.2.2-1+b1
ii  libavformat58 7:4.2.2-1+b1
ii  libavutil56   7:4.2.2-1+b1
ii  libboost-locale1.67.0 1.67.0-18
ii  libc6 2.30-8
ii  libfftw3-double3  3.3.8-2
ii  libfreetype6  2.10.1-2
ii  libgcc-s1 10.1.0-3
ii  libgl11.3.1-1
ii  libglew2.12.1.0-4+b1
ii  libgomp1  10.1.0-3
ii  libilmbase24  2.3.0-6
ii  libjack0 [libjack-0.125]  1:0.125.0-3+b1
ii  libjemalloc2  5.2.1-1
ii  libjpeg62-turbo   1:1.5.2-2+b1
ii  libopenal11:1.19.1-1+b1
ii  libopencolorio1v5 1.1.1~dfsg0-6+b1
ii  libopenexr24  2.3.0-6
ii  libopenimageio2.1 2.1.15.0~dfsg0-1
ii  libopenjp2-7  2.3.1-1
ii  libopenvdb7.0 7.0.0-3
ii  libosdcpu3.4.33.4.3-3
ii  libosdgpu3.4.33.4.3-3
ii  libpcre3  2:8.39-12+b1
ii  libpng16-16   1.6.37-2
ii  libpython3.8  3.8.3-1
ii  libsdl1.2debian   1.2.15+dfsg2-5
ii  libsndfile1   1.0.28-8
ii  libspnav0 0.2.3-1+b2
ii  libstdc++610.1.0-3
ii  libswscale5   7:4.2.2-1+b1
ii  libtbb2   2020.2-2
ii  libtiff5  4.1.0+git191117-2
ii  libx11-6  2:1.6.9-2+b1
ii  libxfixes31:5.0.3-2
ii  libxi62:1.7.9-1
ii  libxml2   2.9.10+dfsg-5
ii  libxrender1   1:0.9.10-1
ii  libxxf86vm1   1:1.1.4-1+b2
ii  zlib1g1:1.2.11.dfsg-2

blender recommends no packages.

blender suggests no packages.

-- no debconf information
-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?