Bug#966214: vienna-rna: FTBFS with GCC 10: multiple definition of ... due to -fno-common

2020-08-18 Thread Luis Paulo Linares
Control: tags -1 + patch

Hi,

the attached patch fixes the FTBFS with GCC-10.

Regards,
-- 
Luis Paulo (lpfll)
diff -Nru vienna-rna-2.4.14+dfsg/debian/patches/fix-ftbfs-with-gcc-10.patch vienna-rna-2.4.14+dfsg/debian/patches/fix-ftbfs-with-gcc-10.patch
--- vienna-rna-2.4.14+dfsg/debian/patches/fix-ftbfs-with-gcc-10.patch	1969-12-31 21:00:00.0 -0300
+++ vienna-rna-2.4.14+dfsg/debian/patches/fix-ftbfs-with-gcc-10.patch	2020-08-19 01:11:41.0 -0300
@@ -0,0 +1,35 @@
+Description: Fix FTBFS with GCC-10.
+Author: Luis Paulo Linares 
+Bug-Debian: https://bugs.debian.org/966214
+Index: vienna-rna-2.4.14+dfsg/src/Kinfold/globals.c
+===
+--- vienna-rna-2.4.14+dfsg.orig/src/Kinfold/globals.c
 vienna-rna-2.4.14+dfsg/src/Kinfold/globals.c
+@@ -25,6 +25,10 @@
+ #include "globals.h"
+ #include "cmdline.h"
+ 
++GlobVars GSV;
++GlobArrays GAV;
++GlobToggles GTV;
++
+ /* forward declarations privat functions */
+ static void ini_globs(void);
+ static void ini_gtoggles (void);
+Index: vienna-rna-2.4.14+dfsg/src/Kinfold/globals.h
+===
+--- vienna-rna-2.4.14+dfsg.orig/src/Kinfold/globals.h
 vienna-rna-2.4.14+dfsg/src/Kinfold/globals.h
+@@ -88,9 +88,9 @@ void clean_up_globals(void);
+ void log_prog_params(FILE *FP);
+ void log_start_stop(FILE *FP);
+ 
+-GlobVars GSV;
+-GlobArrays GAV;
+-GlobToggles GTV;
++extern GlobVars GSV;
++extern GlobArrays GAV;
++extern GlobToggles GTV;
+ 
+ #endif
+ 
diff -Nru vienna-rna-2.4.14+dfsg/debian/patches/series vienna-rna-2.4.14+dfsg/debian/patches/series
--- vienna-rna-2.4.14+dfsg/debian/patches/series	2019-09-09 08:19:08.0 -0300
+++ vienna-rna-2.4.14+dfsg/debian/patches/series	2020-08-19 01:11:41.0 -0300
@@ -1,3 +1,4 @@
 g2.patch
 tutorial.patch
 addHelp2ManWrapper.patch
+fix-ftbfs-with-gcc-10.patch


Bug#966214: vienna-rna: FTBFS with GCC 10: multiple definition of ... due to -fno-common

2020-08-18 Thread Luis Paulo Linares
Control: tags -1 + patch

Hi,

the attached patch fixes the FTBFS with GCC-10.

Regards,
-- 
Luis Paulo (lpfll)



Bug#966214: vienna-rna: FTBFS with GCC 10: multiple definition of ... due to -fno-common

2020-07-24 Thread Andreas Beckmann
Source: vienna-rna
Version: 2.4.14+dfsg-1
Severity: serious
Tags: ftbfs
Justification: fails to build from source
User: debian-...@lists.debian.org
Usertags: ftbfs-gcc-10

Hi,

vienna-rna started to FTBFS when GCC 10 was made the default compiler:

gcc -I./../../src/ViennaRNA -I./../../src -I/usr/include/json-c/ 
-I/usr/include/libsvm/  -Wl,-z,relro -o Kinfold baum.o cache.o globals.o main.o 
nachbar.o cmdline.o -fno-strict-aliasing -flto -L./../../src/ViennaRNA -lRNA 
-fopenmp -lgsl -lgslcblas -lmpfr -lgmp -lm 
/usr/bin/ld: globals.o:(.bss+0x0): multiple definition of `GSV'; 
baum.o:(.bss+0x0): first defined here
/usr/bin/ld: globals.o:(.bss+0x60): multiple definition of `GAV'; 
baum.o:(.bss+0x60): first defined here
/usr/bin/ld: globals.o:(.bss+0x8c0): multiple definition of `GTV'; 
baum.o:(.bss+0x8c0): first defined here
/usr/bin/ld: main.o:(.bss+0x0): multiple definition of `GSV'; 
baum.o:(.bss+0x0): first defined here
/usr/bin/ld: main.o:(.bss+0x60): multiple definition of `GAV'; 
baum.o:(.bss+0x60): first defined here
/usr/bin/ld: main.o:(.bss+0x8c0): multiple definition of `GTV'; 
baum.o:(.bss+0x8c0): first defined here
/usr/bin/ld: nachbar.o:(.bss+0x0): multiple definition of `GSV'; 
baum.o:(.bss+0x0): first defined here
/usr/bin/ld: nachbar.o:(.bss+0x60): multiple definition of `GAV'; 
baum.o:(.bss+0x60): first defined here
/usr/bin/ld: nachbar.o:(.bss+0x8c0): multiple definition of `GTV'; 
baum.o:(.bss+0x8c0): first defined here
collect2: error: ld returned 1 exit status
make[6]: *** [Makefile:485: Kinfold] Error 1

More information about the corresponding GCC change can be found here:
https://gcc.gnu.org/gcc-10/porting_to.html
"Default to -fno-common"


Andreas