Bug#968344: pencil2d: please make the build reproducible
On Thu, Aug 13, 2020 at 12:02:43PM +0100, Chris Lamb wrote: > Whilst working on the Reproducible Builds effort [0] we noticed that > pencil2d could not be built reproducibly. > > While you do use SOURCE_DATE_EPOCH to populate GIT_TIMESTAMP, you omit > the --utc flag to date(1) so the generated date will depend on the > build system's current timezone. Ahah, of course! I wonder how this haven't come up earlier on but only in the last upload, but well, thank you for saving me from invastigating this myself :) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#968344: pencil2d: please make the build reproducible
Hi Vagrant, > I think that should be: > > +timestamp=$(shell date +%Y-%m-%d -u -d "@$(SOURCE_DATE_EPOCH)") > > Since @SOURCE_DATE_EPOCH is be passed to the "-d" argument. ACK - thank you for the correction. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org chris-lamb.co.uk `-
Bug#968344: pencil2d: please make the build reproducible
On 2020-08-13, Chris Lamb wrote: > Whilst working on the Reproducible Builds effort [0] we noticed that > pencil2d could not be built reproducibly. > > While you do use SOURCE_DATE_EPOCH to populate GIT_TIMESTAMP, you omit > the --utc flag to date(1) so the generated date will depend on the > build system's current timezone. ... > --- a/debian/rules2020-08-13 11:34:56.164335215 +0100 > --- b/debian/rules2020-08-13 11:59:46.372680920 +0100 > @@ -6,7 +6,7 @@ > > # export information for the "About" screen > include /usr/share/dpkg/pkg-info.mk > -timestamp=$(shell date +%Y-%m-%d -d "@$(SOURCE_DATE_EPOCH)") > +timestamp=$(shell date +%Y-%m-%d -d -u "@$(SOURCE_DATE_EPOCH)") I think that should be: +timestamp=$(shell date +%Y-%m-%d -u -d "@$(SOURCE_DATE_EPOCH)") Since @SOURCE_DATE_EPOCH is be passed to the "-d" argument. live well, vagrant signature.asc Description: PGP signature
Bug#968344: pencil2d: please make the build reproducible
Source: pencil2d Version: 0.6.4-2 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: timestamps X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0] we noticed that pencil2d could not be built reproducibly. While you do use SOURCE_DATE_EPOCH to populate GIT_TIMESTAMP, you omit the --utc flag to date(1) so the generated date will depend on the build system's current timezone. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk ` a/debian/rules 2020-08-13 11:34:56.164335215 +0100 --- b/debian/rules 2020-08-13 11:59:46.372680920 +0100 @@ -6,7 +6,7 @@ # export information for the "About" screen include /usr/share/dpkg/pkg-info.mk -timestamp=$(shell date +%Y-%m-%d -d "@$(SOURCE_DATE_EPOCH)") +timestamp=$(shell date +%Y-%m-%d -d -u "@$(SOURCE_DATE_EPOCH)") export DEB_CXXFLAGS_MAINT_APPEND += -DGIT_TIMESTAMP=\\\"$(timestamp)\\\" %:
