Bug#969083: unblock: libomxil-bellagio/0.9.3-6
Hi Paul On 27-08-2020 13:22, Ying-Chun Liu (PaulLiu) wrote: > libomxil-bellagio0 can be a "plugin" of gst-omx. That means gst-omx can > be run by itself without libomxil-bellagio0 at all. > The problem happens in autopkgtest. In test, we use libomxil-bellagio0 > as a plugin to test gst-omx. So, the *test* needs a *versioned* dependency? And one can still argue that the new libomxil-bellagio breaks the version of gst-omx in testing? > Thus gst-omx originally loads that plugin (in debian/tests scripts) from > /usr/lib. But now it needs to load > > that plugin through test scripts from multi-arch path. Paul
Bug#969083: unblock: libomxil-bellagio/0.9.3-6
Hi Sebastian, gst-omx and libomxil-bellagio0 doesn't have strong dependencies. libomxil-bellagio0 can be a "plugin" of gst-omx. That means gst-omx can be run by itself without libomxil-bellagio0 at all. The problem happens in autopkgtest. In test, we use libomxil-bellagio0 as a plugin to test gst-omx. Thus gst-omx originally loads that plugin (in debian/tests scripts) from /usr/lib. But now it needs to load that plugin through test scripts from multi-arch path. Yours, Paul Sebastian Ramacher 於 2020/8/27 下午7:14 寫道: > Control: tags -1 + moreinfo > > On 2020-08-27 18:00:15, Ying-Chun Liu (PaulLiu) wrote: >> Package: release.debian.org >> Severity: normal >> User: release.debian@packages.debian.org >> Usertags: unblock >> >> >> Please unblock package libomxil-bellagio >> >> [ Reason ] >> >> libomxil-bellagio changes the library path to multi-arch. >> >> gst-omx will use the library for autopkgtest. So newer gst-omx loads the >> library >> >> from multi-arch path. And thus failed to pass the test for older >> libomxil-bellagio. > This sounds a lot like missing Breaks and versioned dependencies: > libomxil-bellagio0 needs Breaks on the gst-omx packages that ship the > config with the hard-coded path. > > At the same time, gst-omx does not seem to work with libomxil-bellagio > currently in testing. So this will also need versioned dependencies on a > sufficently high version of libomxil-bellagio0. And if those packages > require the shared library, why aren't the depending on it in the first > place? > > But overall, the missing Breaks and Depends seem like a real issue that > would also break the packages in partial buster -> bullseye upgrade > scenarios. > > Best > >> >> We should unblock libomxil-bellagio, and thus newer gst-omx should also >> pass all the debci tests later and automatically migrate. >> >> >> [ Impact ] >> libomxil-bellagio remains using old non-multiarch library path. >> >> [ Tests ] >> gst-omx/1.16.2-1 tests ok with libomxil-bellagio/0.9.3-6. >> It just failed with older libomxil-bellagio. >> >> [ Risks ] >> Should have no risks. autopkgtest already passed on the latest version >> of each package. >> >> [ Checklist ] >> [X] all changes are documented in the d/changelog >> [X] I reviewed all changes and I approve them >> [X] attach debdiff against the package in testing >> >> unblock libomxil-bellagio/0.9.3-6 >> >> diff -Nru libomxil-bellagio-0.9.3/debian/changelog >> libomxil-bellagio-0.9.3/debian/changelog >> --- libomxil-bellagio-0.9.3/debian/changelog 2018-09-23 03:56:46.0 >> +0800 >> +++ libomxil-bellagio-0.9.3/debian/changelog 2020-08-12 15:16:26.0 >> +0800 >> @@ -1,3 +1,25 @@ >> +libomxil-bellagio (0.9.3-6) unstable; urgency=low >> + >> + * Use linktrees instead of links. >> + >> + -- Ying-Chun Liu (PaulLiu) Wed, 12 Aug 2020 15:16:26 >> +0800 >> + >> +libomxil-bellagio (0.9.3-5) unstable; urgency=low >> + >> + * Multi-arch support >> + - Move libs to multiarch path (Closes: #928847) >> + - Add Multi-Arch foreign to -doc package. (Closes: #949568) >> + * Bump Standards-Version to 4.5.0: Nothing needs to be changed. >> + * Bump debhelper compat to 11 >> +- Remove Build-Depends on autotools-dev and dh-autoreconf >> +- Add debian/patches/0014_fix_hardening.patch: fix hardening error >> + * Remove Vcs-Git and Vcs-Browser field >> + * Remove *-dbg packages. Now we have -dbgsym packages. (Closes: #620832) >> + * Add debian/patches/0015_port_gcc_10.patch: port to gcc 10. >> +- (Closes: #957453) >> + >> + -- Ying-Chun Liu (PaulLiu) Sun, 09 Aug 2020 15:48:03 >> +0800 >> + >> libomxil-bellagio (0.9.3-4.1) unstable; urgency=medium >> >>* Non-maintainer upload. >> diff -Nru libomxil-bellagio-0.9.3/debian/clean >> libomxil-bellagio-0.9.3/debian/clean >> --- libomxil-bellagio-0.9.3/debian/clean 1970-01-01 08:00:00.0 >> +0800 >> +++ libomxil-bellagio-0.9.3/debian/clean 2020-08-09 15:48:03.0 >> +0800 >> @@ -0,0 +1 @@ >> +debian/libomxil-bellagio-bin.triggers >> diff -Nru libomxil-bellagio-0.9.3/debian/compat >> libomxil-bellagio-0.9.3/debian/compat >> --- libomxil-bellagio-0.9.3/debian/compat2016-11-13 02:59:37.0 >> +0800 >> +++ libomxil-bellagio-0.9.3/debian/compat2020-08-09 15:48:03.0 >> +0800 >> @@ -1 +1 @@ >> -8 >> +11 >> diff -Nru libomxil-bellagio-0.9.3/debian/control >> libomxil-bellagio-0.9.3/debian/control >> --- libomxil-bellagio-0.9.3/debian/control 2016-11-13 04:44:17.0 >> +0800 >> +++ libomxil-bellagio-0.9.3/debian/control 2020-08-12 15:16:26.0 >> +0800 >> @@ -2,12 +2,16 @@ >> Section: libs >> Priority: optional >> Maintainer: Ying-Chun Liu (PaulLiu) >> -Build-Depends: debhelper (>= 8), dh-autoreconf, >> - autotools-dev, libasound2-dev, libmad0-dev, libvorbis-dev, >> - doxygen, libjs-jquery >> -Standards-Version: 3.9.8 >> -Vcs-Browser: http://git.debian.org/?p=collab-maint/libomxil-bellagio.git >> -Vcs-Git:
Bug#969083: unblock: libomxil-bellagio/0.9.3-6
Control: tags -1 + moreinfo
On 2020-08-27 18:00:15, Ying-Chun Liu (PaulLiu) wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
>
>
> Please unblock package libomxil-bellagio
>
> [ Reason ]
>
> libomxil-bellagio changes the library path to multi-arch.
>
> gst-omx will use the library for autopkgtest. So newer gst-omx loads the
> library
>
> from multi-arch path. And thus failed to pass the test for older
> libomxil-bellagio.
This sounds a lot like missing Breaks and versioned dependencies:
libomxil-bellagio0 needs Breaks on the gst-omx packages that ship the
config with the hard-coded path.
At the same time, gst-omx does not seem to work with libomxil-bellagio
currently in testing. So this will also need versioned dependencies on a
sufficently high version of libomxil-bellagio0. And if those packages
require the shared library, why aren't the depending on it in the first
place?
But overall, the missing Breaks and Depends seem like a real issue that
would also break the packages in partial buster -> bullseye upgrade
scenarios.
Best
>
>
> We should unblock libomxil-bellagio, and thus newer gst-omx should also
> pass all the debci tests later and automatically migrate.
>
>
> [ Impact ]
> libomxil-bellagio remains using old non-multiarch library path.
>
> [ Tests ]
> gst-omx/1.16.2-1 tests ok with libomxil-bellagio/0.9.3-6.
> It just failed with older libomxil-bellagio.
>
> [ Risks ]
> Should have no risks. autopkgtest already passed on the latest version
> of each package.
>
> [ Checklist ]
> [X] all changes are documented in the d/changelog
> [X] I reviewed all changes and I approve them
> [X] attach debdiff against the package in testing
>
> unblock libomxil-bellagio/0.9.3-6
>
> diff -Nru libomxil-bellagio-0.9.3/debian/changelog
> libomxil-bellagio-0.9.3/debian/changelog
> --- libomxil-bellagio-0.9.3/debian/changelog 2018-09-23 03:56:46.0
> +0800
> +++ libomxil-bellagio-0.9.3/debian/changelog 2020-08-12 15:16:26.0
> +0800
> @@ -1,3 +1,25 @@
> +libomxil-bellagio (0.9.3-6) unstable; urgency=low
> +
> + * Use linktrees instead of links.
> +
> + -- Ying-Chun Liu (PaulLiu) Wed, 12 Aug 2020 15:16:26
> +0800
> +
> +libomxil-bellagio (0.9.3-5) unstable; urgency=low
> +
> + * Multi-arch support
> + - Move libs to multiarch path (Closes: #928847)
> + - Add Multi-Arch foreign to -doc package. (Closes: #949568)
> + * Bump Standards-Version to 4.5.0: Nothing needs to be changed.
> + * Bump debhelper compat to 11
> +- Remove Build-Depends on autotools-dev and dh-autoreconf
> +- Add debian/patches/0014_fix_hardening.patch: fix hardening error
> + * Remove Vcs-Git and Vcs-Browser field
> + * Remove *-dbg packages. Now we have -dbgsym packages. (Closes: #620832)
> + * Add debian/patches/0015_port_gcc_10.patch: port to gcc 10.
> +- (Closes: #957453)
> +
> + -- Ying-Chun Liu (PaulLiu) Sun, 09 Aug 2020 15:48:03
> +0800
> +
> libomxil-bellagio (0.9.3-4.1) unstable; urgency=medium
>
>* Non-maintainer upload.
> diff -Nru libomxil-bellagio-0.9.3/debian/clean
> libomxil-bellagio-0.9.3/debian/clean
> --- libomxil-bellagio-0.9.3/debian/clean 1970-01-01 08:00:00.0
> +0800
> +++ libomxil-bellagio-0.9.3/debian/clean 2020-08-09 15:48:03.0
> +0800
> @@ -0,0 +1 @@
> +debian/libomxil-bellagio-bin.triggers
> diff -Nru libomxil-bellagio-0.9.3/debian/compat
> libomxil-bellagio-0.9.3/debian/compat
> --- libomxil-bellagio-0.9.3/debian/compat 2016-11-13 02:59:37.0
> +0800
> +++ libomxil-bellagio-0.9.3/debian/compat 2020-08-09 15:48:03.0
> +0800
> @@ -1 +1 @@
> -8
> +11
> diff -Nru libomxil-bellagio-0.9.3/debian/control
> libomxil-bellagio-0.9.3/debian/control
> --- libomxil-bellagio-0.9.3/debian/control2016-11-13 04:44:17.0
> +0800
> +++ libomxil-bellagio-0.9.3/debian/control2020-08-12 15:16:26.0
> +0800
> @@ -2,12 +2,16 @@
> Section: libs
> Priority: optional
> Maintainer: Ying-Chun Liu (PaulLiu)
> -Build-Depends: debhelper (>= 8), dh-autoreconf,
> - autotools-dev, libasound2-dev, libmad0-dev, libvorbis-dev,
> - doxygen, libjs-jquery
> -Standards-Version: 3.9.8
> -Vcs-Browser: http://git.debian.org/?p=collab-maint/libomxil-bellagio.git
> -Vcs-Git: git://git.debian.org/git/collab-maint/libomxil-bellagio.git
> +Build-Depends: debhelper (>= 11),
> + dh-exec,
> + dh-linktree,
> + doxygen,
> + libasound2-dev,
> + libjs-jquery,
> + libmad0-dev,
> + libvorbis-dev,
> + node-jquery
> +Standards-Version: 4.5.0
> Homepage: http://sourceforge.net/projects/omxil/
>
> Package: libomxil-bellagio0
> @@ -15,7 +19,7 @@
> Suggests: libomxil-bellagio0-components-base
> Architecture: any
> Section: libs
> -Depends: ${shlibs:Depends}, ${misc:Depends}
> +Depends: ${misc:Depends}, ${shlibs:Depends}
>
Bug#969083: unblock: libomxil-bellagio/0.9.3-6
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package libomxil-bellagio
[ Reason ]
libomxil-bellagio changes the library path to multi-arch.
gst-omx will use the library for autopkgtest. So newer gst-omx loads the
library
from multi-arch path. And thus failed to pass the test for older
libomxil-bellagio.
We should unblock libomxil-bellagio, and thus newer gst-omx should also
pass all the debci tests later and automatically migrate.
[ Impact ]
libomxil-bellagio remains using old non-multiarch library path.
[ Tests ]
gst-omx/1.16.2-1 tests ok with libomxil-bellagio/0.9.3-6.
It just failed with older libomxil-bellagio.
[ Risks ]
Should have no risks. autopkgtest already passed on the latest version
of each package.
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
unblock libomxil-bellagio/0.9.3-6
diff -Nru libomxil-bellagio-0.9.3/debian/changelog libomxil-bellagio-0.9.3/debian/changelog
--- libomxil-bellagio-0.9.3/debian/changelog 2018-09-23 03:56:46.0 +0800
+++ libomxil-bellagio-0.9.3/debian/changelog 2020-08-12 15:16:26.0 +0800
@@ -1,3 +1,25 @@
+libomxil-bellagio (0.9.3-6) unstable; urgency=low
+
+ * Use linktrees instead of links.
+
+ -- Ying-Chun Liu (PaulLiu) Wed, 12 Aug 2020 15:16:26 +0800
+
+libomxil-bellagio (0.9.3-5) unstable; urgency=low
+
+ * Multi-arch support
+ - Move libs to multiarch path (Closes: #928847)
+ - Add Multi-Arch foreign to -doc package. (Closes: #949568)
+ * Bump Standards-Version to 4.5.0: Nothing needs to be changed.
+ * Bump debhelper compat to 11
+- Remove Build-Depends on autotools-dev and dh-autoreconf
+- Add debian/patches/0014_fix_hardening.patch: fix hardening error
+ * Remove Vcs-Git and Vcs-Browser field
+ * Remove *-dbg packages. Now we have -dbgsym packages. (Closes: #620832)
+ * Add debian/patches/0015_port_gcc_10.patch: port to gcc 10.
+- (Closes: #957453)
+
+ -- Ying-Chun Liu (PaulLiu) Sun, 09 Aug 2020 15:48:03 +0800
+
libomxil-bellagio (0.9.3-4.1) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru libomxil-bellagio-0.9.3/debian/clean libomxil-bellagio-0.9.3/debian/clean
--- libomxil-bellagio-0.9.3/debian/clean 1970-01-01 08:00:00.0 +0800
+++ libomxil-bellagio-0.9.3/debian/clean 2020-08-09 15:48:03.0 +0800
@@ -0,0 +1 @@
+debian/libomxil-bellagio-bin.triggers
diff -Nru libomxil-bellagio-0.9.3/debian/compat libomxil-bellagio-0.9.3/debian/compat
--- libomxil-bellagio-0.9.3/debian/compat 2016-11-13 02:59:37.0 +0800
+++ libomxil-bellagio-0.9.3/debian/compat 2020-08-09 15:48:03.0 +0800
@@ -1 +1 @@
-8
+11
diff -Nru libomxil-bellagio-0.9.3/debian/control libomxil-bellagio-0.9.3/debian/control
--- libomxil-bellagio-0.9.3/debian/control 2016-11-13 04:44:17.0 +0800
+++ libomxil-bellagio-0.9.3/debian/control 2020-08-12 15:16:26.0 +0800
@@ -2,12 +2,16 @@
Section: libs
Priority: optional
Maintainer: Ying-Chun Liu (PaulLiu)
-Build-Depends: debhelper (>= 8), dh-autoreconf,
- autotools-dev, libasound2-dev, libmad0-dev, libvorbis-dev,
- doxygen, libjs-jquery
-Standards-Version: 3.9.8
-Vcs-Browser: http://git.debian.org/?p=collab-maint/libomxil-bellagio.git
-Vcs-Git: git://git.debian.org/git/collab-maint/libomxil-bellagio.git
+Build-Depends: debhelper (>= 11),
+ dh-exec,
+ dh-linktree,
+ doxygen,
+ libasound2-dev,
+ libjs-jquery,
+ libmad0-dev,
+ libvorbis-dev,
+ node-jquery
+Standards-Version: 4.5.0
Homepage: http://sourceforge.net/projects/omxil/
Package: libomxil-bellagio0
@@ -15,7 +19,7 @@
Suggests: libomxil-bellagio0-components-base
Architecture: any
Section: libs
-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}
Description: implementation of OpenMAX IL, run-time library
OpenMAX Integration Layer (IL) is a standard API to access Multimedia
Components on mobile platforms. It has been defined by the Khronos
@@ -34,7 +38,7 @@
Package: libomxil-bellagio-bin
Architecture: any
Section: utils
-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}
Replaces: libomxil-bellagio0 (<< 0.9.3-4)
Breaks: libomxil-bellagio0 (<< 0.9.3-4)
Description: implementation of OpenMAX IL, run-time library (utilities)
@@ -57,7 +61,7 @@
Package: libomxil-bellagio0-components-base
Architecture: any
Section: libs
-Depends: ${shlibs:Depends}, ${misc:Depends}, libomxil-bellagio-bin
+Depends: libomxil-bellagio-bin, ${misc:Depends}, ${shlibs:Depends}
Description: components for Bellagio OpenMAX IL
OpenMAX Integration Layer (IL) is a standard API to access Multimedia
Components on mobile platforms. It has been defined by the Khronos
@@ -70,13 +74,13 @@
It is intended to show the usage
