Bug#969410: maxima-emacs: maxima-emacs 5.44 does not work with XEmacs

2021-04-20 Thread Andreas Beckmann 
Followup-For: Bug #969410
Control: severity -1 serious

Hi,

during a test with piuparts I noticed your package failed to install if
xemacs21 is already installed.

>From the attached log (scroll to the bottom...):

  Setting up maxima-emacs (5.44.0-2) ...
  Install emacsen-common for xemacs21
  emacsen-common: Handling install of emacsen flavor xemacs21
  Loading /usr/share/emacsen-common/debian-startup...
  Loading 00debian...
  Compiling /usr/share/xemacs21/site-lisp/debian-startup.el...
  Wrote /usr/share/xemacs21/site-lisp/debian-startup.elc
  Done
  Install maxima-emacs for xemacs21
  install/maxima: Handling install for emacsen flavor xemacs21
  Compiling /usr/share/xemacs21/site-lisp/maxima/bookmode.el...
  Wrote /usr/share/xemacs21/site-lisp/maxima/bookmode.elc
  Compiling /usr/share/xemacs21/site-lisp/maxima/emaxima.el...
  Wrote /usr/share/xemacs21/site-lisp/maxima/emaxima.elc
  Compiling /usr/share/xemacs21/site-lisp/maxima/imath.el...
  While compiling toplevel forms in file 
/usr/share/xemacs21/site-lisp/maxima/imath.el:
!! File error (("Cannot open load file" "cl-lib"))
  >>Error occurred processing imath.el: Cannot open load file: cl-lib
  
  Compiling 
/usr/share/xemacs21/site-lisp/maxima/imaxima-autoconf-variables.el...
  Wrote /usr/share/xemacs21/site-lisp/maxima/imaxima-autoconf-variables.elc
  Compiling /usr/share/xemacs21/site-lisp/maxima/imaxima.el...
  While compiling toplevel forms in file 
/usr/share/xemacs21/site-lisp/maxima/imaxima.el:
!! File error (("Cannot open load file" "cl-lib"))
  >>Error occurred processing imaxima.el: Cannot open load file: cl-lib
  
  Compiling /usr/share/xemacs21/site-lisp/maxima/maxima-font-lock.el...
  Wrote /usr/share/xemacs21/site-lisp/maxima/maxima-font-lock.elc
  Compiling /usr/share/xemacs21/site-lisp/maxima/maxima.el...
  Wrote /usr/share/xemacs21/site-lisp/maxima/maxima.elc
  Compiling /usr/share/xemacs21/site-lisp/maxima/setup-imaxima-imath.el...
  Wrote /usr/share/xemacs21/site-lisp/maxima/setup-imaxima-imath.elc
  Compiling /usr/share/xemacs21/site-lisp/maxima/smart-complete.el...
  Wrote /usr/share/xemacs21/site-lisp/maxima/smart-complete.elc
  Compiling /usr/share/xemacs21/site-lisp/maxima/sshell.el...
  Wrote /usr/share/xemacs21/site-lisp/maxima/sshell.elc
  Done
  ERROR: install script from maxima-emacs package failed
  dpkg: error processing package maxima-emacs (--configure):
   installed maxima-emacs package post-installation script subprocess returned 
error exit status 1
  Processing triggers for libc-bin (2.31-11) ...
  Processing triggers for tex-common (6.16) ...
  Running updmap-sys. This may take some time... done.
  Running mktexlsr /var/lib/texmf ... done.
  Building format(s) --all.
This may take some time... done.
  Errors were encountered while processing:
   maxima-emacs


cheers,

Andreas


maxima-emacs=5.44.0-2_xemacs21.log.gz
Description: application/gzip

Bug#969410: maxima-emacs: maxima-emacs 5.44 does not work with XEmacs

2020-09-02 Thread Agustin Martin 
Package: maxima-emacs
Version: 5.44.0-2
Severity: normal

Dear Maintainer,

When upgrading from 5.43 to 5.44 maxima-emacs started using 'cl-lib'
instead  of plain 'cl'. There are good reasons for that, 'cl' defines
functions in global namespace while 'cl-lib' has them prefixed by cl-

The problem is that this change breaks maxima-emacs with XEmacs, which
does not provide 'cl-lib'

Compiling /usr/share/xemacs21/site-lisp/maxima/imaxima.el...
While compiling toplevel forms in file
/usr/share/xemacs21/site-lisp/maxima/imaxima.el:
  !! File error (("Cannot open load file" "cl-lib"))
>>Error occurred processing imaxima.el: Cannot open load file: cl-lib

So, either maxima-emacs drops XEmacs support or is patched to regain
old behavior, like in attached patch. I cannot assure that this has no
side effects.

More info:
https://www.emacswiki.org/emacs/CommonLispForEmacs
https://emacs.stackexchange.com/questions/48109/require-cl-or-require-cl-lib

Regards,

--
Agustin
--- imaxima.el.orig	2020-09-02 10:45:30.042838277 +0200
+++ imaxima.el	2020-09-02 10:46:13.260707024 +0200
@@ -80,7 +80,7 @@
 (require 'advice)
 
 (require 'comint)
-(require 'cl-lib)
+(require 'cl)
 
 ;; XEmacs stuff
 
@@ -174,7 +174,7 @@
   :group 'imaxima
   :type (cons 'choice
 	  (mapcar (lambda (type) (list 'const type))
-		  (cl-remove-if-not 'imaxima-image-type-available-p
+		  (remove-if-not 'imaxima-image-type-available-p
  imaxima-image-types
 
 (defcustom imaxima-pt-size 11