Source: cif2cell Version: 2.0.0a1+dfsg-2 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: randomness X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi, Whilst working on the Reproducible Builds effort [0] we noticed that cif2cell could not be built reproducibly. This is because it iterated over a set in non-deterministic order to generate its documentation. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000 +0100 --- b/debian/patches/reproducible-build.patch 2020-09-10 11:36:20.876397860 +0100 @@ -0,0 +1,15 @@ +Description: Make the build reproducible +Author: Chris Lamb <la...@debian.org> +Last-Update: 2020-09-10 + +--- cif2cell-2.0.0a1+dfsg.orig/binaries/cif2cell ++++ cif2cell-2.0.0a1+dfsg/binaries/cif2cell +@@ -61,7 +61,7 @@ vcaprograms = set(["castep","vasp"]) + # + setupallprogs = set(["vasp","pwscf","quantum-espresso","rspt","mopac"]) + setupallstring = "" +-for p in setupallprogs: ++for p in sorted(setupallprogs): + setupallstring += p+", " + setupallstring = setupallstring.rstrip(", ") + # --- a/debian/patches/series 2020-09-10 11:11:34.294233658 +0100 --- b/debian/patches/series 2020-09-10 11:36:20.028393989 +0100 @@ -1,2 +1,3 @@ shebang.patch tests.patch +reproducible-build.patch