Bug#975650: blhc: reports false positives for missing flags

2021-10-09 Thread Simon Ruderich
On Tue, Oct 05, 2021 at 09:32:21PM +0200, Fabian Wolff wrote: > On 10/5/21 1:48 PM, Simon Ruderich wrote: >> Could you test the attached patch and tell me if this works for >> you for real builds? > > Thankfully, I still had the full log file lying around in which I > originally discovered this

Bug#975650: blhc: reports false positives for missing flags

2021-10-05 Thread Fabian Wolff
On 10/5/21 1:48 PM, Simon Ruderich wrote: > Could you test the attached patch and tell me if this works for > you for real builds? Thankfully, I still had the full log file lying around in which I originally discovered this issue, and I am indeed no longer getting any false positives with your

Bug#975650: blhc: reports false positives for missing flags

2021-10-05 Thread Simon Ruderich
On Sun, Nov 29, 2020 at 07:21:48PM +0100, Fabian Wolff wrote: > On 11/28/20 10:47 PM, Eriberto wrote: >> Thanks Fabian and Simon! >> >> Considering that some false positives can't be fixed in blhc source >> code, could I close this bug? > > I think it would make more sense to close this bug with

Bug#975650: blhc: reports false positives for missing flags

2021-10-05 Thread Simon Ruderich
On Sun, Feb 21, 2021 at 03:24:26PM -0500, Olek Wojnar wrote: > I have run into this exact issue with bazel-bootstrap builds. [1] I love > what blhc does so I'd rather not disable it due to these false positives, > but I also like for the Salsa CI to let me know when a recent commit has > caused a

Bug#975650: blhc: reports false positives for missing flags

2021-02-21 Thread Olek Wojnar
Hello Simon and other interested parties, On Sat, 28 Nov 2020 12:28:16 +0100 Simon Ruderich wrote: > > is the problem because blhc requires a space after each flag. I > know this handling is not perfect but parsing arbitrary shell > commands is difficult. I have run into this exact issue with

Bug#975650: blhc: reports false positives for missing flags

2020-11-29 Thread Fabian Wolff
On 11/28/20 10:47 PM, Eriberto wrote: > Thanks Fabian and Simon! > > Considering that some false positives can't be fixed in blhc source > code, could I close this bug? I think it would make more sense to close this bug with the next upstream release, given that some changes in blhc have been

Bug#975650: blhc: reports false positives for missing flags

2020-11-28 Thread Eriberto
Thanks Fabian and Simon! Considering that some false positives can't be fixed in blhc source code, could I close this bug? Cheers, Eriberto

Bug#975650: blhc: reports false positives for missing flags

2020-11-28 Thread Fabian Wolff
On 11/28/20 12:28 PM, Simon Ruderich wrote: > blhc uses a few heuristics to detect lines with (possible) > compiler commands to prevent false negatives. Lines containing > `gcc` and similar are flagged. In this case the CC= environment > variable triggers this. Then blhc looks for the actual build

Bug#975650: blhc: reports false positives for missing flags

2020-11-28 Thread Simon Ruderich
On Tue, Nov 24, 2020 at 05:16:03PM +0100, Fabian Wolff wrote: > Dear maintainer, > > consider the following warnings emitted by blhc (line breaks are mine; > see the attached "test.log" file for an input that reproduces this > problem): > > [snip] Hello Fabian, thanks for the sample log to

Bug#975650: blhc: reports false positives for missing flags

2020-11-24 Thread Fabian Wolff
Hi Eriberto, thanks for your quick reply! On 11/24/20 5:59 PM, Eriberto wrote: > Since 0.12 version, blhc is able to ignore false positives spotted by > line(s) "injected" inside .build file via debian/rules. See more > details in blhc(1) manpage. There are examples in >

Bug#975650: blhc: reports false positives for missing flags

2020-11-24 Thread Eriberto
Hi Fabian, Em ter., 24 de nov. de 2020 às 13:27, Fabian Wolff escreveu: > > Dear maintainer, > > consider the following warnings emitted by blhc (line breaks are mine; > see the attached "test.log" file for an input that reproduces this > problem): > > LDFLAGS missing (-Wl,-z,relro): make

Bug#975650: blhc: reports false positives for missing flags

2020-11-24 Thread Fabian Wolff
Package: blhc Version: 0.12-2 Severity: normal X-Debbugs-CC: si...@ruderich.org Dear maintainer, consider the following warnings emitted by blhc (line breaks are mine; see the attached "test.log" file for an input that reproduces this problem): LDFLAGS missing (-Wl,-z,relro): make