Bug#976801: Bug#982871: lintian-brush: Should not set "Testsuite: autopkgtest-pkg-perl" if debian/tests/control is present

2021-02-22 Thread Andrius Merkys
Hi Felix,

On 2021-02-16 12:29, Felix Lechner wrote:
> On Mon, Feb 15, 2021 at 10:45 PM Andrius Merkys  wrote:
>>
>> I filed that as a bug in lintian, #976801.
> 
> Your bug was resolved for both teams in Git on the day you filed. It
> was not marked pending, however, because I accidentally appended a
> digit to the bug number in the commit message. (I had just started to
> use a keyboard layout [1] that reverses the Shift function on digits
> for easier access to the symbols; the closing parenthesis became a
> zero.) Here is the corresponding commit:
> 
> 
> https://salsa.debian.org/lintian/lintian/-/commit/920143ae57ed8b7607ac3160ba8f7ef766b3407a

Thank you for letting me know!

> Please note that, in any event, the fix came too late for 'bullseye'.
> In consideration of public opinion, we are not presently updating
> Lintian in the archive. [2] Thank you!

Sure, no problem.

> [1] https://salsa.debian.org/lechner/rocket-layout
> [2] https://lists.debian.org/debian-devel/2021/01/msg00236.html

Best wishes,
Andrius



Bug#976801: Bug#982871: lintian-brush: Should not set "Testsuite: autopkgtest-pkg-perl" if debian/tests/control is present

2021-02-17 Thread Jelmer Vernooij
On Tue, Feb 16, 2021 at 08:41:05AM +0200, Andrius Merkys wrote:
> Hello,
> 
> On 2021-02-15 22:12, gregor herrmann wrote:
> > On Mon, 15 Feb 2021 20:29:51 +0100, Axel Beckert wrote:
> >> Jelmer Vernooij wrote:
>  So please stop adding "Testsuite:" headers if debian/tests/control is
>  already present.
> 
>  Luckily the testsuite declared in debian/tests/control was still run, so
>  it didn't completely break autopkgtest for this package, but at least
>  caused unnecessary tests being tried to run, but then skipped.
> >>> Thanks for the bug report.
> >>>
> >>> It looks like this is also a bug in lintian, since it reports
> >>> team/pkg-perl/testsuite/no-team-tests for equivs:
> >>>
> >>> https://lintian.debian.org/tags/team/pkg-perl/testsuite/no-team-tests.html
> >>
> >> Hmmm, I have recently worked on debsums (similar case of a native
> >> pkg-perl-team package which also has a debian/tests/control file) and
> >> I can't remember having seen that warning. Then again I had the
> >> feeling that the lintian tags on the web are often outdated.
> >>
> >> Just checked: Yeah, it's overridden there. (Overridden by myself in
> >> 2015. :-)
> > 
> > Heh :)
> > 
> > I think that's a know, hm, behaviour lintian. I thought there even
> > was a bug report about it but I can't find it right now.
> 
> I had similar (same?) experience with lintian's
> team/pkg-perl/testsuite/no-team-tests due to the package having both
> "Testsuite: autopkgtest-pkg-perl" and debian/tests/control. I filed that
> as bug in lintian, #976801.

This seems to be a slightly different issue. Should
autopkgtest-pkg-perl still be added to Testsuite if there are
other testsuites present, i.e. should this lintian issue still be
raised as the team/pkg-perl/testsuite/no-team-tests description
suggests if "autopkgtest-pkg-perl" is not present but some other
Testsuite setting is?

Cheers,

Jelmer


signature.asc
Description: PGP signature


Bug#976801: Bug#982871: lintian-brush: Should not set "Testsuite: autopkgtest-pkg-perl" if debian/tests/control is present

2021-02-16 Thread Felix Lechner
Control: tags -1 +pending

Hi Andrius

On Mon, Feb 15, 2021 at 10:45 PM Andrius Merkys  wrote:
>
> I filed that as a bug in lintian, #976801.

Your bug was resolved for both teams in Git on the day you filed. It
was not marked pending, however, because I accidentally appended a
digit to the bug number in the commit message. (I had just started to
use a keyboard layout [1] that reverses the Shift function on digits
for easier access to the symbols; the closing parenthesis became a
zero.) Here is the corresponding commit:


https://salsa.debian.org/lintian/lintian/-/commit/920143ae57ed8b7607ac3160ba8f7ef766b3407a

Please note that, in any event, the fix came too late for 'bullseye'.
In consideration of public opinion, we are not presently updating
Lintian in the archive. [2] Thank you!

Kind regards
Felix Lechner

[1] https://salsa.debian.org/lechner/rocket-layout
[2] https://lists.debian.org/debian-devel/2021/01/msg00236.html



Bug#976801: Bug#982871: lintian-brush: Should not set "Testsuite: autopkgtest-pkg-perl" if debian/tests/control is present

2021-02-15 Thread gregor herrmann
On Tue, 16 Feb 2021 08:41:05 +0200, Andrius Merkys wrote:

> > I think that's a know, hm, behaviour lintian. I thought there even
> > was a bug report about it but I can't find it right now.
> I had similar (same?) experience with lintian's
> team/pkg-perl/testsuite/no-team-tests due to the package having both
> "Testsuite: autopkgtest-pkg-perl" and debian/tests/control. I filed that
> as bug in lintian, #976801.

Ha, that was the bug I vaguely remembered yesterday but couldn't
find! Thanks.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   BOFH excuse #321:  Scheduled global CPU outage 



Bug#976801: Bug#982871: lintian-brush: Should not set "Testsuite: autopkgtest-pkg-perl" if debian/tests/control is present

2021-02-15 Thread Andrius Merkys
Hello,

On 2021-02-15 22:12, gregor herrmann wrote:
> On Mon, 15 Feb 2021 20:29:51 +0100, Axel Beckert wrote:
>> Jelmer Vernooij wrote:
 So please stop adding "Testsuite:" headers if debian/tests/control is
 already present.

 Luckily the testsuite declared in debian/tests/control was still run, so
 it didn't completely break autopkgtest for this package, but at least
 caused unnecessary tests being tried to run, but then skipped.
>>> Thanks for the bug report.
>>>
>>> It looks like this is also a bug in lintian, since it reports
>>> team/pkg-perl/testsuite/no-team-tests for equivs:
>>>
>>> https://lintian.debian.org/tags/team/pkg-perl/testsuite/no-team-tests.html
>>
>> Hmmm, I have recently worked on debsums (similar case of a native
>> pkg-perl-team package which also has a debian/tests/control file) and
>> I can't remember having seen that warning. Then again I had the
>> feeling that the lintian tags on the web are often outdated.
>>
>> Just checked: Yeah, it's overridden there. (Overridden by myself in
>> 2015. :-)
> 
> Heh :)
> 
> I think that's a know, hm, behaviour lintian. I thought there even
> was a bug report about it but I can't find it right now.

I had similar (same?) experience with lintian's
team/pkg-perl/testsuite/no-team-tests due to the package having both
"Testsuite: autopkgtest-pkg-perl" and debian/tests/control. I filed that
as bug in lintian, #976801.

Best,
Andrius