Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Felix Lechner]

Control: reopen -1
Control: reassign -1 liblist-moreutils-perl
Control: forcemerge 977594 -1

Hi,

On Tue, Dec 15, 2020 at 12:05 PM Felix Lechner
 wrote:
>
> Closing.

N. Tyni opened another bug against liblist-moreutils-perl about the
same issue. As a matter of housekeeping, we reopen this bug and merge
it with that one. Thanks!

Kind regards,
Felix Lechner

Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Robert Luberda]

Felix Lechner pisze:
Hi,
> 
> On Tue, Dec 15, 2020 at 11:44 AM Francesco Poli
>  wrote:
>>
>> But it seems to work without warnings or errors or false positives!

I can confirm, version from git works for me too, thanks!

> 
> Closing.

I'm not sure why. It is fixed in git, but the current version of lintian
in unstable does not work (i.e. when I downgrade lintian from 2.104+git
to 2.104, without changing any other package, I can still observe the
warnings; when I install 2.104+git the warnings are gone).


Regards,
robert

Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Francesco Poli]

On Tue, 15 Dec 2020 08:39:48 -0800 Felix Lechner wrote:

> Hi,
> 
> On Tue, Dec 15, 2020 at 8:03 AM Louis-Philippe Véronneau
>  wrote:
> >
> > liblist-moreutils-perl is also at 0.430-1 in my schroot.

As stated in the original bug report, I have

  ii  liblist-moreutils-perl  0.430-1

in the pbuilder managed sid chroot I am currently using.


[...]
> Could one of you please try Lintian's development version?
> 
> git clone https://salsa.debian.org/lintian/lintian.git
> cd lintian
> ./bin/lintian ...
> 
> Thanks!

I managed to test it.

Actually, it wasn't easy.
I had to do the following:

  # aptitude install lintian
  # aptitude install git
  # aptitude install libperlio-utf8-strict-perl \
 libio-interactive-perl \
 liblist-someutils-perl \
 libipc-run3-perl \
 libio-prompt-tiny-perl \
 libconst-fast-perl
  $ git clone https://salsa.debian.org/lintian/lintian.git
  $ cd lintian
  $ ./bin/lintian -viF ../apt-listbugs_0.1.35~rc4_amd64.changes
  N: Using profile debian/ftp-master-auto-reject.
  N: Starting on group apt-listbugs/0.1.35~rc4
  N: Finished processing group apt-listbugs/0.1.35~rc4
  $ ./bin/lintian -EviIL +pedantic ../apt-listbugs_0.1.35~rc4_amd64.changes
  N: Using profile debian/main.
  N: Starting on group apt-listbugs/0.1.35~rc4
  N: Finished processing group apt-listbugs/0.1.35~rc4
  P: apt-listbugs source: no-dep5-copyright debian/copyright
  N:
  P: no-dep5-copyright
  N:
  N:   This package does not use a machine-readable debian/copyright file.
  N:   
  N:   This format makes it easier to review licenses and can be easily
  N:   parsed by Lintian.
  N:   
  N:   Refer to
  N:   https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
  N:   details.
  N:   
  N:   Severity: pedantic
  N:   
  N:   Check: debian/copyright/dep5
  N:


But it seems to work without warnings or errors or false positives!


-- 
 http://www.inventati.org/frx/
 There's not a second to spare! To the laboratory!
. Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE


pgpsCeNlISIFN.pgp
Description: PGP signature

Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Felix Lechner]

Hi,

On Tue, Dec 15, 2020 at 8:03 AM Louis-Philippe Véronneau
 wrote:
>
> liblist-moreutils-perl is also at 0.430-1 in my schroot.

I believe the availability of Perl's special variables has changed
inside the 'any' loop here:


https://salsa.debian.org/lintian/lintian/-/blob/2.104.0/checks/fields/package-relations.pm#L129

It is legacy code that was already updated to lexical variables in our
development version. Here is the current code:


https://salsa.debian.org/lintian/lintian/-/blob/master/checks/fields/package-relations.pm#L159

and this is the commit that changed it:


https://salsa.debian.org/lintian/lintian/-/commit/6ba668bbeb19e6f3218738e2e949e4f7bb656ac5

Could one of you please try Lintian's development version?

git clone https://salsa.debian.org/lintian/lintian.git
cd lintian
./bin/lintian ...

Thanks!

Kind regards
Felix Lechner

Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Louis-Philippe Véronneau]

On 2020-12-15 01 h 10, Felix Lechner wrote:
> Hi,
> 
> On Mon, Dec 14, 2020 at 9:24 PM Louis-Philippe Véronneau
>  wrote:
>>
>> I can reproduce this behavior with supysonic 0.6.2+ds-2:
> 
> Alas, I *cannot* reproduce it with either of the two packages. I tried
> both 2.104.0 and our development version (on stable). Are you both on
> more cutting-edge releases? Specifically, what is your version of
> liblist-moreutils-perl, please? Thanks!

I am building in Debian unstable in a schroot using sbuild.

liblist-moreutils-perl is also at 0.430-1 in my schroot.

-- 
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   po...@debian.org / veronneau.org
  ⠈⠳⣄



OpenPGP_signature
Description: OpenPGP digital signature

Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Robert Luberda]

On Mon, 14 Dec 2020 22:10:44 -0800 Felix Lechner
 wrote:
> Hi,
> 
> 
> Alas, I *cannot* reproduce it with either of the two packages. I tried
> both 2.104.0 and our development version (on stable). 

I have the same issue for any of my packages, for example:
Warning in group dwww/1.13.5: Use of uninitialized value in string eq at
/usr/share/lintian/checks/fields/package-relations.pm line 129.

I think it is related to the recent perl upgrade. I use the latest
version of perl which is 5.32.0-6.

>Are you both on
> more cutting-edge releases? Specifically, what is your version of
> liblist-moreutils-perl, please? Thanks!

On my system it is 0.430-1

Regards,
robert

Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Felix Lechner]

Hi,

On Mon, Dec 14, 2020 at 9:24 PM Louis-Philippe Véronneau
 wrote:
>
> I can reproduce this behavior with supysonic 0.6.2+ds-2:

Alas, I *cannot* reproduce it with either of the two packages. I tried
both 2.104.0 and our development version (on stable). Are you both on
more cutting-edge releases? Specifically, what is your version of
liblist-moreutils-perl, please? Thanks!

Kind regards
Felix Lechner

Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Louis-Philippe Véronneau]

I can reproduce this behavior with supysonic 0.6.2+ds-2:

Warning in group supysonic/0.6.2+ds-2: Use of uninitialized value in
string eq at /usr/share/lintian/checks/fields/package-relations.pm line 129.
E: supysonic: alternates-not-allowed Recommends
N:
E: alternates-not-allowed
N:
N:   Only the "Depends", "Recommends", "Suggests" and "Pre-Depends" fields
N:   may specify alternate dependencies using the "|" symbol.
N:
N:   Refer to Debian Policy Manual section 7.1 (Syntax of relationship
N:   fields) for details.
N:
N:   Severity: error
N:
N:   Check: fields/package-relations
N:
E: supysonic: alternates-not-allowed Suggests


-- 
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   po...@debian.org / veronneau.org
  ⠈⠳⣄



OpenPGP_signature
Description: OpenPGP digital signature

Bug#977419: lintian: Use of uninitialized value in string eq at package-relations.pm

[Francesco Poli (wintermute)]

Package: lintian
Version: 2.104.0
Severity: important

Hello!

While checking the apt-listbugs package (which I maintain), I experienced
an awkward lintian behavior:

  $ lintian -viF apt-listbugs_0.1.35~rc3_amd64.changes
  N: Using profile debian/ftp-master-auto-reject.
  N: Starting on group apt-listbugs/0.1.35~rc3
  Warning in group apt-listbugs/0.1.35~rc3: Use of uninitialized value in 
string eq at /usr/share/lintian/checks/fields/package-relations.pm line 129.
  Warning in group apt-listbugs/0.1.35~rc3: Use of uninitialized value in 
string eq at /usr/share/lintian/checks/fields/package-relations.pm line 129.
  [...]
  N: Finished processing group apt-listbugs/0.1.35~rc3

with the warning repeated 188 times.

If I enable more checks with:

  $ lintian -EviIL +pedantic apt-listbugs_0.1.35~rc3_amd64.changes

I get the same 188 warnings and two false positives:

  E: apt-listbugs: alternates-not-allowed Depends
  N:
  E: alternates-not-allowed
  N:
  N:   Only the "Depends", "Recommends", "Suggests" and "Pre-Depends" fields
  N:   may specify alternate dependencies using the "|" symbol.
  N:
  N:   Refer to Debian Policy Manual section 7.1 (Syntax of relationship
  N:   fields) for details.
  N:
  N:   Severity: error
  N:
  N:   Check: fields/package-relations
  N:
  E: apt-listbugs: alternates-not-allowed Suggests

I _think_ that these two complaints are false positives, since the
[debian/control] file has not changed since version 0.1.34 and
the same file has been previously (on December the 5th, 2020)
checked by the same version 2.104.0 of lintian, without any
complaint.
And I cannot understand what's wrong with the debian/control file.
But of course, I may be wrong: if this is the case, then please
help me understand...

[debian/control]: 


Is this new awkward behavior of lintian caused by some recent Perl
package upgrade in sid?
Among the lintian dependencies, I see the following changed versions:

  libicu67:amd64 (67.1-4)  ->  (67.1-5)
  libxml2:amd64 (2.9.10+dfsg-6.3)  ->  (2.9.10+dfsg-6.3+b1)
  liblist-moreutils-perl (0.416-1+b6)  ->  (0.430-1)

and nothing else, it seems.

Please investigate and fix this issue.
Thanks for your time!

Bye.



-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.9.0-4-amd64 (SMP w/4 CPU threads)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils2.35.1-4
ii  bzip2   1.0.8-4
ii  diffstat1.63-1
ii  dpkg1.20.5
ii  dpkg-dev1.20.5
ii  file1:5.39-3
ii  gettext 0.19.8.1-10
ii  gpg 2.2.20-1
ii  intltool-debian 0.35.0+20060710.5
ii  libapt-pkg-perl 0.1.36+b4
ii  libarchive-zip-perl 1.68-1
ii  libcapture-tiny-perl0.48-1
ii  libclass-xsaccessor-perl1.19-3+b6
ii  libclone-perl   0.45-1+b1
ii  libconfig-tiny-perl 2.24-1
ii  libcpanel-json-xs-perl  4.25-1+b1
ii  libdata-dpath-perl  0.58-1
ii  libdata-validate-domain-perl0.10-1
ii  libdevel-size-perl  0.83-1+b2
ii  libdpkg-perl1.20.5
ii  libemail-address-xs-perl1.04-1+b3
ii  libfile-basedir-perl0.08-1
ii  libfile-find-rule-perl  0.34-1
ii  libfont-ttf-perl1.06-1
ii  libhtml-html5-entities-perl 0.004-1
ii  libipc-run3-perl0.048-2
ii  libjson-maybexs-perl1.004003-1
ii  liblist-compare-perl0.55-1
ii  liblist-moreutils-perl  0.430-1
ii  liblist-utilsby-perl0.11-1
ii  libmoo-perl 2.004004-1
ii  libmoox-aliases-perl0.001006-1
ii  libnamespace-clean-perl 0.27-1
ii  libpath-tiny-perl   0.114-1
ii  libperlio-gzip-perl 0.19-1+b7
ii  libproc-processtable-perl   0.59-2+b1
ii  libsereal-decoder-perl  4.018+ds-1+b1
ii  libsereal-encoder-perl  4.018+ds-1+b1
ii  libtext-glob-perl   0.11-1
ii  libtext-levenshteinxs-perl  0.03-4+b8
ii  libtext-markdown-discount-perl  0.12-1+b1
ii  libtext-xslate-perl 3.5.8-1+b1
ii  libtime-duration-perl   1.21-1
ii  libtime-moment-perl 0.44-1+b3
ii  libtimedate-perl2.3300-1
ii  libtry-tiny-perl0.30-1
ii  libtype-tiny-perl   1.012000-1
ii  libunicode-utf8-perl0.62-1+b2
ii  liburi-perl 5.05-1
ii  libxml-libxml-perl  2.0134+dfsg-2+b1
ii  libyaml-libyaml-perl