Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-16 Thread Reinhard Tartler
Got it. On Tue, Feb 16, 2021 at 4:03 PM Sebastian Ramacher wrote: > Control: severity -1 serious > > [...] > Tests are executed as part of the binary target: > > dh binary --no-act | grep auto_test >dh_auto_test > > So the "no required targets may attmept network access" rule applies. >

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-16 Thread Sebastian Ramacher
Control: severity -1 serious On 2021-02-16 21:50:32 +0100, Paul Gevers wrote: > Control: Hi, > > On 15-02-2021 19:23, Paul Gevers wrote: > > Hi Reinhard, > > > > On 15-02-2021 15:08, Reinhard Tartler wrote: > >> Control: severity -1 important > > > > I agree with this. The Debian infra allows

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-16 Thread Paul Gevers
Control: Hi, On 15-02-2021 19:23, Paul Gevers wrote: > Hi Reinhard, > > On 15-02-2021 15:08, Reinhard Tartler wrote: >> Control: severity -1 important > > I agree with this. The Debian infra allows for use of the internet (if > not used to download programs, that's forbidden by ftp-master [1].)

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-16 Thread Paul Gevers
Hi Reinhard, On 16-02-2021 12:39, Reinhard Tartler wrote: > Is this something appropriate to upload at this point or rather after > bullseye release? It's fine to do now, but I'm not attached to having it in bullseye. Paul OpenPGP_signature Description: OpenPGP digital signature

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-16 Thread Reinhard Tartler
Got it, thanks! On Tue, Feb 16, 2021 at 1:46 AM Paul Gevers wrote: > Hi > > On 15-02-2021 23:46, Reinhard Tartler wrote: > > This package doesn't (like most golang-packages) install a > > debian/tests/control file, > > but instead has a field 'Testsuite: autopkgtest-pkg-go' in > >

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-15 Thread Paul Gevers
Hi On 15-02-2021 23:46, Reinhard Tartler wrote: > This package doesn't (like most golang-packages) install a > debian/tests/control file, > but instead has a field 'Testsuite: autopkgtest-pkg-go' in > debian/control instead. > > How to add the 'needs-internet' restriction to this testsuite?

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-15 Thread Reinhard Tartler
Dear Golang Team, On Mon, Feb 15, 2021 at 1:23 PM Paul Gevers wrote: > On 15-02-2021 15:08, Reinhard Tartler wrote: > > Control: severity -1 important > > I agree with this. The Debian infra allows for use of the internet (if > not used to download programs, that's forbidden by ftp-master [1].)

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-15 Thread Holger Levsen
On Mon, Feb 15, 2021 at 07:23:19PM +0100, Paul Gevers wrote: > There's multiple things to say. [...] > 2) if possible, those tests should be in a separate autopkgtest > paragraph, such then when needs-internet tests are skipped (e.g. because > the infra doesn't provide access, like in Ubuntu) the

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-15 Thread Paul Gevers
Hi Reinhard, On 15-02-2021 15:08, Reinhard Tartler wrote: > Control: severity -1 important I agree with this. The Debian infra allows for use of the internet (if not used to download programs, that's forbidden by ftp-master [1].) > I'm writing as a member of the pkg-go team and am mostly

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-15 Thread Reinhard Tartler
Control: severity -1 important Dear release team, I'm writing as a member of the pkg-go team and am mostly concerned about potential removal of depending packages. The package itself appears to be fine. The tests fail if and only if the test setup doesn't provide (proper) internet connectivity.

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-02-14 Thread Ritesh Raj Sarraf
Source: golang-github-revel-revel Severity: serious Followup-For: Bug #977542 We've run into the same build failure during a rebuild of the package in a Bullseye based derivative. The same build failures are also seen in the Reproducible Builds. So, I'm rasing the severity of this bug report.

Bug#977542: golang-github-revel-revel: Depends on network in tests

2021-01-24 Thread Logan Rosen
Control: tags -1 patch Hi, In Ubuntu, the attached patch was applied to achieve the following: * d/p/0002-skip-test-requiring-network-access.patch: Skip TestGetCustom, which requires network access and thus fails on Ubuntu buildds. Thanks for considering the patch. Logan diff -Nru

Bug#977542: golang-github-revel-revel - Depends on network in tests

2020-12-16 Thread Sven Mueller
Package: golang-github-revel-revel Version: 1.0.0-1 golang-github-revel-revel fails to run tests if the network doesn't provide working DNS. Technically, this is a policy violation. Please disable the relevant test or make it independent of the network. === RUN TestGetCustom --- FAIL: