Package: release.debian.org
Severity: normal
X-Debbugs-Cc: Debian Qt/KDE Maintainers
Dear Release Team,
KDE Apps 20.12.3 will be released tomorrow and a preliminary
changelog is available at [1].
I’d like to get a pre-aproval for uploading the packages listed below as
they will not have migrated to testing before the hard freeze.
I’m listing the change log first then the code diffs, excluding
translation updates and version changes in xml metadata files.
Juk has a couple of trivial packaging changes pending and other packages
would be uploaded as is with just the new upstream version.
Feel free to ask for the changes in any other form if it makes the review
easier for you.
[1] https://phabricator.kde.org/P672
Thanks,
--
Aurélien
== change log ==
elisa-player
- fix sort by duration to not use string sort
gwenview
- Switch from QGLWidget to QOpenGLWidget
- Use Quality level when saving JPEG images
juk
- filerenamer: Prevent creating track name folders
kdeconnect-kde
- Don't escape notification title text
konsole
- Delete client builder before d-pointer of KXMLGUIClient is killed
=== kpmcore ===
- Fix out of bounds read when parsing fstab.
- Add initial support for dosfstools 4.2.
krdc
- Fix low quality connections
- VNC: accept the wheel event
- Unpress modifiers on focusOutEvent in VncView
marble
- Fix GeoNames web service URL, is now api.geonames.org (#432598)
- Provide BUILD_TOUCH option to force install of touch variant
okular
- presentation: Show better the status of the "playing" button
- pdf: Fix InPlace text annotations being loaded as linked
palapeli
- Make the cache work
kde-spectacle
- Fix compression quality range
===
== diffs ==
===
elisa-player
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 10078c21..17f34229 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -7,7 +7,7 @@ cmake_minimum_required(VERSION 3.8)
# KDE Applications version, managed by release script.
set(RELEASE_SERVICE_VERSION_MAJOR "20")
set(RELEASE_SERVICE_VERSION_MINOR "12")
-set(RELEASE_SERVICE_VERSION_MICRO "2")
+set(RELEASE_SERVICE_VERSION_MICRO "3")
set(RELEASE_SERVICE_VERSION
"${RELEASE_SERVICE_VERSION_MAJOR}.${RELEASE_SERVICE_VERSION_MINOR}.${RELEASE_SERVICE_VERSION_MICRO}")
project(elisa
diff --git a/src/models/datamodel.cpp b/src/models/datamodel.cpp
index 69d71397..7559c0e5 100644
--- a/src/models/datamodel.cpp
+++ b/src/models/datamodel.cpp
@@ -87,7 +87,7 @@ QHash DataModel::roleNames() const
roles[static_cast(DataTypes::ColumnsRoles::AlbumRole)] = "album";
roles[static_cast(DataTypes::ColumnsRoles::AlbumArtistRole)] =
"albumArtist";
-roles[static_cast(DataTypes::ColumnsRoles::DurationRole)] =
"duration";
+roles[static_cast(DataTypes::ColumnsRoles::StringDurationRole)] =
"duration";
roles[static_cast(DataTypes::ColumnsRoles::TrackNumberRole)] =
"trackNumber";
roles[static_cast(DataTypes::ColumnsRoles::DiscNumberRole)] =
"discNumber";
roles[static_cast(DataTypes::ColumnsRoles::RatingRole)] = "rating";
@@ -156,7 +156,7 @@ QVariant DataModel::data(const QModelIndex , int
role) const
break;
}
break;
-case DataTypes::ColumnsRoles::DurationRole:
+case DataTypes::ColumnsRoles::StringDurationRole:
{
switch (d->mModelType)
{
gwenview
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 25adb69b..c34f4108 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -3,7 +3,7 @@ cmake_minimum_required (VERSION 3.0 FATAL_ERROR)
# KDE Application Version, managed by release script
set (RELEASE_SERVICE_VERSION_MAJOR "20")
set (RELEASE_SERVICE_VERSION_MINOR "12")
-set (RELEASE_SERVICE_VERSION_MICRO "1")
+set (RELEASE_SERVICE_VERSION_MICRO "3")
set (RELEASE_SERVICE_VERSION
"${RELEASE_SERVICE_VERSION_MAJOR}.${RELEASE_SERVICE_VERSION_MINOR}.${RELEASE_SERVICE_VERSION_MICRO}")
project(gwenview VERSION ${RELEASE_SERVICE_VERSION})
@@ -51,7 +51,7 @@ else()
set(GWENVIEW_SEMANTICINFO_BACKEND_BALOO ON)
endif()
-find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED Core Widgets Concurrent Svg
OpenGL PrintSupport)
+find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED Core Widgets Concurrent Svg
PrintSupport)
find_package(Qt5DBus ${QT_MIN_VERSION} CONFIG QUIET)
set(HAVE_QTDBUS ${Qt5DBus_FOUND})
diff --git a/app/gvcore.cpp b/app/gvcore.cpp
index 9f400059..4008e19c 100644
--- a/app/gvcore.cpp
+++ b/app/gvcore.cpp
@@ -425,8 +425,10 @@ void GvCore::saveAs(const QUrl )
} else {
// Regardless of job result, reset JPEG config value if it was changed
by
// the Save As dialog
-if (GwenviewConfig::jPEGQuality() != d->configFileJPEGQualityValue)
-GwenviewConfig::setJPEGQuality(d->configFileJPEGQualityValue);
+connect(job, ::result, [=]() {
+if (GwenviewConfig::jPEGQuality() !=
