Bug#984901: RFS: open-ath9k-htc-firmware/1.4.0-106-gc583009+dfsg1-2 -- firmware for AR7010 and AR9271 USB wireless adapters
On Tue, 2021-06-01 at 07:07 +0200, Tobias Frost wrote: > The Files-Excluded section is used by tools like uscan to strip files from the > orig.tar. The formatted text just says that the field can extend over > multiple > lines, it does not mean its free text without meaning. > TL;DR: I'm pretty sure you want the Comment: here. A quick test with > uscan --verbose --force-download will convince you too. Okay, I've restored the Comment: field with the rationale for repacking. > You cannot assume that those files are not copyrightable, at minimum > that would be a question for debian-legal. Generally, copyrightabilty > is a very low barrier. Looking at NOTICE.TXT it is definitly > copyrightable and has even a copyright statement, for example. > Looking at README, it is also definitly beyond that barrier. > > *Usually* (I didnt check this particular case) such companion files > in the repo are under the same license that the other files, > thereofore usually the debian/* stanca is fine. > > Strictly, if there is no copyright information, it defaults to "all > rights reserved", which means "not even distributeable." > So if in doubt, you need to ask upstream to clarify. > > I guess it would be just easier to reinstanciate the * section, as > ftp masters have at least one time looked at it already and found it > ok. I've reinstated the wildcard section so that the Qualcomm Atheros copyright applies to the README, NOTICES.TXT, and .gitignore. > > > - W: open-ath9k-htc-firmware source: inconsistent-appstream- > > > metadata-license > > >debian/firmware-ath9k-htc.metainfo.xml (mit != expat) > > In my opinion this is a bug that could be fixed in Lintian. If you're > > not aware, the Expat license is a specific version of what's commonly > > known as the MIT license. The SPDX identifier (and hence the identifier > > used in the AppStream file) is MIT, although the Debian machine- > > readable copyright specification requests that one refer to the Expat > > license when that license is applicable. > > > > Basically, the copyright file referring to the Expat license is > > consistent with the AppStream metadata proclaiming that it is subject > > to the MIT license. > > OK, in this case an override and a comment towards the override would > be helpful. Bonus points for filing a bug against lintian. I've decided that a Lintian override is most appropriate, since this particular case (MIT != Expat) applies to only a couple other packages and it's important for package maintainers to validate that their variant of the MIT license is in fact the Expat license. > > > Some patch have fuzz... maybe refresh? > > If you're referring to > > Hunk #1 succeeded at 43 (offset -1 lines). > > Hunk #2 succeeded at 55 (offset -1 lines). > > Hunk #3 succeeded at 99 (offset -1 lines). > > Hunk #4 succeeded at 113 (offset -1 lines). > > Hunk #5 succeeded at 151 (offset -1 lines). > > then I believe this is normal, although refreshing the patches upstream > > shouldn't hurt. > Certainly it does not hurt to refresh. Unfortunately upstream has been unresponsive and not been accepting of my patch to use GCC 11 and newer Binutils which, however, I will refresh in my merge request. In the longer-term, we'll probably be better off using Clang instead of GCC when LLVM gets Xtensa support: https://reviews.llvm.org/D64830 As soon as those patches are accepted, I plan to experiment with getting it working and spearhead the effort upstream. This would also be of benefit to the OpenBSD Project which also uses this firmware. Xtensa is a CPU architecture that is custom-fabricated for various products, hence why we have to bootstrap our cross toolchain from scratch when building this firmware. This requires patches to the GCC sources so it knows exactly what chip we're targeting. With Clang, no source-level changes will be required. signature.asc Description: This is a digitally signed message part
Bug#984901: RFS: open-ath9k-htc-firmware/1.4.0-106-gc583009+dfsg1-2 -- firmware for AR7010 and AR9271 USB wireless adapters
Control: tags -1 moreinfo On Tue, Jun 01, 2021 at 02:22:15AM +, John Scott wrote: > Control: tags -1 -moreinfo > > On Mon, 2021-05-31 at 20:25 +0200, Tobias Frost wrote: > > I've took a look at your package: > Awesome, thanks. > > > - d/copyright: > > - The word "Comment:" went missing after the Files-Exlucded section. > I don't believe this is an error. The Files-Excluded field is currently > not specified by the machine-readable copyright specification (this is > bug #685506), but at least the mk-origtargz manual page specifies that > this should be what the spec calls 'formatted text', i.e. the current > syntax should be valid: > > (In debian/copyright, the Files-Excluded and Files-Excluded-component > > stanzas are a part of the first paragraph and there is a blank line > > before the following paragraphs which contain Files and other > > stanzas. See uscan(1) "COPYRIGHT FILE EXAMPLE".) The Files-Excluded section is used by tools like uscan to strip files from the orig.tar. The formatted text just says that the field can extend over multiple lines, it does not mean its free text without meaning. TL;DR: I'm pretty sure you want the Comment: here. A quick test with uscan --verbose --force-download will convince you too. > > - Please review the file. I see e.g the section for "Files: *" be > > gone, not sure if that is intentional (I did not a d/copyright > > review) > This was intentional. > > > Lintian is the same oppionion that there is something missing: > > > > W: open-ath9k-htc-firmware source: file-without-copyright-information > > .gitignore > > W: open-ath9k-htc-firmware source: file-without-copyright-information > > NOTICE.TXT > > W: open-ath9k-htc-firmware source: file-without-copyright-information > > README > Those files have no copyright information, but they are so small > they're probably not copyrightable. There s no copyright status to > associate with them, so it's better that the copyright file say nothing > at all with respect to them. I'm sorry; no. You cannot assume that those files are not copyrightable, at minimum that would be a question for debian-legal. Generally, copyrightabilty is a very low barrier. Looking at NOTICE.TXT it is definitly copyrightable and has even a copyright statement, for example. Looking at README, it is also definitly beyond that barrier. *Usually* (I didnt check this particular case) such companion files in the repo are under the same license that the other files, thereofore usually the debian/* stanca is fine. Strictly, if there is no copyright information, it defaults to "all rights reserved", which means "not even distributeable." So if in doubt, you need to ask upstream to clarify. I guess it would be just easier to reinstanciate the * section, as ftp masters have at least one time looked at it already and found it ok. > > - W: open-ath9k-htc-firmware source: inconsistent-appstream- > > metadata-license > >debian/firmware-ath9k-htc.metainfo.xml (mit != expat) > In my opinion this is a bug that could be fixed in Lintian. If you're > not aware, the Expat license is a specific version of what's commonly > known as the MIT license. The SPDX identifier (and hence the identifier > used in the AppStream file) is MIT, although the Debian machine- > readable copyright specification requests that one refer to the Expat > license when that license is applicable. > > Basically, the copyright file referring to the Expat license is > consistent with the AppStream metadata proclaiming that it is subject > to the MIT license. OK, in this case an override and a comment towards the override would be helpful. Bonus points for filing a bug against lintian. > > Some patch have fuzz... maybe refresh? > If you're referring to > Hunk #1 succeeded at 43 (offset -1 lines). > Hunk #2 succeeded at 55 (offset -1 lines). > Hunk #3 succeeded at 99 (offset -1 lines). > Hunk #4 succeeded at 113 (offset -1 lines). > Hunk #5 succeeded at 151 (offset -1 lines). > then I believe this is normal, although refreshing the patches upstream > shouldn't hurt. Certainly it does not hurt to refresh. -- Cheers, tobi
Bug#984901: RFS: open-ath9k-htc-firmware/1.4.0-106-gc583009+dfsg1-2 -- firmware for AR7010 and AR9271 USB wireless adapters
Control: tags -1 -moreinfo On Mon, 2021-05-31 at 20:25 +0200, Tobias Frost wrote: > I've took a look at your package: Awesome, thanks. > - d/copyright: > - The word "Comment:" went missing after the Files-Exlucded section. I don't believe this is an error. The Files-Excluded field is currently not specified by the machine-readable copyright specification (this is bug #685506), but at least the mk-origtargz manual page specifies that this should be what the spec calls 'formatted text', i.e. the current syntax should be valid: > (In debian/copyright, the Files-Excluded and Files-Excluded-component > stanzas are a part of the first paragraph and there is a blank line > before the following paragraphs which contain Files and other > stanzas. See uscan(1) "COPYRIGHT FILE EXAMPLE".) > - Please review the file. I see e.g the section for "Files: *" be > gone, not sure if that is intentional (I did not a d/copyright > review) This was intentional. > Lintian is the same oppionion that there is something missing: > > W: open-ath9k-htc-firmware source: file-without-copyright-information > .gitignore > W: open-ath9k-htc-firmware source: file-without-copyright-information > NOTICE.TXT > W: open-ath9k-htc-firmware source: file-without-copyright-information > README Those files have no copyright information, but they are so small they're probably not copyrightable. There s no copyright status to associate with them, so it's better that the copyright file say nothing at all with respect to them. > - W: open-ath9k-htc-firmware source: inconsistent-appstream- > metadata-license >debian/firmware-ath9k-htc.metainfo.xml (mit != expat) In my opinion this is a bug that could be fixed in Lintian. If you're not aware, the Expat license is a specific version of what's commonly known as the MIT license. The SPDX identifier (and hence the identifier used in the AppStream file) is MIT, although the Debian machine- readable copyright specification requests that one refer to the Expat license when that license is applicable. Basically, the copyright file referring to the Expat license is consistent with the AppStream metadata proclaiming that it is subject to the MIT license. > Some patch have fuzz... maybe refresh? If you're referring to Hunk #1 succeeded at 43 (offset -1 lines). Hunk #2 succeeded at 55 (offset -1 lines). Hunk #3 succeeded at 99 (offset -1 lines). Hunk #4 succeeded at 113 (offset -1 lines). Hunk #5 succeeded at 151 (offset -1 lines). then I believe this is normal, although refreshing the patches upstream shouldn't hurt. signature.asc Description: This is a digitally signed message part
Bug#984901: RFS: open-ath9k-htc-firmware/1.4.0-106-gc583009+dfsg1-2 -- firmware for AR7010 and AR9271 USB wireless adapters
Control: tags -1 moreinfo Hi John, I've took a look at your package: - d/copyright: - The word "Comment:" went missing after the Files-Exlucded section. - Please review the file. I see e.g the section for "Files: *" be gone, not sure if that is intentional (I did not a d/copyright review) Lintian is the same oppionion that there is something missing: W: open-ath9k-htc-firmware source: file-without-copyright-information .gitignore W: open-ath9k-htc-firmware source: file-without-copyright-information NOTICE.TXT W: open-ath9k-htc-firmware source: file-without-copyright-information README - W: open-ath9k-htc-firmware source: inconsistent-appstream-metadata-license debian/firmware-ath9k-htc.metainfo.xml (mit != expat) - Some patch have fuzz... maybe refresh? Please fix above and then remove the moreinfo tag. -- Cheers, tobi
Bug#984901: RFS: open-ath9k-htc-firmware/1.4.0-106-gc583009+dfsg1-2 -- firmware for AR7010 and AR9271 USB wireless adapters
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "open-ath9k-htc-firmware": * Package name : open-ath9k-htc-firmware Version : 1.4.0-106-gc583009+dfsg1-2 Upstream Author : Qualcomm Atheros and contributors * URL : https://github.com/qca/open-ath9k-htc-firmware * License : mostly Clear BSD 3 Clause * Vcs : https://salsa.debian.org/jscott/open-ath9k-htc-firmware Section : kernel It builds those binary packages: firmware-ath9k-htc-udeb - firmware for AR7010 and AR9271 USB wireless adapters firmware-ath9k-htc - firmware for AR7010 and AR9271 USB wireless adapters To access further information about this package, please visit the following URL: https://mentors.debian.net/package/open-ath9k-htc-firmware/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/o/open-ath9k-htc-firmware/open-ath9k-htc-firmware_1.4.0-106-gc583009+dfsg1-2.dsc Changes since the last upload: open-ath9k-htc-firmware (1.4.0-106-gc583009+dfsg1-2) experimental; urgency=medium . * Add package version control info. * Clean up the copyright file. - Distinguish the BSD 3-Clause Clear variant from the conventional one. - Make conformant to DEP-5 specification for machine readability. * Add a udeb for incorporation into the Debian Installer. * Build cross toolchain with Binutils 2.36 and GCC 11 with patch. I cleaned up debian/rules somewhat as well. I've also written improved AppStream metadata, but I'm waiting for that to be accepted upstream. The principal purpose of this upload is to get the udeb through NEW, although more work needs to be done in the Kernel Team's tooling before it can be part of the installer. signature.asc Description: This is a digitally signed message part
