Bug#989581: autopkgtest: ADTTMP is now obsolete
On Fri, 20 Aug 2021 at 14:32:27 -0700, Sean Whitton wrote: > I believe that it's been AUTOPKGTEST_TMP for a very long time now Just over 5 years, FYI (autopkgtest 4.0, 2016-06-08). smcv
Bug#989581: autopkgtest: ADTTMP is now obsolete
Hello Bill, On Tue 29 Jun 2021 at 11:13AM +02, Bill Allombert wrote: > On Mon, Jun 28, 2021 at 03:20:04PM -0700, Sean Whitton wrote: >> control: tag -1 + pending >> >> Hello Fabrice, >> >> On Mon 07 Jun 2021 at 11:53PM +02, Fabrice BAUZAC wrote: >> >> > autopkgtest.md only mentions the ADTTMP environment variable, while >> > lintian marks ADTTMP usage as deprecated in favour of AUTOPKGTEST_TMP. >> > >> > See https://lintian.debian.org/tags/uses-deprecated-adttmp >> > >> > I think autopkgtest.md should at least mention the new variable... >> >> Thank you for this. I've committed a fix -- I just changed the variable >> name rather than using your patch, if you don't mind, because it seemed >> unnecessary to me to mention the old name at all. > > Maybe add it to the upgrading-checklist. I believe that it's been AUTOPKGTEST_TMP for a very long time now, and it's not a normative requirement of Policy but a piece of information, so I decided not to do this for now. -- Sean Whitton signature.asc Description: PGP signature
Bug#989581: autopkgtest: ADTTMP is now obsolete
On Mon, Jun 28, 2021 at 03:20:04PM -0700, Sean Whitton wrote: > control: tag -1 + pending > > Hello Fabrice, > > On Mon 07 Jun 2021 at 11:53PM +02, Fabrice BAUZAC wrote: > > > autopkgtest.md only mentions the ADTTMP environment variable, while > > lintian marks ADTTMP usage as deprecated in favour of AUTOPKGTEST_TMP. > > > > See https://lintian.debian.org/tags/uses-deprecated-adttmp > > > > I think autopkgtest.md should at least mention the new variable... > > Thank you for this. I've committed a fix -- I just changed the variable > name rather than using your patch, if you don't mind, because it seemed > unnecessary to me to mention the old name at all. Maybe add it to the upgrading-checklist. Cheers, -- Bill. Imagine a large red swirl here.
Bug#989581: autopkgtest: ADTTMP is now obsolete
control: tag -1 + pending Hello Fabrice, On Mon 07 Jun 2021 at 11:53PM +02, Fabrice BAUZAC wrote: > autopkgtest.md only mentions the ADTTMP environment variable, while > lintian marks ADTTMP usage as deprecated in favour of AUTOPKGTEST_TMP. > > See https://lintian.debian.org/tags/uses-deprecated-adttmp > > I think autopkgtest.md should at least mention the new variable... Thank you for this. I've committed a fix -- I just changed the variable name rather than using your patch, if you don't mind, because it seemed unnecessary to me to mention the old name at all. -- Sean Whitton signature.asc Description: PGP signature
Bug#989581:
Tags: patch I humbly propose this change: >From 4de312af857234e20b5e01b5b2fa61fa50496995 Mon Sep 17 00:00:00 2001 From: Fabrice Bauzac Date: Tue, 8 Jun 2021 00:00:38 +0200 Subject: [PATCH] autopkgtest: mark ADTTMP as obsolete, replaced with AUTOPKGTEST_TMP Closes: #989581. --- autopkgtest.md | 19 ++- debian/changelog | 4 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/autopkgtest.md b/autopkgtest.md index c984a23..1480ba7 100644 --- a/autopkgtest.md +++ b/autopkgtest.md @@ -30,10 +30,11 @@ If the file to be executed has no execute bits set, `chmod a+x` is applied to it (this means that tests can be added in patches without the need for additional chmod; contrast this with debian/rules). -During execution of the test, the environment variable `$ADTTMP` will +During execution of the test, the environment variable +`$AUTOPKGTEST_TMP` (previously named `$ADTTMP`, now obsolete) will point to a directory for the execution of this particular test, which -starts empty and will be deleted afterwards (so there is no need for the -test to clean up files left there). +starts empty and will be deleted afterwards (so there is no need for +the test to clean up files left there). If tests want to create artifacts which are useful to attach to test results, such as additional log files or screenshots, they can put them @@ -166,13 +167,13 @@ Defined restrictions running the tests. However, the tests are *not* entitled to assume that the source package's build dependencies will be installed when the test is run. - Please use this considerately, as for large builds it unnecessarily builds - the entire project when you only need a tiny subset (like the tests/ + Please use this considerately, as for large builds it unnecessarily builds the + entire project when you only need a tiny subset (like the tests/ subdirectory). It is often possible to run `make -C tests` instead, or copy - the test code to `$ADTTMP` and build it there with some custom commands. This - cuts down the load on the Continuous Integration servers and also makes tests - more robust as it prevents accidentally running them against the built source - tree instead of the installed packages. + the test code to `$AUTOPKGTEST_TMP` and build it there with some custom + commands. This cuts down the load on the Continuous Integration servers and + also makes tests more robust as it prevents accidentally running them against + the built source tree instead of the installed packages. - **allow-stderr** diff --git a/debian/changelog b/debian/changelog index c4cc189..426a931 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,9 +1,13 @@ debian-policy (4.5.1.1) UNRELEASED; urgency=medium + [ Sean Whitton ] * 4.4: Fix changelog format: needs an extra space before sign-off (Closes: #976301). Thanks to Anatoli Babenia for reporting the problem. + [ Fabrice Bauzac-Stehly ] + * autopkgtest: mark ADTTMP as obsolete, replaced with AUTOPKGTEST_TMP. +Closes: #989581. -- Sean Whitton Tue, 19 Jan 2021 13:47:45 -0700 -- 2.30.2
Bug#989581: autopkgtest: ADTTMP is now obsolete
Package: debian-policy Version: 4.5.1.0 Severity: normal Hello, autopkgtest.md only mentions the ADTTMP environment variable, while lintian marks ADTTMP usage as deprecated in favour of AUTOPKGTEST_TMP. See https://lintian.debian.org/tags/uses-deprecated-adttmp I think autopkgtest.md should at least mention the new variable... Thanks! -- System Information: Debian Release: 11.0 APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.10.0-7-amd64 (SMP w/8 CPU threads) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C), LANGUAGE=en_US:en Shell: /bin/sh linked to /usr/bin/bash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled debian-policy depends on no packages. Versions of packages debian-policy recommends: ii libjs-sphinxdoc 3.4.3-2 Versions of packages debian-policy suggests: ii doc-base 0.11.1 -- no debconf information
