Bug#990580: debdiff for NMU apache2 (= 2.4.48-3.1) (was Re: Bug#990580: apache2: [regression] daily cron mails from logrotate: Reloading Apache httpd web server: apache2., caused by #979813)
On Sun, 11 Jul 2021, Adam Borowski wrote: > I for one believe the old behaviour was superior for the common case of > "success" -- no news is good news No disagreement from here. We could do things like… output=$(command 2>&1; echo $? >tempfile) case $(cat tempfile 2>&1) in (0) ;; (*) printf >&2 '%s\n' "$output" ;; esac … but… > • three weeks before the release is no time for such meddling … precisely this. > • it should be coded in sysv-rc/runit/etc instead of every daemon Nope. This is out of the scope of init systems. bye, //mirabilos -- Infrastrukturexperte • tarent solutions GmbH Am Dickobskreuz 10, D-53121 Bonn • http://www.tarent.de/ Telephon +49 228 54881-393 • Fax: +49 228 54881-235 HRB AG Bonn 5168 • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg * Mit dem tarent-Newsletter nichts mehr verpassen: www.tarent.de/newsletter *
Bug#990580: debdiff for NMU apache2 (= 2.4.48-3.1) (was Re: Bug#990580: apache2: [regression] daily cron mails from logrotate: Reloading Apache httpd web server: apache2., caused by #979813)
On Sat, Jul 10, 2021 at 11:37:33PM +0200, Thorsten Glaser wrote: > OK, thanks for the maintainer approval. Accordingly, I have > just uploaded the attached debdiff. I chose to direct the > output to syslog instead of the bitbucket so it is not lost > if someone indeed needs it so it isn’t a regression. > - invoke-rc.d apache2 reload > + invoke-rc.d apache2 reload 2>&1 | logger -t apache2.logrotate I for one believe the old behaviour was superior for the common case of "success" -- no news is good news, no need to bother anyone just because logrotate does its job, especially that the restart is already logged elsewhere. On the other hand, logging failures is a damn good idea. But then: • three weeks before the release is no time for such meddling • it should be coded in sysv-rc/runit/etc instead of every daemon (the author of the patch that regressed this was probably used to a certain inferior rc system that fails to notify an interactive user whether a reload succeeded or was a no-op due to in-chroot policy/etc, which is a major no-no) Thus, thank you TG for the for-Bullseye fix! Meow. -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ If you ponder doing what Jesus did, remember than flipping tables ⢿⡄⠘⠷⠚⠋⠀ and chasing people with a whip is a prime choice. ⠈⠳⣄
Bug#990580: debdiff for NMU apache2 (= 2.4.48-3.1) (was Re: Bug#990580: apache2: [regression] daily cron mails from logrotate: Reloading Apache httpd web server: apache2., caused by #979813)
On Fri, 9 Jul 2021, Yadd wrote: > Apache2 is RFH for years, feel free to contribute OK, thanks for the maintainer approval. Accordingly, I have just uploaded the attached debdiff. I chose to direct the output to syslog instead of the bitbucket so it is not lost if someone indeed needs it so it isn’t a regression. bye, //mirabilos -- Infrastrukturexperte • tarent solutions GmbH Am Dickobskreuz 10, D-53121 Bonn • http://www.tarent.de/ Telephon +49 228 54881-393 • Fax: +49 228 54881-235 HRB AG Bonn 5168 • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg * Mit dem tarent-Newsletter nichts mehr verpassen: www.tarent.de/newsletter *diff -Nru apache2-2.4.48/debian/apache2.logrotate apache2-2.4.48/debian/apache2.logrotate --- apache2-2.4.48/debian/apache2.logrotate 2021-06-20 13:55:24.0 +0200 +++ apache2-2.4.48/debian/apache2.logrotate 2021-07-10 23:31:24.0 +0200 @@ -14,7 +14,7 @@ endscript postrotate if pgrep -f ^/usr/sbin/apache2 > /dev/null; then - invoke-rc.d apache2 reload + invoke-rc.d apache2 reload 2>&1 | logger -t apache2.logrotate fi endscript } diff -Nru apache2-2.4.48/debian/changelog apache2-2.4.48/debian/changelog --- apache2-2.4.48/debian/changelog 2021-06-20 16:39:33.0 +0200 +++ apache2-2.4.48/debian/changelog 2021-07-10 23:31:28.0 +0200 @@ -1,3 +1,11 @@ +apache2 (2.4.48-3.1) unstable; urgency=medium + + * Non-maintainer upload. + * Direct init script reload output from logrotate to syslog, to +avoid mail-spamming the local admin (Closes: #990580) + + -- Thorsten Glaser Sat, 10 Jul 2021 23:31:28 +0200 + apache2 (2.4.48-3) unstable; urgency=medium * Fix debian/changelog
Bug#990580: apache2: [regression] daily cron mails from logrotate: Reloading Apache httpd web server: apache2., caused by #979813
Le 09/07/2021 à 05:04, Thorsten Glaser a écrit : > Thanks Adam for the analysis! > >> To stop the mails from logrotate, could you please change back: >> - invoke-rc.d apache2 reload >> + invoke-rc.d apache2 reload > /dev/null 2>&1 >> >> otherwise, people running Bullseye will be mightily unhappy. >> >> I also wonder why such a cleanup was done late during hard freeze. > > Indeed. ping‽ (I intend to NMU if no activity happens.) > > bye, > //mirabilos Hi, Apache2 is RFH for years, feel free to contribute
Bug#990580: apache2: [regression] daily cron mails from logrotate: Reloading Apache httpd web server: apache2., caused by #979813
Thanks Adam for the analysis! > To stop the mails from logrotate, could you please change back: > - invoke-rc.d apache2 reload > + invoke-rc.d apache2 reload > /dev/null 2>&1 > > otherwise, people running Bullseye will be mightily unhappy. > > I also wonder why such a cleanup was done late during hard freeze. Indeed. ping‽ (I intend to NMU if no activity happens.) bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg * Mit unserem Consulting bieten wir Unternehmen maßgeschneiderte Angebote in Form von Beratung, Trainings sowie Workshops in den Bereichen Softwaretechnologie, IT Strategie und Architektur, Innovation und Umsetzung sowie Agile Organisation. Besuchen Sie uns auf https://www.tarent.de/consulting . Wir freuen uns auf Ihren Kontakt. *
