Bug#993552: RFS: proton-caller/2.3.2-1 [ITP] -- Run any Windows program through Proton
BenTheTechGuy:
>> [...]
>> debian/rules is missing a lot of functionality: mandatory targets like
>> {build,binary}-arch; passing build flags, handling cross builds, etc.
>> All of this would be much better done with dh (like the vast majority
>> of packages in Debian do) -- it does know how to use cargo, etc.
>> Likewise, there's no need to run install by hand.
>
> I can't get it to work without manually telling dh_build to run cargo.
> If someone can point me in the right direction of how to format my
> debian/rules to build with cargo then put binaries, config files, and
> such in the right place (there is nothing about that in Cargo.toml)
> that would be very helpful.
>
> Thank you so much Adam for helping me get some things straightened
> out, the latest upload
> https://mentors.debian.net/debian/pool/main/p/proton-caller/proton-caller_2.3.2-2.dsc
> fixes all the problems you pointed out!
>
Indeed, the core debhelper tool stack does *not* support cargo out of
the box. There is a `dh-cargo` add-on that may (or may not) be helpful.
>From a quick look, it should be a better of "Build-Depends: dh-cargo"
and then passing --buildsystem=cargo to dh (or to each of the dh_auto_*
tools). But I have never used it and I could not spot any obvious
"getting started" documentation for it.
I hope that was useful as a "drive-by remark".
~Niels
Bug#993552: RFS: proton-caller/2.3.2-1 [ITP] -- Run any Windows program through Proton
> The license is MIT. Please correct debian/copyright.
The author switched the license from GPL3 to MIT without telling me, fixed.
> The program depends on non-free Steam, thus it can't go into the main
> archive. It is a nice specimen of a "contrib" package, though.
> You can put it there by changing Section to contrib/XXX.
I didn't know that specifying the section by itself implied main, fixed.
> The package fails to build:
> .
> cargo build --release --locked
> make: cargo: No such file or directory
> `
> Fix: Build-Depends: cargo
I didn't realize cargo was only a recommended dependency of rustc, fixed.
> For a new package, there should be only one changelog entry (unless the
> package already exists in a repository used by actual other people).
I forgot to mention that I already maintain this on the project's
GitHub Releases page.
However, I have removed all previous changelog entries.
> The long descriptions really should be longer than one line. It'd be nice
> if you could write something more what is it good for (as I understand,
> it's an equivalent to "wine freecell.exe"), what's the diff from Wine, etc.
A better long description has been added.
> An upload to Debian must be targetted at "unstable" or "experimental"
> (other options being irrelevant for now), you currently have it set to
> "UNRELEASED".
It has been changed to unstable.
> debian/rules is missing a lot of functionality: mandatory targets like
> {build,binary}-arch; passing build flags, handling cross builds, etc.
> All of this would be much better done with dh (like the vast majority
> of packages in Debian do) -- it does know how to use cargo, etc.
> Likewise, there's no need to run install by hand.
I can't get it to work without manually telling dh_build to run cargo.
If someone can point me in the right direction of how to format my
debian/rules to build with cargo then put binaries, config files, and
such in the right place (there is nothing about that in Cargo.toml)
that would be very helpful.
Thank you so much Adam for helping me get some things straightened
out, the latest upload
https://mentors.debian.net/debian/pool/main/p/proton-caller/proton-caller_2.3.2-2.dsc
fixes all the problems you pointed out!
Bug#993552: RFS: proton-caller/2.3.2-1 [ITP] -- Run any Windows program through Proton
Hi!
On Thu, Sep 02, 2021 at 09:38:00PM -0400, Ben Westover wrote:
> * Package name: proton-caller
> Version : 2.3.2
> * URL : https://github.com/caverym/proton-caller/
> * License : GPL-3+
The license is MIT. Please correct debian/copyright.
> Description : Run any Windows program through Proton
> dget -x
> https://mentors.debian.net/debian/pool/main/p/proton-caller/proton-caller_2.3.2-1.dsc
The program depends on non-free Steam, thus it can't go into the main
archive. It is a nice specimen of a "contrib" package, though.
You can put it there by changing Section to contrib/XXX.
The package fails to build:
.
cargo build --release --locked
make: cargo: No such file or directory
`
Fix: Build-Depends: cargo
For a new package, there should be only one changelog entry (unless the
package already exists in a repository used by actual other people).
The long descriptions really should be longer than one line. It'd be nice
if you could write something more what is it good for (as I understand,
it's an equivalent to "wine freecell.exe"), what's the diff from Wine, etc.
An upload to Debian must be targetted at "unstable" or "experimental"
(other options being irrelevant for now), you currently have it set to
"UNRELEASED".
debian/rules is missing a lot of functionality: mandatory targets like
{build,binary}-arch; passing build flags, handling cross builds, etc.
All of this would be much better done with dh (like the vast majority
of packages in Debian do) -- it does know how to use cargo, etc.
Likewise, there's no need to run install by hand.
*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*
I won't continue the review -- I'll leave sponsoring this package to
someone with adequate knowledge of rust/cargo, which I lack.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ If you ponder doing what Jesus did, remember than flipping tables
⢿⡄⠘⠷⠚⠋⠀ and chasing people with a whip is a prime choice.
⠈⠳⣄
Bug#993552: RFS: proton-caller/2.3.2-1 [ITP] -- Run any Windows program through Proton
Package: sponsorship-requests Severity: wishlist X-Debbugs-Cc: kwestover...@gmail.com Dear mentors, I am looking for a sponsor for my package "proton-caller": * Package name: proton-caller Version : 2.3.2 Upstream Author : Ben Westover * URL : https://github.com/caverym/proton-caller/ * License : GPL-3+ Programming Lang: Rust Description : Run any Windows program through Proton It builds those binary packages: proton-caller - Run any Windows program through Proton To access further information about this package, please visit the following URL: https://mentors.debian.net/package/proton-caller/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/p/proton-caller/proton-caller_2.3.2-1.dsc Regards, -- Ben Westover
