Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian....@packages.debian.org
Usertags: pu


[ Reason ]
Pam has a bug where because of a syntax error in postinst, the upgrade fails if 
a systemd unit fails to restart.
This has been fixed in unstable, and I'd like to backport the fix.
I'll upload as soon as I test on bullseye; I'm sure it will be fine since it's 
the same patch as unstable, but for an essential package I want to be sure.

[ Impact ]

Without this update, pam fails to upgrade if one of the services that
is restarted fails to restart on a system using systemd as pid 1.

[ Tests ]

I constructed a case where a unit failed to restart on the unstable code, 
confirmed it failed before the update and confirmed it worked after the update.
Need to do the same on bullseye before uploading.

[ Risks ]

Low risk because this is an obvious fix to a failure path.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]

diff --git a/debian/changelog b/debian/changelog
index dee3f32b..8d9b0773 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+pam (1.4.0-9+deb11u1) bullseye; urgency=medium
+
+  * Fix syntax error in libpam0g.postinst when a systemd unit fails,
+    Closes: #992538
+
+
+ -- Sam Hartman <hartm...@debian.org>  Thu, 26 Aug 2021 13:11:23 -0600
+
 pam (1.4.0-9) unstable; urgency=medium
 
   * Revert prefer the multiarch path from 1.4.0-8: It turns out that
diff --git a/debian/libpam0g.postinst b/debian/libpam0g.postinst
index 396b35ca..6279f684 100644
--- a/debian/libpam0g.postinst
+++ b/debian/libpam0g.postinst
@@ -60,7 +60,7 @@ if test -d /run/systemd/system; then
         if systemctl try-restart $1; then
             :
         else
-            failed = "$failed $1"
+            failed="$failed $1"
         fi
     }
 else # not systemd

Reply via email to