Source: xnee
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The example simple_bash.sh embeds either /bin/bash or /bin/sh depending
on what the /bin/sh symlink points to:

  
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xnee.html

  /usr/share/doc/cnee/examples/simple_bash.sh

  #!·/bin/bash
vs.
  #!·/bin/sh

The attached patch fixes this by hard-coding to use /bin/bash, instead
of the Makefile BASH variable.

There are still other outstanding issues affecting the reproducibility
of xnee, but this should help reduce the differences to troubleshoot the
remaining issues.

Thanks for maintaining xnee!

live well,
  vagrant
From 603e131203b5f06141920ee8931121c159dc02e7 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Tue, 5 Oct 2021 00:31:10 +0000
Subject: [PATCH] examples/Makefile.am: Patch to hard-code path to bash.

When /bin/sh is a symlink to bash, the value of the BASH variable gets
set to /bin/sh, but /bin/sh may not always point to bash on the
running system.

https://tests.reproducible-builds.org/debian/issues/unstable/bin_sh_is_bash_issue.html
---
 examples/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/Makefile.am b/examples/Makefile.am
index c08a110..7ea6bf8 100644
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -6,7 +6,7 @@ pkgdatadir=$(datadir)/xnee/
 CLEAN_FILES=simple_bash.sh
 
 simple_bash.sh: simple_bash.sh.in1
-	echo "#!" "$(BASH)"                     > simple_bash.sh
+	echo "#!" "/bin/bash"                   > simple_bash.sh
 	echo " "                               >> simple_bash.sh 
 	echo " "                               >> simple_bash.sh 
 	echo "if [ -f ${bindir}/bin/cnee ]"    >> simple_bash.sh 
-- 
2.33.0

Attachment: signature.asc
Description: PGP signature

Reply via email to