Source: minia
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: kernel
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The kernel version is embedded in /usr/bin/minia which cause
reproducibility issues.
  
  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/minia.html

  Linux-5.14.0-0.bpo.2-amd64
vs.
  Linux-5.10.0-9-amd64

The attached patch fixes this by using CMAKE_SYSTEM_NAME instead of
CMAKE_SYSTEM in src/build_info.hpp.in.


With this patch applied, minia should become reproducible on
tests.reproducible-builds.org.


Thanks for maintaining minia!


live well,
  vagrant
From c0192d2eabddacfc3c728b930215094558799880 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Wed, 3 Nov 2021 21:11:32 +0000
Subject: [PATCH] build_info.hpp.in: Patch to use CMAKE_SYSTEM_NAME instead
 of CMAKE_SYSTEM.

CMAKE_SYSTEM captures the kernel version, which can reasonably vary
between builds. Use CMAKE_SYSTEM_NAME instead, which does not include
the version.

https://tests.reproducible-builds.org/debian/issues/unstable/captures_kernel_version_via_CMAKE_SYSTEM_issue.html
---
 src/build_info.hpp.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/build_info.hpp.in b/src/build_info.hpp.in
index d77e20c..f570b22 100644
--- a/src/build_info.hpp.in
+++ b/src/build_info.hpp.in
@@ -23,4 +23,4 @@
 #define STR_MINIA_VERSION     "${gatb-tool-version}"
 #define STR_MINIA_COMPILATION_FLAGS   "${gatb-core-flags}"
 #define STR_MINIA_COMPILER            "${CMAKE_C_COMPILER}  (${CMAKE_CXX_COMPILER_VERSION})"
-#define STR_MINIA_OPERATING_SYSTEM    "${CMAKE_SYSTEM}"
+#define STR_MINIA_OPERATING_SYSTEM    "${CMAKE_SYSTEM_NAME}"
-- 
2.33.1

Attachment: signature.asc
Description: PGP signature

Reply via email to