Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
On Thu 2022-06-16 20:37:24 +0200, Carsten Schoenert wrote: > Will do this the next time I import a new upstream version, but my guess > is we can simply remove them now. Sounds like a good plan to me. Thanks again for doing this work, Carsten. I'm running thunderbird from experimental right now, and I haven't noticed any new problems with it so far. --dkg signature.asc Description: PGP signature
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
Hi Daniel, Am 15.06.22 um 19:58 schrieb Daniel Kahn Gillmor: On Wed 2022-06-15 18:04:09 +0200, Carsten Schoenert wrote: 2) What is needed to modify in the upstream configure script voodoo so its possible to use the configure options --with-system-botan --with-system-bz2 --with-system-jsonc Is it possible that these three flags aren't relevant any longer *because* we're using the system rnp? in comm/third_party/openpgp.configure i see the tests for those options bracketed within a block that begins: - with only_when(in_tree_librnp): - And i don't see those options anywhere else in the codebase. thanks for digging into this, I wasn't in the mood to go down that road until now. :-) Was happy to get a successful build after months. It would make sense if those options shouldn't be supplied at all any longer when we're using the system rnp, and i'd expect that the updated thunderbird wouldn't acquire any new dependencies from omitting those changes. I'd guess that you can probably also remove the build-deps on: libbotan-2-dev libbz2-dev libjson-c-dev If your analysis is correct than we don't want these build dependencies any more, right. I've simply forgotten to at least comment these out for now. The next beta is around the corner to get clear on this. :-) And the build should complete without an error, but i haven't tested it myself. Will do this the next time I import a new upstream version, but my guess is we can simply remove them now. -- Regards Carsten
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
On Wed 2022-06-15 18:04:09 +0200, Carsten Schoenert wrote: > 2) What is needed to modify in the upstream configure script voodoo so > its possible to use the configure options > > --with-system-botan > --with-system-bz2 > --with-system-jsonc Is it possible that these three flags aren't relevant any longer *because* we're using the system rnp? in comm/third_party/openpgp.configure i see the tests for those options bracketed within a block that begins: - with only_when(in_tree_librnp): - And i don't see those options anywhere else in the codebase. It would make sense if those options shouldn't be supplied at all any longer when we're using the system rnp, and i'd expect that the updated thunderbird wouldn't acquire any new dependencies from omitting those changes. I'd guess that you can probably also remove the build-deps on: libbotan-2-dev libbz2-dev libjson-c-dev And the build should complete without an error, but i haven't tested it myself. Thank you very much for working on this, Carsten! --dkg signature.asc Description: PGP signature
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
Hi Daniel, Am 15.06.22 um 17:12 schrieb Daniel Kahn Gillmor: after again months of waiting for some typical build tools and a lot of try and errors attempts I'm now able to build the current beta version of Thunderbird (102.0~b4) together with the system package of librnp-dev. that's great news! thanks for doing this. uploaded to experimental just right now. The downside is that this requires currently the usage of the internal version of botan, bz2 and jsonc. I've no kowledge if upstream has plans to reenable the usage of system packages for these tools, maybe it's also just a misconfiguration of the buildsystem. Ugh, that doesn't sound so reasonable. I'd expect those libraries to be internal to librnp, and not directly exposed to the rest of thunderbird. so they shouldn't be related to the build process at all, afaict. Preparing the current version did make a lot of headaches. :-) So far I've experienced we need to use the option --enable-av1 now to get a recent Thunderbird, otherwise the build failed with an error messages that make not really sense to me. 0:12.47 js/src> updating cache ./config.cache 0:12.47 js/src> creating ./config.data 0:12.48 Creating config.status 0:12.67 Reticulating splines... 0:12.97 0:00.33 File already read. Skipping: /build/thunderbird-98.0~b2/intl/components/moz.build 0:13.18 0:00.53 File already read. Skipping: /build/thunderbird-98.0~b2/gfx/angle/targets/angle_common/moz.build 0:15.20 Traceback (most recent call last): 0:15.20 File "/build/thunderbird-98.0~b2/configure.py", line 349, in 0:15.20 sys.exit(main(sys.argv)) 0:15.20 File "/build/thunderbird-98.0~b2/configure.py", line 161, in main 0:15.20 return config_status(config) 0:15.20 File "/build/thunderbird-98.0~b2/configure.py", line 300, in config_status 0:15.20 return config_status(args=[], **sanitized_config) 0:15.20 File "/build/thunderbird-98.0~b2/python/mozbuild/mozbuild/config_status.py", line 162, in config_status 0:15.20 definitions = list(definitions) 0:15.20 File "/build/thunderbird-98.0~b2/python/mozbuild/mozbuild/frontend/emitter.py", line 179, in emit 0:15.20 objs = list(self._emit_libs_derived(contexts)) 0:15.20 File "/build/thunderbird-98.0~b2/python/mozbuild/mozbuild/frontend/emitter.py", line 261, in _emit_libs_derived 0:15.20 self._link_libraries(context, obj, variable, idl_sources) 0:15.20 File "/build/thunderbird-98.0~b2/python/mozbuild/mozbuild/frontend/emitter.py", line 378, in _link_libraries 0:15.20 self._link_library(context, obj, variable, path) 0:15.20 File "/build/thunderbird-98.0~b2/python/mozbuild/mozbuild/frontend/emitter.py", line 469, in _link_library 0:15.20 raise SandboxValidationError( 0:15.20 mozbuild.frontend.reader.SandboxValidationError: 0:15.20 == 0:15.20 FATAL ERROR PROCESSING MOZBUILD FILE 0:15.20 == 0:15.20 0:15.20 The error occurred while processing the following file or one of the files it includes: 0:15.20 0:15.20 /build/thunderbird-98.0~b2/media/ffvpx/libavcodec/moz.build 0:15.20 0:15.20 The error occurred when validating the result of the execution. The reported error is: 0:15.20 0:15.20 USE_LIBS contains "dav1d", which does not match any LIBRARY_NAME in the tree. 0:15.20 0:15.20 Building TB with AV1 support isn't something what I think is needed to have. :-) But well, the build configuration isn't something that is getting less complex over time. Have you reported this upstream at all? do you have examples of the build failures that happen when you use the system librnp that we could work through and post where upstream can see them? No, I haven't reported any issue upstream yet, I wanted first to have a basic working Thunderbird package for the current Beta versions. Unfortunately I often needed to wait in the past on the most bleeding edge Rust and Cargo stuff due the version dependencies. And now we are getting closer to the next ESR version of Thunderbird, a broader user base that can try out these version(s) is more helpful for Debian and to me as we can mostly work around some upstream issues. I see currently two main things we need to bring to upstream issue tracker. 1) Why we can't set --disable-av1 as before and the configure script is ending with an exit code of 1. 2) What is needed to modify in the upstream configure script voodoo so its possible to use the configure options --with-system-botan --with-system-bz2 --with-system-jsonc again. So if someone wants to play with these option there will be easily the build problem visible I've encountered in the past weeks and months on my side. -- Regards Carsten
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
Hi Carsten-- On Sun 2022-06-12 17:15:08 +0200, Carsten Schoenert wrote: > Am Sat, Mar 26, 2022 at 04:06:46PM -0400 schrieb Daniel Kahn Gillmor: >> I've just uploaded rnp 0.16.0 into debian unstable. According to >> https://bugzilla.mozilla.org/show_bug.cgi?id=1732809 the main >> development line of thunderbird now has a --with-system-rnp flag (but >> the 91esr series doesn't have it. >> >> So when new versions of thunderbird get built in debian (in experimental >> first, maybe?) please try to use --with-system-rnp. If you run into any >> reason why building against the system rnp isn't working, please don't >> hesitate to file bug reports against rnp and we'll sort them out. > > after again months of waiting for some typical build tools and a lot of > try and errors attempts I'm now able to build the current beta version > of Thunderbird (102.0~b4) together with the system package of > librnp-dev. that's great news! thanks for doing this. > The downside is that this requires currently the usage of the internal > version of botan, bz2 and jsonc. > > I've no kowledge if upstream has plans to reenable the usage of system > packages for these tools, maybe it's also just a misconfiguration of the > buildsystem. Ugh, that doesn't sound so reasonable. I'd expect those libraries to be internal to librnp, and not directly exposed to the rest of thunderbird. so they shouldn't be related to the build process at all, afaict. Have you reported this upstream at all? do you have examples of the build failures that happen when you use the system librnp that we could work through and post where upstream can see them? --dkg signature.asc Description: PGP signature
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
Control: tags -1 pending Hello Daniel, Am Sat, Mar 26, 2022 at 04:06:46PM -0400 schrieb Daniel Kahn Gillmor: > I've just uploaded rnp 0.16.0 into debian unstable. According to > https://bugzilla.mozilla.org/show_bug.cgi?id=1732809 the main > development line of thunderbird now has a --with-system-rnp flag (but > the 91esr series doesn't have it. > > So when new versions of thunderbird get built in debian (in experimental > first, maybe?) please try to use --with-system-rnp. If you run into any > reason why building against the system rnp isn't working, please don't > hesitate to file bug reports against rnp and we'll sort them out. after again months of waiting for some typical build tools and a lot of try and errors attempts I'm now able to build the current beta version of Thunderbird (102.0~b4) together with the system package of librnp-dev. The downside is that this requires currently the usage of the internal version of botan, bz2 and jsonc. I've no kowledge if upstream has plans to reenable the usage of system packages for these tools, maybe it's also just a misconfiguration of the buildsystem. Hopefully I can upload a first beta version of Thunderbird zu experimental soon. Regards Carsten
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
I've just uploaded rnp 0.16.0 into debian unstable. According to https://bugzilla.mozilla.org/show_bug.cgi?id=1732809 the main development line of thunderbird now has a --with-system-rnp flag (but the 91esr series doesn't have it. So when new versions of thunderbird get built in debian (in experimental first, maybe?) please try to use --with-system-rnp. If you run into any reason why building against the system rnp isn't working, please don't hesitate to file bug reports against rnp and we'll sort them out. thanks for all your work on thunderbird in debian! --dkg signature.asc Description: PGP signature
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
On Mon 2021-11-08 20:11:06 +0100, Carsten Schoenert wrote: > But I think it's a bit more complicated currently, a quick look into the > source shows me that the upstream build system doesn't support the usage > of an external librnp-dev package right now. > This needs to get addressed upstream I think so we can build against the > system library. Thanks, I've opened https://bugzilla.mozilla.org/show_bug.cgi?id=1740320 so that upstream is aware of the issue. --dkg signature.asc Description: PGP signature
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
Hi Daniel, Am 08.11.21 um 19:51 schrieb Daniel Kahn Gillmor: librnp has made it into debian testing (0.15.2-6 as of right now). I think thunderbird is currently building from an embedded copy of librnp. RNP Upstream has been collaborating nicely by fixing issues i've raised with them that highlight concerns in debian. It would be better if we could avoid the embedded code copy by building thunderbird against the debian librnp-dev package, and depending on librnp0. I would happily switch using a external (system) library librnp-dev which we could use while package build. But I think it's a bit more complicated currently, a quick look into the source shows me that the upstream build system doesn't support the usage of an external librnp-dev package right now. This needs to get addressed upstream I think so we can build against the system library. If you want to jump in here then feel to do so, I'm short on time for doing something like this in the near future. -- Regards Carsten
Bug#998848: thunderbird: please build against librnp-dev (and Depend: on librnp0) directly
Package: thunderbird Version: 1:78.14.0-1+b2 Control: affects -1 + librnp-dev librnp0 Hi Thunderbird devs-- librnp has made it into debian testing (0.15.2-6 as of right now). I think thunderbird is currently building from an embedded copy of librnp. RNP Upstream has been collaborating nicely by fixing issues i've raised with them that highlight concerns in debian. It would be better if we could avoid the embedded code copy by building thunderbird against the debian librnp-dev package, and depending on librnp0. Thanks for maintaining thunderbird in debian! Regards, --dkg signature.asc Description: PGP signature
