Source: yoshimi
Version: 2.2.0-1
Severity: normal
Tags: ftbfs, patch
User: debian-ri...@lists.debian.org
Usertags: riscv64

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512


Dear Maintainer,

The yoshimi packages has a ftbfs issue on riscv64 arch:

```
[ 94%] Building CXX object 
LV2_Plugin/CMakeFiles/yoshimi_lv2.dir/MasterMiscUI.cpp.o
cd /<<PKGBUILDDIR>>/obj-riscv64-linux-gnu/LV2_Plugin && /usr/bin/c++ -DGUI_FLTK 
-DHAVE_ALSA -DJACK_LATENCY -DJACK_SESSION -DMIN_CONFIG_MAJOR=2 
-DMIN_CONFIG_MINOR=0 -DYOSHIMI=\"yoshimi\" -DYOSHIMI_LV2_PLUGIN=1 
-DYOSHI_FIFO_DIR=\"\" -Dyoshimi_lv2_EXPORTS 
-I/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu/LV2_Plugin 
-I/<<PKGBUILDDIR>>/src/LV2_Plugin -I/usr/include/uuid -I/usr/include/freetype2 
-I/usr/include/libpng16 -I/usr/lib/fltk -I/usr/include/cairo 
-I/usr/include/glib-2.0 -I/usr/lib/riscv64-linux-gnu/glib-2.0/include 
-I/usr/include/pixman-1 -I/<<PKGBUILDDIR>>/src -ffast-math -fomit-frame-pointer 
-g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -fPIC   
-std=gnu++14 -Wall -D'YOSHIMI_VERSION="2.2.0"' -D'BASE_INSTALL_DIR="/usr"' 
-fvisibility=hidden -std=gnu++14 -MD -MT 
LV2_Plugin/CMakeFiles/yoshimi_lv2.dir/MasterMiscUI.cpp.o -MF 
CMakeFiles/yoshimi_lv2.dir/MasterMiscUI.cpp.o.d -o 
CMakeFiles/yoshimi_lv2.dir/MasterMiscUI.cpp.o -c 
/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu/LV2_Plugin/MasterMiscUI.cpp
CMakeFiles/yoshimi.dir/Params/PADnoteParameters.cpp.o: in function 
`std::__atomic_base<bool>::compare_exchange_strong(bool&, bool, 
std::memory_order, std::memory_order)':
/usr/include/c++/11/bits/basic_string.h:239: undefined reference to 
`__atomic_compare_exchange_1'
/usr/bin/ld: CMakeFiles/yoshimi.dir/Params/PADnoteParameters.cpp.o: in function 
`std::__atomic_base<bool>::compare_exchange_strong(bool&, bool, 
std::memory_order, std::memory_order)':
/usr/include/c++/11/bits/atomic_base.h:571: undefined reference to 
`__atomic_compare_exchange_1'
[ 95%] Building CXX object 
LV2_Plugin/CMakeFiles/yoshimi_lv2.dir/ParametersUI.cpp.o
cd /<<PKGBUILDDIR>>/obj-riscv64-linux-gnu/LV2_Plugin && /usr/bin/c++ -DGUI_FLTK 
-DHAVE_ALSA -DJACK_LATENCY -DJACK_SESSION -DMIN_CONFIG_MAJOR=2 
-DMIN_CONFIG_MINOR=0 -DYOSHIMI=\"yoshimi\" -DYOSHIMI_LV2_PLUGIN=1 
-DYOSHI_FIFO_DIR=\"\" -Dyoshimi_lv2_EXPORTS 
-I/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu/LV2_Plugin 
-I/<<PKGBUILDDIR>>/src/LV2_Plugin -I/usr/include/uuid -I/usr/include/freetype2 
-I/usr/include/libpng16 -I/usr/lib/fltk -I/usr/include/cairo 
-I/usr/include/glib-2.0 -I/usr/lib/riscv64-linux-gnu/glib-2.0/include 
-I/usr/include/pixman-1 -I/<<PKGBUILDDIR>>/src -ffast-math -fomit-frame-pointer 
-g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -fPIC   
-std=gnu++14 -Wall -D'YOSHIMI_VERSION="2.2.0"' -D'BASE_INSTALL_DIR="/usr"' 
-fvisibility=hidden -std=gnu++14 -MD -MT 
LV2_Plugin/CMakeFiles/yoshimi_lv2.dir/ParametersUI.cpp.o -MF 
CMakeFiles/yoshimi_lv2.dir/ParametersUI.cpp.o.d -o 
CMakeFiles/yoshimi_lv2.dir/ParametersUI.cpp.o -c 
/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu/LV2_Plugin/ParametersUI.cpp
collect2: error: ld returned 1 exit status
make[3]: *** [CMakeFiles/yoshimi.dir/build.make:1526: yoshimi] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:106: CMakeFiles/yoshimi.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
```

The full buildd log is here:

https://buildd.debian.org/status/fetch.php?pkg=yoshimi&arch=riscv64&ver=2.2.0-1&stamp=1653033364&raw=0

The patch attached is to fix the issue and it seems that it is ok 
to build on riscv64 machine localy.

```
Build Architecture: riscv64
Build Type: binary
Build-Space: 1144556
Build-Time: 5377
Distribution: unstable
Host Architecture: riscv64
Install-Time: 128
Job: /home/vimer/05/29_yoshimi/yoshimi_2.2.0-1.dsc
Lintian: warn
Machine Architecture: riscv64
Package: yoshimi
Package-Time: 5618
Source-Version: 2.2.0-1
Space: 1144556
Status: successful
Version: 2.2.0-1
```
Please consider to apply it in next upload, thank you~

BR,
Bo


-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEIcmhjYVTlmab0tjp+RVP3hQ+S68FAmKLS0gACgkQ+RVP3hQ+
S6/LLRAAgqE0RA2BYOG8yaEYJjozhL6RqHMPpiANvdu7qCcJZhqLk+zXgLvLB/Od
YXZ/N9pMV/OgptmUYA48dlXe6HzC6J4evPSJtR1kx1o7Sn4HiCdJZTWpZqSnfTme
HC4Gh9viqjyI4/B1Hw9nECOML/TzonlBJTxPIGOV/6Z2KIqpZjMkLiCnQ/pK8n3p
sGOdCR7NUmasnZD0E85mslR+pUhAd4Z2uH3k/aJBE/XV+NvdPmGeAbfu028Mwxqr
GV9puw4TTHja+wClFzkEaVA/u+H1T31pBnFM/mLIVQylCHjP36kEEYzPvQareOOl
baguTRBfvfiXpw8cSx3D943DbLNOuzCPT8kjt9Y+1F1wZ7vrzBX4cw0B47Afee4O
RTGDCuU11nkd1WBnfYIFGYGyfB+QVzXh3SiONjbxjqVTrVhEe5ErgdSOKhIJyQ51
IdZXJS/H+LMWrkU95Xr7DNj9PXpHGdbf9xuypYRcV7q4oR8vU+9IaZkq1lDz1oNf
gNQ2qorh0wksrn4Qzdt1U+0QCmHaFMUYm8kocg0Y1LOBPoobaQU2fGGfac5bAhe4
dmT1PqOu6nU5xp3hnVpdgsxbxrQZpbpda1QCero6evnBSrbGBZGOoIyTjT0U7i/Q
b3t9Pq16p2xKzGW+UiEzlmEMruaF2aikTJ7brI7tKnpk4NlI1uA=
=tnlK
-----END PGP SIGNATURE-----
fix ftbfs on riscv64

Bo YU <tsu.y...@gmail.com>
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -143,6 +143,7 @@
 
 find_package (PkgConfig REQUIRED)
 
+set(THREADS_PREFER_PTHREAD_FLAG ON)
 find_package(Threads REQUIRED)
 
 check_c_source_compiles (

Reply via email to