Bug#1046804: fixed in tasksh 1.2.0-2
On Fri, Dec 26, 2025 at 02:07:10PM +0100, Andreas Tille wrote: > https://salsa.debian.org/tasktools-team/tasksh/-/commit/2f729aac9a4046a9238006818c91870dcadcf630 > > I admit I would not see some immediate reason to upload for this change > in principle. However, given Iain's response to rather orphan the package > I'll upload your patch. Ok, I didn't see any reason for another upload either, but since you found a good excuse to do so, that's fine as well! While we are at it: Lintian (rightfully) flags as a warning every orphaned package in a salsa team different than the "debian" team. I know there is a section in "salsa support" where people put issues like "please move this from here to there". Is there any other way to do that without bothering salsa admins? (For very recently orphaned packages like "tasksh" there is still some hope that the new maintainer is also in the team, my question is mainly for packages orphaned several years ago). Thanks.
Bug#1046804: fixed in tasksh 1.2.0-2
Hi Santiago, Am Fri, Dec 26, 2025 at 01:02:30PM +0100 schrieb Santiago Vila: > >* d/rules: Fix clean target > > Closes: #1046804 > > As I'm currently looking at those bugs, I'm always curious about > how other people fix them. > > In this package the file cmake.h has not any "precious" status, > and it does not really need to be preserved. I absolutely agree that simply removing would be a valid means to solve this bug. > The package builds the same regardless of its contents, so in this > case you can just remove the file before the build starts, as in the > attached patch (where we use debian/clean). https://salsa.debian.org/tasktools-team/tasksh/-/commit/2f729aac9a4046a9238006818c91870dcadcf630 I admit I would not see some immediate reason to upload for this change in principle. However, given Iain's response to rather orphan the package I'll upload your patch. > Thanks. You are welcome Andreas. > commit 927cdecc25ddf1afbc71be28bb2caa46e36236d9 > Author: Santiago Vila > Date: Fri Dec 26 12:50:00 2025 +0100 > > Fix clean target in a more simple way. > > diff --git a/debian/clean b/debian/clean > new file mode 100644 > index 000..044d064 > --- /dev/null > +++ b/debian/clean > @@ -0,0 +1 @@ > +cmake.h > diff --git a/debian/rules b/debian/rules > index 2f87616..d8309f6 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -4,11 +4,3 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all > > %: > dh $@ > - > -override_dh_auto_configure: > - cp -a cmake.h cmake.h~ > - dh_auto_configure > - > -override_dh_clean: > - if [ -e cmake.h~ ] ; then mv cmake.h~ cmake.h ; fi > - dh_clean -- https://fam-tille.de
Bug#1046804: fixed in tasksh 1.2.0-2
Hello Andreas. >* d/rules: Fix clean target > Closes: #1046804 As I'm currently looking at those bugs, I'm always curious about how other people fix them. In this package the file cmake.h has not any "precious" status, and it does not really need to be preserved. The package builds the same regardless of its contents, so in this case you can just remove the file before the build starts, as in the attached patch (where we use debian/clean). Thanks.commit 927cdecc25ddf1afbc71be28bb2caa46e36236d9 Author: Santiago Vila Date: Fri Dec 26 12:50:00 2025 +0100 Fix clean target in a more simple way. diff --git a/debian/clean b/debian/clean new file mode 100644 index 000..044d064 --- /dev/null +++ b/debian/clean @@ -0,0 +1 @@ +cmake.h diff --git a/debian/rules b/debian/rules index 2f87616..d8309f6 100755 --- a/debian/rules +++ b/debian/rules @@ -4,11 +4,3 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all %: dh $@ - -override_dh_auto_configure: - cp -a cmake.h cmake.h~ - dh_auto_configure - -override_dh_clean: - if [ -e cmake.h~ ] ; then mv cmake.h~ cmake.h ; fi - dh_clean
