Bug#1048099: ruby-rubocop-ast: Fails to build source after successful build

[Santiago Vila]

tags 1048099 patch
severity 1048099 normal
reopen 1048099
thanks

Simon Quigley wrote:

> This bug is fixed in 1.49.0-1. If you can still reproduce the failure, please 
> provide a build log.

It's not fixed and it still fails in the same way it was reported in 2023:

Package: ruby-rubocop-ast
Version: 1.49.0-1
[...]
dpkg-source: info: local changes detected, the modified files are:
 ruby-rubocop-ast-1.49.0/lib/rubocop/ast/node_pattern/parser.output
 ruby-rubocop-ast-1.49.0/lib/rubocop/ast/node_pattern/parser.racc.rb
 ruby-rubocop-ast-1.49.0/spec/examples.txt
dpkg-source: error: aborting due to unexpected upstream changes, see 
/tmp/ruby-rubocop-ast_1.49.0-1.diff.0kURtw

Full build log here:

https://people.debian.org/~sanvila/build-logs/ftbfs-source-after-build/


Note that dpkg-source does not report everything which is wrong:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1126665

so after an attempt to fix the issue it is usually a good idea to
retest again to be sure. However, I believe this does not apply here
as I could not find any attempt at fixing the issue in salsa.

Anyway, the attached patch works for me.

Thanks.
commit f15767d6be4b9ac6396cc71489d1aa146c2028fc
Author: Santiago Vila 
Date:   Sun Mar 1 23:30:00 2026 +0100

Fix clean target. Closes: #1048099.

diff --git a/debian/clean b/debian/clean
index 21c5272..07e8da5 100644
--- a/debian/clean
+++ b/debian/clean
@@ -1,2 +1,5 @@
-lib/rubocop/ast/node_pattern/parser.racc.rc
 lib/rubocop/ast/node_pattern/lexer.rex.rb
+lib/rubocop/ast/node_pattern/parser.output
+lib/rubocop/ast/node_pattern/parser.racc.rb
+lib/rubocop/ast/node_pattern/parser.racc.rc
+spec/examples.txt

Bug#1048099: ruby-rubocop-ast: Fails to build source after successful build

[Lucas Nussbaum]

Source: ruby-rubocop-ast
Version: 1.24.0-2
Severity: minor
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian...@lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<> && runuser -u user42 -- dpkg-buildpackage --sanitize-env 
> -us -uc -rfakeroot -S
> 
> 
> dpkg-buildpackage: info: source package ruby-rubocop-ast
> dpkg-buildpackage: info: source version 1.24.0-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Lucas Kanashiro 
> 
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --buildsystem=ruby --with ruby
>dh_auto_clean -O--buildsystem=ruby
>   dh_ruby --clean
> W: XS-Ruby-Versions is deprecated, and will be ignored
>dh_autoreconf_clean -O--buildsystem=ruby
>dh_clean -O--buildsystem=ruby
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building ruby-rubocop-ast using existing 
> ./ruby-rubocop-ast_1.24.0.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  ruby-rubocop-ast-1.24.0/lib/rubocop/ast/node_pattern/parser.output
>  ruby-rubocop-ast-1.24.0/lib/rubocop/ast/node_pattern/parser.racc.rb
>  ruby-rubocop-ast-1.24.0/spec/examples.txt
> dpkg-source: error: aborting due to unexpected upstream changes, see 
> /tmp/ruby-rubocop-ast_1.24.0-2.diff.lXvpL8
> dpkg-source: info: Hint: make sure the version in debian/changelog matches 
> the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source 
> --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<> && runuser -u user42 -- dpkg-buildpackage 
> --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/ruby-rubocop-ast_1.24.0-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.