Bug#1089335: gemdropx: Supporting rootless builds by default

2024-12-31 Thread Niels Thykier

Control: tags -1 patch

On Sat, 7 Dec 2024 20:15:08 +0100 Niels Thykier  wrote:

Source: gemdropx
Version: 0.9-9
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
gemdropx failed to rebuild.

Log Summary:
---
[...]



Hi

Please see attached as a patch.

I intend to NMU to make progress on the MBF if I do not hear from you on 
this. It would help me if you either uploaded this soon or approved the 
NMU (enabling me to skip the delay). Thanks in advance.


Best regards,
Niels

diff -Nru gemdropx-0.9/debian/changelog gemdropx-0.9/debian/changelog
--- gemdropx-0.9/debian/changelog   2023-01-06 13:30:08.0 +0100
+++ gemdropx-0.9/debian/changelog   2024-12-31 15:09:35.0 +0100
@@ -1,3 +1,11 @@
+gemdropx (0.9-9.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove requirement for root when building the package.
+(Closes: #1089335)
+
+ -- Niels Thykier   Tue, 31 Dec 2024 14:09:35 +
+
 gemdropx (0.9-9) unstable; urgency=medium
 
   [ Debian Janitor ]
diff -Nru gemdropx-0.9/debian/control gemdropx-0.9/debian/control
--- gemdropx-0.9/debian/control 2023-01-05 17:52:07.0 +0100
+++ gemdropx-0.9/debian/control 2024-12-31 15:08:52.0 +0100
@@ -5,6 +5,7 @@
 Build-Depends: debhelper-compat (= 13),
libsdl-mixer1.2-dev,
libsdl1.2-dev
+Rules-Requires-Root: no
 Standards-Version: 4.6.2
 Vcs-Browser: https://salsa.debian.org/debian/gemdropx
 Vcs-Git: https://salsa.debian.org/debian/gemdropx.git
diff -Nru gemdropx-0.9/debian/rules gemdropx-0.9/debian/rules
--- gemdropx-0.9/debian/rules   2023-01-05 17:35:58.0 +0100
+++ gemdropx-0.9/debian/rules   2024-12-31 15:08:43.0 +0100
@@ -14,7 +14,7 @@
dh_auto_build --  DEB_CFLAGS="$(CFLAGS)" SOUND=YES JOY=YES 
DATA_PREFIX=/usr/share/games/gemdropx
 
 override_dh_auto_install:
-   dh_auto_install
-   install -g root -o root -m 644 data/images/gemdropx-icon.xpm \
+   dh_auto_install -- installbin="install -m 755" installdat="install -m 
644"
+   install -m 644 data/images/gemdropx-icon.xpm \
$(CURDIR)/debian/gemdropx/usr/share/pixmaps/
install -m 644 debian/gemdropx.desktop 
$(CURDIR)/debian/gemdropx/usr/share/applications


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1089335: gemdropx: Supporting rootless builds by default

2024-12-07 Thread Niels Thykier

Source: gemdropx
Version: 0.9-9
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
gemdropx failed to rebuild.

Log Summary:
---
[...]
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/disc.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/dot.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/explode0.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/explode1.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/explode2.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/explode3.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/fuji.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/gemdropx-icon.xpm': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/happy.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/left-mask.xbm': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/left.xbm': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/level.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/lines.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/need.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/nothing-mask.xbm': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/nothing.xbm': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/numbers.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/patience.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/paused.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/right-mask.xbm': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/right.xbm': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/sad.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/score.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/stopwatch.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/title.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/triangle.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/uhoh.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/warning.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/warning1.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/warning2.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/warning3.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/warning4.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/wildcard.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/win1.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games/gemdropx/images/win2.bmp': 
Operation not permitted
install: cannot change ownership of 
'/<>/debian/gemdropx/usr/share/games