Bug#1089417: pptp-linux: Supporting rootless builds by default

2024-12-08 Thread Niels Thykier

Christoph Biedl:

Control: tags 1089417 confirmed pending

[...]

The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1029897.gz


FWIW, that is 404. While I don't need the log, it still might be
confusing for other people.

 Christoph


Thanks for the heads up. I generated the link wrong indeed.

The real name was [NAME]_[VERSION].[ID].build.gz. I have fixed it for 
next time. Unfortunately, I have sent out the bulk of the bugs for this 
round.


Best regards,
Niels



OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1089417: pptp-linux: Supporting rootless builds by default

2024-12-07 Thread Christoph Biedl
Control: tags 1089417 confirmed pending

Niels Thykier wrote...

> Source: pptp-linux
> Version: 1.10.0-1
> Severity: important
(...)
> During a test rebuild for building packages with
> `Rules-Requires-Root: no` as the default in `dpkg`,
> pptp-linux failed to rebuild.

Indeed, fix is simple, will take care of that soon.

> The above is just how the build ends and not necessarily the most
> relevant part. If required, the full build log is available here:
>
> https://people.debian.org/~nthykier/rrr-no-as-default/logs/1029897.gz

FWIW, that is 404. While I don't need the log, it still might be
confusing for other people.

Christoph


signature.asc
Description: PGP signature


Bug#1089417: pptp-linux: Supporting rootless builds by default

2024-12-07 Thread Niels Thykier

Source: pptp-linux
Version: 1.10.0-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
pptp-linux failed to rebuild.

Log Summary:
---
[...]
gcc -g -O2 -Werror=implicit-function-declaration 
-ffile-prefix-map=/<>=. -fstack-protector-strong 
-fstack-clash-protection -Wformat -Werror=format-security 
-mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
orckit_quirks.o orckit_quirks.c

util.c: In function ‘_log’:
util.c:29:34: warning: ‘%s’ directive output may be truncated writing up 
to 255 bytes into a region of size 245 [-Wformat-truncation=]

   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
  |  ^
   30 |  log_string, label, func, file, line, buf); \
  |   ~~~
util.c:47:5: note: in expansion of macro ‘MAKE_STRING’
   47 | MAKE_STRING("log");
  | ^~~
util.c:29:52: note: format string is defined here
   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
  |^~
In file included from /usr/include/stdio.h:970,
 from util.c:7:
In function ‘snprintf’,
inlined from ‘_log’ at util.c:47:5:
/usr/include/aarch64-linux-gnu/bits/stdio2.h:68:10: note: 
‘__builtin___snprintf_chk’ output 12 or more bytes (assuming 267) into a 
destination of size 256
   68 |   return __builtin___snprintf_chk (__s, __n, 
__USE_FORTIFY_LEVEL - 1,
  | 
^~~~

   69 |__glibc_objsize (__s), __fmt,
  |~
   70 |__va_arg_pack ());
  |~
util.c: In function ‘_warn’:
util.c:29:34: warning: ‘%s’ directive output may be truncated writing up 
to 255 bytes into a region of size 244 [-Wformat-truncation=]

   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
  |  ^
   30 |  log_string, label, func, file, line, buf); \
  |   ~~~
util.c:54:5: note: in expansion of macro ‘MAKE_STRING’
   54 | MAKE_STRING("warn");
  | ^~~
util.c:29:52: note: format string is defined here
   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
  |^~
In function ‘snprintf’,
inlined from ‘_warn’ at util.c:54:5:
/usr/include/aarch64-linux-gnu/bits/stdio2.h:68:10: note: 
‘__builtin___snprintf_chk’ output 13 or more bytes (assuming 268) into a 
destination of size 256
   68 |   return __builtin___snprintf_chk (__s, __n, 
__USE_FORTIFY_LEVEL - 1,
  | 
^~~~

   69 |__glibc_objsize (__s), __fmt,
  |~
   70 |__va_arg_pack ());
  |~
pptp_ctrl.c: In function ‘randci’:
pptp_ctrl.c:336:17: warning: ignoring return value of ‘read’ declared 
with attribute ‘warn_unused_result’ [-Wunused-result]

  336 | read(fd, &i, 2);
  | ^~~
gcc -g -O2 -Werror=implicit-function-declaration 
-ffile-prefix-map=/<>=. -fstack-protector-strong 
-fstack-clash-protection -Wformat -Werror=format-security 
-mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2  -c -o 
pqueue.o pqueue.c

util.c: In function ‘_fatal’:
util.c:29:34: warning: ‘%s’ directive output may be truncated writing up 
to 255 bytes into a region of size 243 [-Wformat-truncation=]

   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
  |  ^
   30 |  log_string, label, func, file, line, buf); \
  |   ~~~
util.c:62:5: note: in expansion of macro ‘MAKE_STRING’
   62 | MAKE_STRING("fatal");
  | ^~~
util.c:29:52: note: format string is defined here
   29 | snprintf(string, sizeof(string), "%s %s[%s:%s:%d]: %s", \
  |^~
In function ‘snprintf’,
inlined from ‘_fatal’ at util.c:62:5:
/usr/include/aarch64-linux-gnu/bits/stdio2.h:68:10: note: 
‘__builtin___snprintf_chk’ output 14 or more bytes (assuming 269) into a 
destination of size 256
   68 |   return __builtin___snprintf_chk (__s, __n, 
__USE_FORTIFY_LEVEL - 1,
  | 
^~~