Bug#1089440: sreview: Supporting rootless builds by default
Hi Niels, On Sat, Jan 04, 2025 at 11:19:50AM +0100, Niels Thykier wrote: > On Sat, 4 Jan 2025 10:53:34 +0100 Niels Thykier wrote: > > [...] > > > > No problem from my PoV; I will not NMU it for now. > > > > FYI, I am hoping to push for the default in dpkg to change soon and that > > may occur before FOSDEM. The if/when that happens is a decision for the > > RT that I am stilling waiting for a reply on. Though it is also possible > > that they decline my request to change the default for Trixie at which > > point I expect FOSDEM 2025 will happen first. :) > > > > Lets cross that bridge when (or if) we get there and it happens before > > FOSDEM. > > > > Best regards, > > Niels > > > > Hi, > > The transition has moved to the endgame and the bugs are now RC with risk of > auto-removals (that is, "we have come to the bridge"). In sreview's case, it > is now a regular FTBFS bug in sid. The auto-removal can be stalled by > pinging the bug about once per week until the upload after FOSDEM. I did see the messages to -devel, but thanks :) > An alternative that I am mentioning now in case it is helpful. A minimal > `Rules-Requires-Root: binary-targets` would take sreview out the > auto-removal zone. This would have the advantage of having no regression > risk caused by the change, since we would just be requesting the previous > status quo enabling you to come back to the rootless fix at a later time. > However, it is still an upload, so it is not immediately obvious to me that > will avoid your core concern. If it is and a NMU will be helpful, just say > the word. But if I do not hear from you, I assume any action from me on > sreview would be unhelpful. Given the changed default, as per my message to Holger, I will try to upload something useful in the next few days. Thanks, -- w@uter.{be,co.za} wouter@{grep.be,fosdem.org,debian.org} I will have a Tin-Actinium-Potassium mixture, thanks.
Bug#1089440: sreview: Supporting rootless builds by default
On Sat, 4 Jan 2025 10:53:34 +0100 Niels Thykier wrote: [...] No problem from my PoV; I will not NMU it for now. FYI, I am hoping to push for the default in dpkg to change soon and that may occur before FOSDEM. The if/when that happens is a decision for the RT that I am stilling waiting for a reply on. Though it is also possible that they decline my request to change the default for Trixie at which point I expect FOSDEM 2025 will happen first. :) Lets cross that bridge when (or if) we get there and it happens before FOSDEM. Best regards, Niels Hi, The transition has moved to the endgame and the bugs are now RC with risk of auto-removals (that is, "we have come to the bridge"). In sreview's case, it is now a regular FTBFS bug in sid. The auto-removal can be stalled by pinging the bug about once per week until the upload after FOSDEM. An alternative that I am mentioning now in case it is helpful. A minimal `Rules-Requires-Root: binary-targets` would take sreview out the auto-removal zone. This would have the advantage of having no regression risk caused by the change, since we would just be requesting the previous status quo enabling you to come back to the rootless fix at a later time. However, it is still an upload, so it is not immediately obvious to me that will avoid your core concern. If it is and a NMU will be helpful, just say the word. But if I do not hear from you, I assume any action from me on sreview would be unhelpful. Best regards, Niels OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1089440: sreview: Supporting rootless builds by default
Wouter Verhelst: [...] Thanks. I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance. I have applied your patch to git, and intend to upload it once the SReview-related work for the upcoming FOSDEM has finished. Thanks for the feedback (and the upload of logtool). Please do not NMU before then, as if it fails this would then take away brain cycles that are more urgently needed elsewhere ;-) Thanks. No problem from my PoV; I will not NMU it for now. FYI, I am hoping to push for the default in dpkg to change soon and that may occur before FOSDEM. The if/when that happens is a decision for the RT that I am stilling waiting for a reply on. Though it is also possible that they decline my request to change the default for Trixie at which point I expect FOSDEM 2025 will happen first. :) Lets cross that bridge when (or if) we get there and it happens before FOSDEM. Best regards, Niels OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1089440: sreview: Supporting rootless builds by default
Hi Niels, On Wed, Jan 01, 2025 at 11:36:11AM +0100, Niels Thykier wrote: > Control: tags -1 patch > > On Sat, 7 Dec 2024 21:41:59 +0100 Niels Thykier wrote: > > Source: sreview > > Version: 0.10.0-1 > > Severity: important > > Tags: ftbfs > > Justification: FTBFS > > X-Debbugs-Cc: ni...@thykier.net > > User: ni...@thykier.net > > Usertags: rrr-no-as-default-issue > > > > Dear maintainer, > > > > During a test rebuild for building packages with > > `Rules-Requires-Root: no` as the default in `dpkg`, > > sreview failed to rebuild. > > > > Log Summary: > > --- > > [...] > > > Hi > > Please see attached as a patch. Thanks. > I intend to NMU to make progress on the MBF if I do not hear from you on > this. It would help me if you either uploaded this soon or approved the NMU > (enabling me to skip the delay). Thanks in advance. I have applied your patch to git, and intend to upload it once the SReview-related work for the upcoming FOSDEM has finished. Please do not NMU before then, as if it fails this would then take away brain cycles that are more urgently needed elsewhere ;-) Thanks. -- w@uter.{be,co.za} wouter@{grep.be,fosdem.org,debian.org} I will have a Tin-Actinium-Potassium mixture, thanks.
Bug#1089440: sreview: Supporting rootless builds by default
Wouter Verhelst: [...] Thanks. I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance. I have applied your patch to git, and intend to upload it once the SReview-related work for the upcoming FOSDEM has finished. Thanks for the feedback (and the upload of logtool). Please do not NMU before then, as if it fails this would then take away brain cycles that are more urgently needed elsewhere ;-) Thanks. No problem from my PoV; I will not NMU it for now. FYI, I am hoping to push for the default in dpkg to change soon and that may occur before FOSDEM. The if/when that happens is a decision for the RT that I am stilling waiting for a reply on. Though it is also possible that they decline my request to change the default for Trixie at which point I expect FOSDEM 2025 will happen first. :) Lets cross that bridge when (or if) we get there and it happens before FOSDEM. Best regards, Niels OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1089440: sreview: Supporting rootless builds by default
Control: tags -1 patch On Sat, 7 Dec 2024 21:41:59 +0100 Niels Thykier wrote: Source: sreview Version: 0.10.0-1 Severity: important Tags: ftbfs Justification: FTBFS X-Debbugs-Cc: ni...@thykier.net User: ni...@thykier.net Usertags: rrr-no-as-default-issue Dear maintainer, During a test rebuild for building packages with `Rules-Requires-Root: no` as the default in `dpkg`, sreview failed to rebuild. Log Summary: --- [...] Hi Please see attached as a patch. I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance. Best regards, Niels diff -u sreview-0.10.0/debian/changelog sreview-0.10.0/debian/changelog --- sreview-0.10.0/debian/changelog +++ sreview-0.10.0/debian/changelog @@ -1,3 +1,12 @@ +sreview (0.10.0-1.1) unstable; urgency=medium + + * Non-maintainer upload. + * Remove need for root when building the package. +(Closes: #1089440) + * Tweak debian/rules to use more modern hook targets. + + -- Niels Thykier Wed, 01 Jan 2025 10:32:15 + + sreview (0.10.0-1) unstable; urgency=medium * New upstream release, with various fixes. diff -u sreview-0.10.0/debian/control sreview-0.10.0/debian/control --- sreview-0.10.0/debian/control +++ sreview-0.10.0/debian/control @@ -1,6 +1,7 @@ Source: sreview Section: video Priority: optional +Rules-Requires-Root: no Standards-Version: 4.1.1 Maintainer: Wouter Verhelst Vcs-Browser: https://salsa.debian.org/wouter/sreview diff -u sreview-0.10.0/debian/rules sreview-0.10.0/debian/rules --- sreview-0.10.0/debian/rules +++ sreview-0.10.0/debian/rules @@ -3,9 +3,11 @@ %: dh $@ --with apache2 -override_dh_install: +execute_before_dh_install: chmod +x debian/sreview-master.install debian/sreview-master.dbc - dh_install + # Apply sane minimum mode. This might be fixed in dh_auto_install + # as of compat 14 (making this command redundant at that time). + chmod -R u+rwX -R debian/tmp override_dh_installsystemd: dh_installsystemd -psreview-master --name=sreview-dispatch OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1089440: sreview: Supporting rootless builds by default
Source: sreview Version: 0.10.0-1 Severity: important Tags: ftbfs Justification: FTBFS X-Debbugs-Cc: ni...@thykier.net User: ni...@thykier.net Usertags: rrr-no-as-default-issue Dear maintainer, During a test rebuild for building packages with `Rules-Requires-Root: no` as the default in `dpkg`, sreview failed to rebuild. Log Summary: --- [...] ok 37 # skip Need a database to play with ok 38 # skip Need a database to play with ok 39 # skip Need a database to play with ok 40 # skip Need a database to play with ok 41 # skip Need a database to play with ok 42 # skip Need a database to play with ok 43 # skip Need a database to play with ok 44 # skip Need a database to play with ok 45 # skip Need a database to play with ok 46 # skip Need a database to play with ok 47 # skip Need a database to play with ok 48 # skip Need a database to play with ok 49 # skip Need a database to play with ok 50 # skip Need a database to play with ok 51 # skip Need a database to play with ok Warning: could not find configuration file /etc/sreview/config.pm, falling back to defaults at /<>/blib/lib/SReview/Config/Common.pm line 63. t/110-api.t .. ok 1 # skip Need a database to play with 1..1 ok t/120-types.t ok 1 # skip Can't test database work unless the SREVIEWTEST_DB environment variable points to a database which we may clobber and recreate 1..1 ok t/130-schedule.t . ok 1 - use SReview::Schedule::Yaml; ok 2 - we parsed exactly one event ok 3 - we parsed 3 talks ok 4 - the test talk was parsed correctly 1..4 ok All tests successful. Files=11, Tests=119, 6 wallclock secs ( 0.07 usr 0.02 sys + 4.98 cusr 0.79 csys = 5.86 CPU) Result: PASS make[1]: Leaving directory '/<>' create-stamp debian/debhelper-build-stamp dh_prep dh_installdirs dh_auto_install make -j4 install DESTDIR=/<>/debian/tmp AM_UPDATE_INFO_DIR=no PREFIX=/usr make[1]: Entering directory '/<>' Manifying 10 pod documents Manifying 10 pod documents Installing /<>/debian/tmp/usr/share/perl5/SReview.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Talk.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Config.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Job.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Access.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Db.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/API.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/CodecMap.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Template.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Config/Common.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Files/Factory.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Files/Collection/HTTP.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Files/Collection/S3.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Files/Collection/HTTP/nginx/JSON.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Talk.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Room.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Config.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/User.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Finalreview.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Speaker.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Inject.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Schedule.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Review.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Track.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Volunteer.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/CreditPreviews.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Admin.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Web/Controller/Event.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/API/Helpers.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Model/DbElement.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Model/Event.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Template/Synfig.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Template/SVG.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Talk/State.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Talk/Progress.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Schedule/Wafer.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Schedule/Ics.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Schedule/Multi.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Schedule/Penta.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Schedule/Yaml.pm Installing /<>/debian/tmp/usr/share/perl5/SReview/Schedule/WithShadow.pm Installing /<>/debian/tmp/u