Bug#1103471: camitk: FTBFS with the nocheck build profile

2025-04-30 Thread Étienne Mollier
Hi Emmanuel,

> I managed to add the required safeguards around the ctest instructions so
> that they are not executed when test is disabled and when the nocheck build
> profile is used.
> The patch is pushed on salsa, and it should be OK to upload.

Thank you for your contribution, I have verified the package
resolves the issue and triggered an upload a few minutes ago.

(Note I had to redo the debian/5.2.0-5 git tag to make sure it
matches the state of the package upon upload (d/changelog was
still unreleased), so you may have to clear your tag on your
local copy to fetch the new mapping.)

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier 
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/1, please excuse my verbosity
   `-on air: Yes - The Revealing Science Of God


signature.asc
Description: PGP signature


Bug#1103471: [Debian-med-packaging] Bug#1103471: camitk: FTBFS with the nocheck build profile

2025-04-19 Thread Emmanuel Promayon

Dear Étienne,

Thanks for your quick answer.

I managed to add the required safeguards around the ctest instructions 
so that they are not executed when test is disabled and when the nocheck 
build profile is used.

The patch is pushed on salsa, and it should be OK to upload.

Best regards,
Emmanuel

On 18/04/2025 11:14, Étienne Mollier wrote:

Hi Emmanuel,

Emmanuel Promayon, on 2025-04-18:

Would that be important to fix in the current trixie timeline (or just nice
to have)?

This is a bug with severity rating important: it is not a
necessity to fix it for the trixie timeline, but it is
acceptable to fix it during the freeze, probably even after
trixie is stable (via a trixie-pu).


Last question: I tried to reproduce the bug in a normal/non packaging
situation using
cmake ... -DBUILD_TESTING=OFF.

Is that enough, or did I miss some other settings?

 From quick glimpse at the code, I can't tell for sure.  You
would need to run the build via pbuilder or sbuild (in an
isolate chroot), making sure both DEB_BUILD_OPTIONS and
DEB_BUILD_PROFILES environment variables are set to "nocheck".

Have a nice day,  :)


Bug#1103471: [Debian-med-packaging] Bug#1103471: camitk: FTBFS with the nocheck build profile

2025-04-18 Thread Étienne Mollier
Hi Emmanuel,

Emmanuel Promayon, on 2025-04-18:
> Would that be important to fix in the current trixie timeline (or just nice
> to have)?

This is a bug with severity rating important: it is not a
necessity to fix it for the trixie timeline, but it is
acceptable to fix it during the freeze, probably even after
trixie is stable (via a trixie-pu).

> Last question: I tried to reproduce the bug in a normal/non packaging
> situation using
> cmake ... -DBUILD_TESTING=OFF.
> 
> Is that enough, or did I miss some other settings?

From quick glimpse at the code, I can't tell for sure.  You
would need to run the build via pbuilder or sbuild (in an
isolate chroot), making sure both DEB_BUILD_OPTIONS and
DEB_BUILD_PROFILES environment variables are set to "nocheck".

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier 
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/4, please excuse my verbosity
   `-on air: Ozric Tentacles - Afroclonk


signature.asc
Description: PGP signature


Bug#1103471: camitk: FTBFS with the nocheck build profile

2025-04-17 Thread Santiago Vila
Package: src:camitk
Version: 5.2.0-4
Severity: important
Tags: trixie sid ftbfs
User: debian...@lists.debian.org
Usertags: ftbfs-nocheck-profile

Dear maintainer:

During a rebuild of all packages in unstable using the nocheck build profile,
your package failed to build:


[...]
 debian/rules clean
dh clean --builddirectory=camitk-build
   dh_auto_clean -O--builddirectory=camitk-build
   dh_autoreconf_clean -O--builddirectory=camitk-build
   dh_clean -O--builddirectory=camitk-build
 debian/rules binary
dh binary --builddirectory=camitk-build
   dh_update_autotools_config -O--builddirectory=camitk-build
   dh_autoreconf -O--builddirectory=camitk-build
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/<>'

[... snipped ...]

PC_SQLite3_LIBS_PATHS:INTERNAL=
PC_SQLite3_MODULE_NAME:INTERNAL=sqlite3
PC_SQLite3_PREFIX:INTERNAL=/usr
PC_SQLite3_STATIC_CFLAGS:INTERNAL=-I/usr/include
PC_SQLite3_STATIC_CFLAGS_I:INTERNAL=
PC_SQLite3_STATIC_CFLAGS_OTHER:INTERNAL=
PC_SQLite3_STATIC_INCLUDE_DIRS:INTERNAL=/usr/include
PC_SQLite3_STATIC_LDFLAGS:INTERNAL=-L/usr/lib/x86_64-linux-gnu;-lsqlite3;-lm;-lz
PC_SQLite3_STATIC_LDFLAGS_OTHER:INTERNAL=
PC_SQLite3_STATIC_LIBDIR:INTERNAL=
PC_SQLite3_STATIC_LIBRARIES:INTERNAL=sqlite3;m;z
PC_SQLite3_STATIC_LIBRARY_DIRS:INTERNAL=/usr/lib/x86_64-linux-gnu
PC_SQLite3_STATIC_LIBS:INTERNAL=
PC_SQLite3_STATIC_LIBS_L:INTERNAL=
PC_SQLite3_STATIC_LIBS_OTHER:INTERNAL=
PC_SQLite3_STATIC_LIBS_PATHS:INTERNAL=
PC_SQLite3_VERSION:INTERNAL=3.46.1
PC_SQLite3_sqlite3_INCLUDEDIR:INTERNAL=
PC_SQLite3_sqlite3_LIBDIR:INTERNAL=
PC_SQLite3_sqlite3_PREFIX:INTERNAL=
PC_SQLite3_sqlite3_VERSION:INTERNAL=
//ADVANCED property for variable: PKG_CONFIG_ARGN
PKG_CONFIG_ARGN-ADVANCED:INTERNAL=1
//ADVANCED property for variable: PKG_CONFIG_EXECUTABLE
PKG_CONFIG_EXECUTABLE-ADVANCED:INTERNAL=1
PKG_FONTCONFIG_CFLAGS:INTERNAL=-I/usr/include;-I/usr/include/freetype2;-I/usr/include/libpng16
PKG_FONTCONFIG_CFLAGS_I:INTERNAL=
PKG_FONTCONFIG_CFLAGS_OTHER:INTERNAL=
PKG_FONTCONFIG_FOUND:INTERNAL=1
PKG_FONTCONFIG_INCLUDEDIR:INTERNAL=/usr/include
PKG_FONTCONFIG_INCLUDE_DIRS:INTERNAL=/usr/include;/usr/include/freetype2;/usr/include/libpng16
PKG_FONTCONFIG_LDFLAGS:INTERNAL=-L/usr/lib/x86_64-linux-gnu;-lfontconfig;-lfreetype
PKG_FONTCONFIG_LDFLAGS_OTHER:INTERNAL=
PKG_FONTCONFIG_LIBDIR:INTERNAL=/usr/lib/x86_64-linux-gnu
PKG_FONTCONFIG_LIBRARIES:INTERNAL=fontconfig;freetype
PKG_FONTCONFIG_LIBRARY_DIRS:INTERNAL=/usr/lib/x86_64-linux-gnu
PKG_FONTCONFIG_LIBS:INTERNAL=
PKG_FONTCONFIG_LIBS_L:INTERNAL=
PKG_FONTCONFIG_LIBS_OTHER:INTERNAL=
PKG_FONTCONFIG_LIBS_PATHS:INTERNAL=
PKG_FONTCONFIG_MODULE_NAME:INTERNAL=fontconfig
PKG_FONTCONFIG_PREFIX:INTERNAL=/usr
PKG_FONTCONFIG_STATIC_CFLAGS:INTERNAL=-I/usr/include;-I/usr/include/freetype2;-I/usr/include/libpng16;-DXML_STATIC
PKG_FONTCONFIG_STATIC_CFLAGS_I:INTERNAL=
PKG_FONTCONFIG_STATIC_CFLAGS_OTHER:INTERNAL=-DXML_STATIC
PKG_FONTCONFIG_STATIC_INCLUDE_DIRS:INTERNAL=/usr/include;/usr/include/freetype2;/usr/include/libpng16
PKG_FONTCONFIG_STATIC_LDFLAGS:INTERNAL=-L/usr/lib/x86_64-linux-gnu;-lfontconfig;-lfreetype;-L/usr/lib/x86_64-linux-gnu;-L/usr/lib/x86_64-linux-gnu;-lz;-L/usr/lib;-lbz2;-lpng16;-lz;-lm;-L/usr/lib/x86_64-linux-gnu;-L/usr/lib/x86_64-linux-gnu;-lz;-lbrotlidec;-L/usr/lib/x86_64-linux-gnu;-lbrotlicommon;-L/usr/lib/x86_64-linux-gnu;-lexpat;-lm
PKG_FONTCONFIG_STATIC_LDFLAGS_OTHER:INTERNAL=
PKG_FONTCONFIG_STATIC_LIBDIR:INTERNAL=
PKG_FONTCONFIG_STATIC_LIBRARIES:INTERNAL=fontconfig;freetype;z;bz2;png16;z;m;z;brotlidec;brotlicommon;expat;m
PKG_FONTCONFIG_STATIC_LIBRARY_DIRS:INTERNAL=/usr/lib/x86_64-linux-gnu;/usr/lib/x86_64-linux-gnu;/usr/lib/x86_64-linux-gnu;/usr/lib;/usr/lib/x86_64-linux-gnu;/usr/lib/x86_64-linux-gnu;/usr/lib/x86_64-linux-gnu;/usr/lib/x86_64-linux-gnu
PKG_FONTCONFIG_STATIC_LIBS:INTERNAL=
PKG_FONTCONFIG_STATIC_LIBS_L:INTERNAL=
PKG_FONTCONFIG_STATIC_LIBS_OTHER:INTERNAL=
PKG_FONTCONFIG_STATIC_LIBS_PATHS:INTERNAL=
PKG_FONTCONFIG_VERSION:INTERNAL=2.15.0
PKG_FONTCONFIG_fontconfig_INCLUDEDIR:INTERNAL=
PKG_FONTCONFIG_fontconfig_LIBDIR:INTERNAL=
PKG_FONTCONFIG_fontconfig_PREFIX:INTERNAL=
PKG_FONTCONFIG_fontconfig_VERSION:INTERNAL=
//ADVANCED property for variable: PML_TOOLS_INTERNAL
PML_TOOLS_INTERNAL-ADVANCED:INTERNAL=1
//Is PML_TOOLS already created?
PML_TOOLS_INTERNAL:INTERNAL=TRUE
//ADVANCED property for variable: PNG_LIBRARY_DEBUG
PNG_LIBRARY_DEBUG-ADVANCED:INTERNAL=1
//ADVANCED property for variable: PNG_LIBRARY_RELEASE
PNG_LIBRARY_RELEASE-ADVANCED:INTERNAL=1
//ADVANCED property for variable: PNG_PNG_INCLUDE_DIR
PNG_PNG_INCLUDE_DIR-ADVANCED:INTERNAL=1
SHIBOKEN_CAMITK_SDK_PATH:INTERNAL=/<>/sdk:/<>/tutorials/viewers
//ADVANCED property for variable: SQLite3_INCLUDE_DIR
SQLite3_INCLUDE_DIR-ADVANCED:INTERNAL=1
//ADVANCED property for variable: SQLite3_LIBRARY
SQLite3_LIBRARY-ADVANCED:INTERNAL=1
//ADVANCED property for variable: THEORA_INCLUDE_DIR
THEORA_INCLUDE_DIR-ADVANCED:INTERNAL=1
//A

Bug#1103471: camitk: FTBFS with the nocheck build profile

2025-04-17 Thread Emmanuel Promayon

Thanks for the bug report.

This is due to CamiTK CMake macros who do not consider the case that 
testing could be disabled!
To fix this bugs requires to add few safeguards in the CMake macros (by 
checking first if CMake BUILD_TESTING is on before setting test properties).

This is definitely possible to achieve in a relatively small amount of time.

Would that be important to fix in the current trixie timeline (or just 
nice to have)?


Last question: I tried to reproduce the bug in a normal/non packaging 
situation using

cmake ... -DBUILD_TESTING=OFF.

Is that enough, or did I miss some other settings?

Best regards,
Emmanuel