Bug#1104302: RFS: duckdb/1.2.2-1 [ITP] -- In-process SQL OLAP database management system
Hello, On 2025-05-08 08:09, Phil Wyett wrote: The package is looking promising. Will tag as 'confirmed' and hope a DD will find the time to review and possibly sponsor your package. I am interested in having DuckDB in Debian. Thanks Mocus Zhang for working on it! I gave the packaging on salsa.debian.org a look. I have the following comments: 1. I noticed in debian/patches/add-soname you are adding a soname to a shared library. Doing so on Debian side (via patch) is generally frowned upon. This should be done by the upstream, as only they can (or cannot) guarantee the API/ABI compatibility of their shared library. Thus I would suggest either upstreaming the soname or dropping the shared library altogether. Breaking API/ABI compatibility causes real mess. 2. Have you considered unembedding third-party sources, especially mbedtls? Many of the embedded sources seem to be packaged in Debian (at least brotli, mbedtls, snappy, thrift). Embedded sources cause unnecessary package bloat and, more important, issues with security. Best wishes, Andrius
Bug#1104302: RFS: duckdb/1.2.2-1 [ITP] -- In-process SQL OLAP database management system
Control: tags -1 -moreinfo Control: tags -1 +confirmed Mocus Zhang, Review of upload: 2025-05-07 23:31 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Summary === The package is looking promising. Will tag as 'confirmed' and hope a DD will find the time to review and possibly sponsor your package. We are in the final stages for the release of Debian 13 (trixie) and people are busy. Please be patient and I encourage you to work on any outstanding lintian issues or any other little tasks to improve the package. -- Regards Phil Donate: https://buymeacoffee.com/kathenasorg -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg Threads: https://www.threads.net/@kathenasorg -- signature.asc Description: This is a digitally signed message part
Bug#1104302: RFS: duckdb/1.2.2-1 [ITP] -- In-process SQL OLAP database management system
Mocus Zhang, Review of upload: 2025-05-07 03:32 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Test 4 (sbuild): Information only Lintian: I: duckdb source: patch-not-forwarded-upstream [debian/patches/add-soname] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch Test 7 (licenserecon): Information only philwyett@ks-tarkin:~/Development/builder/debian/duckdb-1.2.2$ lrc en: Versions: licenserecon '4.2' licensecheck '3.3.9-1' Parsing Source Tree Reading d/copyright Missing Files: Paragraph for debian/ Running licensecheck d/copyright | licensecheck MIT | Expat LICENSE BSD-3-clause | BSD-3-clause and/or CC-BY-3.0 and/or Expat third_party/snappy/LICENSE Summary === Great work on 'debian/copyright', not an easy task. Test 4. You may wish to make the patch DEP-3 compliant. Test 7. You may wish to add the highlighted files to 'debian/lrc.config'. -- Regards Phil Donate: https://buymeacoffee.com/kathenasorg -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg Threads: https://www.threads.net/@kathenasorg -- signature.asc Description: This is a digitally signed message part
Bug#1104302: RFS: duckdb/1.2.2-1 [ITP] -- In-process SQL OLAP database management system
Mocus Zhang, Review of upload: 2025-05-03 13:47 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Test 4 (sbuild): Information only Lintian: Running lintian... N: I: duckdb source: license-file-listed-in-debian-copyright data/geoparquet/LICENSE [debian/copyright] N: N: A file containing a software license is listed in debian/copyright. That N: is not necessary. Please remove the entry referring to the license file. N: N: Visibility: info N: Show-Always: no N: Check: debian/copyright/dep5 N: N: I: libduckdb1: no-symbols-control-file usr/lib/x86_64-linux- gnu/libduckdb.so.1.2.2 N: N: Although the package includes a shared library, the package does not have N: a symbols control file. N: N: dpkg can use symbols files in order to generate more accurate library N: dependencies for applications, based on the symbols from the library that N: are actually used by the application. N: N: Please refer to the dpkg-gensymbols(1) manual page and N: https://wiki.debian.org/UsingSymbolsFiles for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/shlibs N: N: I: libduckdb-dev: package-contains-empty-directory [usr/include/duckdb/main/capi/header_generation/apis/v1/unstable/] N: N: This package installs an empty directory. This might be intentional but N: it's normally a mistake. If it is intentional, add a Lintian override. N: N: If a package ships with or installs empty directories, you can remove them N: in debian/rules by calling: N: N:$ find path/to/base/dir -type d -empty -delete N: N: Visibility: info N: Show-Always: no N: Check: files/empty-directories N: N: I: libduckdb-dev: package-contains-empty-directory [usr/include/duckdb/main/capi/header_generation/apis/v1/v1.2/] N: I: libduckdb-dev: package-contains-empty-directory [usr/include/duckdb/main/capi/header_generation/functions/] N: I: libduckdb-dev: package-contains-empty-directory [usr/include/duckdb/storage/serialization/] N: I: duckdb source: patch-not-forwarded-upstream [debian/patches/add-soname] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch N: N: I: duckdb source: unused-license-paragraph-in-dep5-copyright bsd-3-clause [debian/copyright:189] N: N: The license paragraph in the machine-readable copyright file is not N: referenced by any files paragraph. It could be a typo in the license name N: or the license paragraph is simply not needed and can be removed. N: N: Please refer to N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for N: details. N: N: Visibility: info N: Show-Always: no N: Check: debian/copyright/dep5 N: N: P: duckdb source: maintainer-manual-page [debian/duckdb.1] N: N: The maintainer keeps a manual page in ./debian. Please forward the manual N: page upstream and ask them to include in their version control system, and N: in their next release. N: N: If the manual page was already forwarded or rejected, or the upstream is N: gone, please override the tag and annotate it with a suitable comment. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, and N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual N: for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/manual-pages N: Renamed from: maintainer-manpage N: I: Lintian run was successful. Test 7 (licenserecon): Information only philwyett@ks-tarkin:~/Development/builder/debian/duckdb-1.2.2$ lrc en: Versions: licenserecon '4.2' licensecheck '3.3.9-1' Parsing Source Tree Reading d/copyright Missing Files: Paragraph for debian/ Running licensecheck d/copyright | licensecheck ICU and BSD-3-clause| ICU extension/icu/third_party/icu/i18n/decContext.cpp ICU and BSD-3-clause| ICU extension/icu/third_party/icu/i18n/decContext.h ICU and BSD-3-clause| ICU extension/icu/third_party/icu/i18n/decNumber.cpp ICU and BSD-3-clause| ICU extension/icu/third_party/icu/i18n/decNumber.h ICU and BSD-3-clause| ICU extension/icu/third_party/icu/i18n/decNumberLocal.h ICU and BSD-3-clause| BSD-3-clause extension/icu/third_party/icu/i18n/double-conversion-bignum.
Bug#1104302: RFS: duckdb/1.2.2-1 [ITP] -- In-process SQL OLAP database management system
Hi Phil, For copyright, I update the new debian/copyright to suite for License https://salsa.debian.org/MocusEZ/duckdb/-/blob/817883f769314ce0c17006f8184872e05d3765ce/debian/copyright Update a man page accord to duckdb --help https://salsa.debian.org/MocusEZ/duckdb/-/commit/b8b6386aed3e2598059046335f4afffbec29a894 Add more descroption of duckdb https://salsa.debian.org/MocusEZ/duckdb/-/commit/817883f769314ce0c17006f8184872e05d3765ce And I enable the Ninja-build to fast the build the process https://salsa.debian.org/MocusEZ/duckdb/-/commit/5e5ebb25659679946306395b82e35b85a014af5e The new package is already uploaded to mentors.debian.net for #2 https://mentors.debian.net/package/duckdb/ Please consider reviewing again. Thanks! Regards Mocus
Bug#1104302: RFS: duckdb/1.2.2-1 [ITP] -- In-process SQL OLAP database management system
Control: tags -1 +moreinfo Mocus Zhang, Review of upload: 2025-04-29 07:32 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Test 4 (sbuild): Information only Running lintian... N: W: duckdb: no-manual-page [usr/bin/duckdb] N: N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have N: a manual page N: N: Note that though the man program has the capability to check for several N: program names in the NAMES section, each of these programs should have its N: own manual page (a symbolic link to the appropriate manual page is N: sufficient) because other manual page viewers such as xman or tkman don't N: support this. N: N: If the name of the manual page differs from the binary by case, man may be N: able to find it anyway; however, it is still best practice to match the N: exact capitalization of the executable in the manual page. N: N: If the manual pages are provided by another package on which this package N: depends, Lintian may not be able to determine that manual pages are N: available. In this case, after confirming that all binaries do have manual N: pages after this package and its dependencies are installed, please add a N: Lintian override. N: N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: binary-without-manpage N: N: I: duckdb: extended-description-is-probably-too-short N: N: The extended description (the lines after the first line of the N: "Description:" field) is only one or two lines long. The extended N: description should provide a user with enough information to decide N: whether they want to install this package, what it contains, and how it N: compares to similar packages. One or two lines is normally not enough to N: do this. N: N: Please refer to General guidelines for package descriptions (Section N: 6.2.1) in the Debian Developer's Reference and The long description N: (Section 6.2.3) in the Debian Developer's Reference for details. N: N: Visibility: info N: Show-Always: no N: Check: fields/description N: N: I: libduckdb1: no-symbols-control-file usr/lib/x86_64-linux- gnu/libduckdb.so.1.2.2 N: N: Although the package includes a shared library, the package does not have N: a symbols control file. N: N: dpkg can use symbols files in order to generate more accurate library N: dependencies for applications, based on the symbols from the library that N: are actually used by the application. N: N: Please refer to the dpkg-gensymbols(1) manual page and N: https://wiki.debian.org/UsingSymbolsFiles for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/shlibs N: N: I: libduckdb-dev: package-contains-empty-directory [usr/include/duckdb/main/capi/header_generation/apis/v1/unstable/] N: N: This package installs an empty directory. This might be intentional but N: it's normally a mistake. If it is intentional, add a Lintian override. N: N: If a package ships with or installs empty directories, you can remove them N: in debian/rules by calling: N: N:$ find path/to/base/dir -type d -empty -delete N: N: Visibility: info N: Show-Always: no N: Check: files/empty-directories N: N: I: libduckdb-dev: package-contains-empty-directory [usr/include/duckdb/main/capi/header_generation/apis/v1/v1.2/] N: I: libduckdb-dev: package-contains-empty-directory [usr/include/duckdb/main/capi/header_generation/functions/] N: I: libduckdb-dev: package-contains-empty-directory [usr/include/duckdb/storage/serialization/] N: I: duckdb source: patch-not-forwarded-upstream [debian/patches/add-soname] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch N: E: Lintian run failed (policy violation) Test 7 (licenserecon): Information only philwyett@ks-tarkin:~/Development/builder/debian/duckdb$ lrc en: Versions: licenserecon '4.2' licensecheck '3.3.9-1' Parsing Source Tree Reading d/copyright Missing Files: Paragraph for debian/ Running licensecheck d/copyright | licensecheck MIT | Apache-2.0data/geoparquet/LICENSE MIT | Apache-2.0data/parquet-testing/LICENSE.txt MIT | ICU
Bug#1104302: RFS: duckdb/1.2.2-1 [ITP] -- In-process SQL OLAP database management system
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "duckdb": * Package name : duckdb Version : 1.2.2-1 Upstream contact :https://github.com/duckdb/duckdb * URL :https://duckdb.org * License : MIT * Vcs :https://salsa.debian.org/MocusEZ/duckdb Section : database The source builds the following binary packages: duckdb - In-process SQL OLAP database management system libduckdb1 - Shared library for DuckDB libduckdb-dev - Development files for DuckDB To access further information about this package, please visit the following URL: https://mentors.debian.net/package/duckdb/ Alternatively, you can download the package with 'dget' using this command: dget -xhttps://mentors.debian.net/debian/pool/main/d/duckdb/duckdb_1.2.2-1.dsc Changes for the initial release: duckdb (1.2.2-1) unstable; urgency=medium . * Initial release (Closes: #1036922) Regards, -- Mocus Zhang
