Bug#1130088: godot: Please drop the riscv64 libatomic workaround
On Sun, Mar 08, 2026 at 03:44:11PM +0100, John Paul Adrian Glaubitz wrote:
>
> Hi Adrian,
Hi Adrian,
> On Sun, 2026-03-08 at 16:37 +0200, Adrian Bunk wrote:
> > This workaround is no longer required with recent GCC versions.
> >
> > --- godot-4.4.1+ds/debian/rules 2025-08-16 13:03:47.0 +
> > +++ godot-4.4.1+ds/debian/rules 2025-08-16 13:03:47.0 +
> > @@ -6,12 +6,6 @@
> > DPKG_EXPORT_BUILDFLAGS = 1
> > include /usr/share/dpkg/buildflags.mk
> >
> > -# Link with libatomic on archs where it is needed.
> > -# See https://bugs.debian.org/1019868 >
> > -ifeq ($(DEB_HOST_ARCH),$(filter $(DEB_HOST_ARCH),armel riscv64))
> > - export DEB_LDFLAGS_MAINT_APPEND += -Wl,--no-as-needed -latomic
> > -Wl,--as-needed
> > -endif
> > -
> > # replace "custom_build" with more useful Debian version info
> > include /usr/share/dpkg/pkg-info.mk # provides DEB_VERSION
> > export BUILD_NAME = debian${DEB_VERSION}
>
> This should affect a large number of packages, maybe we should file mass bugs.
>
> FWIW, have you verified that the workaround is no longer needed? I have seen
> the
> bug in question was fixed upstream, but I have never verified it actually
> works.
there are/were two different variants of this problem:
You are thinking of 64-bit atomics on 32-bit, which are supposed to be
fixed in the upcoming GCC 16 and after the removal of armel affects only
non-release architectures.
riscv64 had this problem with 1-bit atomics, which was fixed in a
different way in GCC 14(?).
The riscv64 issue does not affect many packages (the 32-bit one does),
I might go through these packages at some point.
> Adrian
cu
Adrian
Bug#1130088: godot: Please drop the riscv64 libatomic workaround
Hi Adrian,
On Sun, 2026-03-08 at 16:37 +0200, Adrian Bunk wrote:
> This workaround is no longer required with recent GCC versions.
>
> --- godot-4.4.1+ds/debian/rules 2025-08-16 13:03:47.0 +
> +++ godot-4.4.1+ds/debian/rules 2025-08-16 13:03:47.0 +
> @@ -6,12 +6,6 @@
> DPKG_EXPORT_BUILDFLAGS = 1
> include /usr/share/dpkg/buildflags.mk
>
> -# Link with libatomic on archs where it is needed.
> -# See https://bugs.debian.org/1019868 >
> -ifeq ($(DEB_HOST_ARCH),$(filter $(DEB_HOST_ARCH),armel riscv64))
> - export DEB_LDFLAGS_MAINT_APPEND += -Wl,--no-as-needed -latomic
> -Wl,--as-needed
> -endif
> -
> # replace "custom_build" with more useful Debian version info
> include /usr/share/dpkg/pkg-info.mk # provides DEB_VERSION
> export BUILD_NAME = debian${DEB_VERSION}
This should affect a large number of packages, maybe we should file mass bugs.
FWIW, have you verified that the workaround is no longer needed? I have seen the
bug in question was fixed upstream, but I have never verified it actually works.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Bug#1130088: godot: Please drop the riscv64 libatomic workaround
Source: godot Version: 4.4.1+ds-1 Severity: minor Tags: patch X-Debbugs-Cc: [email protected] User: [email protected] Usertags: riscv64 This workaround is no longer required with recent GCC versions. --- godot-4.4.1+ds/debian/rules 2025-08-16 13:03:47.0 + +++ godot-4.4.1+ds/debian/rules 2025-08-16 13:03:47.0 + @@ -6,12 +6,6 @@ DPKG_EXPORT_BUILDFLAGS = 1 include /usr/share/dpkg/buildflags.mk -# Link with libatomic on archs where it is needed. -# See https://bugs.debian.org/1019868 > -ifeq ($(DEB_HOST_ARCH),$(filter $(DEB_HOST_ARCH),armel riscv64)) - export DEB_LDFLAGS_MAINT_APPEND += -Wl,--no-as-needed -latomic -Wl,--as-needed -endif - # replace "custom_build" with more useful Debian version info include /usr/share/dpkg/pkg-info.mk # provides DEB_VERSION export BUILD_NAME = debian${DEB_VERSION}
