Bug#349869: (no subject)

[Jiří Paleček]

Sorry about posting this more than once, I wrote bad address.


  Could you please test the attached patch and tell me if it fixes this
problem?

Yes, it does. There are other problems, though.


  Thanks for confirming that.  I'll commit it.

  Would you mind describing the other problems, if you have the time?


Yes. I have described them in bug 380509.

Regards
Jiri Palecek


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#349869: (no subject)

[Jiří Paleček]

  Could you please test the attached patch and tell me if it fixes this
problem?


Yes, it does. There are other problems, though.


I can't test this easily since I don't have CDs lying around.


Sorry, but you could have said that half a year ago. This was just a
waste of time.

Regards
Jiri Palecek


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#349869: (no subject)

[Daniel Burrows]

On Sun, Jul 23, 2006 at 05:06:14PM +0200, Jiří Paleček [EMAIL PROTECTED] was 
heard to say:
 Just in case anybody reads this:
 
 The problem is that after processing the first CD, download_install_manager
 calls apt_cache_close() in its finish() method. Then, the download  
 continues
 with the same download manager, which holds a reference to the dependency  
 cache
 which was deleted. The use of this cache causes the segfault.
 
 Also, unless there is a reply in a month, i'll set the severity of this bug
 to serious, as it makes the package unusable for installing Debian from
 CD. However, I think it's easy to fix it.

  Could you please test the attached patch and tell me if it fixes this
problem?  I can't test this easily since I don't have CDs lying around.

Thanks,
  Daniel
diff -rN -udp old-head-1/src/generic/apt/download_install_manager.cc 
new-head/src/generic/apt/download_install_manager.cc
--- old-head-1/src/generic/apt/download_install_manager.cc  2006-07-26 
21:33:38.0 -0700
+++ new-head/src/generic/apt/download_install_manager.cc2006-07-26 
21:33:47.0 -0700
@@ -174,10 +174,10 @@ download_manager::result download_instal
 {
   result run_res = execute_install_run(res, progress);
 
-  apt_close_cache();
-
   if(run_res != do_again)
 {
+  apt_close_cache();
+
   if(log != NULL)
log-Complete();
 



signature.asc
Description: Digital signature

Bug#349869: (no subject)

[Jiří Paleček]

Just in case anybody reads this:

The problem is that after processing the first CD, download_install_manager
calls apt_cache_close() in its finish() method. Then, the download  
continues
with the same download manager, which holds a reference to the dependency  
cache

which was deleted. The use of this cache causes the segfault.

Also, unless there is a reply in a month, i'll set the severity of this bug
to serious, as it makes the package unusable for installing Debian from
CD. However, I think it's easy to fix it.

Regards
Jiri Palecek


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]