Bug#397120: uswsusp: s2disk wants to run /usr/sbin/grubonce which doesn't exist

2006-11-06 Thread Michael Meskes
 I don't quite see the problem (or bug) here. If grubonce exists,

Why not?

 powersaved makes use of it, otherwise not. It's not that suspend_to_disk
 fails, if grubonce does not exist. powersaved just writes to the log

True, but definitely not clear to the user. If something doens't work,
the first thing a user does is/should be looking into the log. Seeing an
error message there at least suggests that this is the reason for
his/her problems. 

 file, that it didn't find grubonce. I can see nothing wrong with that.
 Could you please elaborate? Otherwise I'm going to close this bug report.

Having a package printing an error message because of a missing binary
is definitely not a correct behaviour. Especially if that binary is not
available at all in Debian. Since it's not needed you could simply call
true instead or just patch out the call. 

I can see no reason however to just close the report.

Michael

-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#397120: uswsusp: s2disk wants to run /usr/sbin/grubonce which

2006-11-06 Thread Michael Meskes
On Mon, Nov 06, 2006 at 10:23:36AM +0100, Michael Biebl wrote:
 Huh? It's not an error message. powersaved is just printing exactly,
 what it is doing:
 
 preparing boot-loader: selecting entry 1, kernel /boot/2.6.19-rc4
 /usr/sbin/grubonce not found, not preparing bootloader
   time needed for sync: 0.2 seconds, time needed for grub: 0.0 seconds.

But still it tells people that it didn't find the binary. And that it
does not prepare the bootloader. How many users do you think will notice
that this is NOT an error?

 Patching out the above message might leave the user in the false
 impression, that powersaved is mangling with the grub settings, which it
 does not, if grubonce is not available.

Eh? If you remove the whole message why should the user think powersaved
does anything with grub?

 Given the above reasoning, I think removing the log message entry makes
 things worse. Closing this bug report.

You're joking, right? With the same reasoning you could add a lot of
messages about all the settings powersaved is not fiddling with. :-)

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!



Bug#397120: uswsusp: s2disk wants to run /usr/sbin/grubonce which

2006-11-06 Thread Michael Biebl
Hi Michael!

Michael Meskes wrote:
 On Mon, Nov 06, 2006 at 10:23:36AM +0100, Michael Biebl wrote:
 Huh? It's not an error message. powersaved is just printing exactly,
 what it is doing:

 preparing boot-loader: selecting entry 1, kernel /boot/2.6.19-rc4
 /usr/sbin/grubonce not found, not preparing bootloader
   time needed for sync: 0.2 seconds, time needed for grub: 0.0 seconds.
 
 But still it tells people that it didn't find the binary. And that it
 does not prepare the bootloader. How many users do you think will notice
 that this is NOT an error?
 
 Patching out the above message might leave the user in the false
 impression, that powersaved is mangling with the grub settings, which it
 does not, if grubonce is not available.
 
 Eh? If you remove the whole message why should the user think powersaved
 does anything with grub?

Because this is the default upstream behaviour.
Say, someone has actually problems that grub boots the wrong kernel. So
he usually uses google or asks around (on #irc e.g.) to find more
information and help. Other people that know powersaved will most likely
tell him to check the log files, if there are error messages related to
grubonce. If this log entry regarding the nonexistent grubonce binary is
missing, he might get false answers because this information is missing.

 Given the above reasoning, I think removing the log message entry makes
 things worse. Closing this bug report.
 
 You're joking, right? With the same reasoning you could add a lot of
 messages about all the settings powersaved is not fiddling with. :-)

This comparison is of course bogus (and I'm sure you know that).
Inserting random messages into the log file is something basically
different than removing standard messages from the output.

My fear is, that there is documentation for powersaved floating around
in the wide areas of the internet, that refers to grubonce. If I remove
the information regarding grubonce from the log file, people might be
confused and lead in the wrong direction.

Anyways, if you are so keen about this and you really think that this
log message is misleading, I will think about it once more and possibly
remove it.

Cheers,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature


Bug#397120: uswsusp: s2disk wants to run /usr/sbin/grubonce which

2006-11-06 Thread Michael Meskes
  You're joking, right? With the same reasoning you could add a lot of
  messages about all the settings powersaved is not fiddling with. :-)
 
 This comparison is of course bogus (and I'm sure you know that).
 Inserting random messages into the log file is something basically
 different than removing standard messages from the output.

Sorry, my smiley should have been more obvious. I was indeed joking.

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#397120: uswsusp: s2disk wants to run /usr/sbin/grubonce which doesn't exist

2006-11-05 Thread Michael Meskes
Package: uswsusp
Severity: normal

From the log file:

...
checking ndiswrapper
--
prepare_sleep finished for suspend2disk
--
preparing boot-loader: selecting entry 0, kernel /boot/2.6.18-1-686
/usr/sbin/grubonce not found, not preparing bootloader
  time needed for sync: 0.5 seconds, time needed for grub: 0.0 seconds.
calculated image_size: 500
we are back from suspend, cleaning up.
...

This binary doesn't seem to exist in Debian at all. If it's needed it
has to be available, if not, it shouldn't be called.

Michael

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-1-686
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#397120: uswsusp: s2disk wants to run /usr/sbin/grubonce which doesn't exist

2006-11-05 Thread Michael Biebl
Hi Michael,

I don't quite see the problem (or bug) here. If grubonce exists,
powersaved makes use of it, otherwise not. It's not that suspend_to_disk
fails, if grubonce does not exist. powersaved just writes to the log
file, that it didn't find grubonce. I can see nothing wrong with that.
Could you please elaborate? Otherwise I'm going to close this bug report.

Cheers,
Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature