Bug#408768: gitweb: incorrect search form layout when $site_header is in use

[Matthijs Melchior]

Gerrit Pape wrote:
 On Sun, Jan 28, 2007 at 01:02:07PM +0100, Matthijs Melchior wrote:
   
 When $site_header is in use and some vertical space is added to the top
 of the web page, the search layout with CSS
 div.search {
  position: absolute;
  top: 56px;
  right: 12px
 }
 is incorrect and ends up to cover the git logo.

 Correcting this by using position: inherit; is complicated and may
 involve some code reorganization between
git_header_html();   andgit_print_page_nav(...); 

 Please forward this upstream for correction.
 

 Hi Matthijs, I did so, but received no response.  It looks like it has
 been fixed upstream in the meanwhile though, this is from 1.5.3.7, also
 available through backports.org:

  $ git show v1.5.3.7:gitweb/gitweb.css |grep -A7 search
  div.search {
  font-size: 100%;
  font-weight: normal;
  margin: 4px 8px;
  float: right;
  top: 56px;
  right: 12px
  }
  $ git show v1.5.3.7:gitweb/gitweb.css |grep position  
  position: relative;
  position: relative;
  $ 

 Can you confirm it's fixed?

 Thanks, Gerrit.
   
Yes, I have done some experiments with $site_header defined in
/etc/gitweb.conf and the behaviour is as expected.
The search field moves down with the rest of the page
as vertical space is added to the top.

So, yes I can confirm this is fixed in version 1.5.3.7.

Thanks.

-- 
Regards,
  -o)
Matthijs Melchior   Maarssen  /\\
[EMAIL PROTECTED]  Netherlands _\_v
 




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#408768: gitweb: incorrect search form layout when $site_header is in use

[Gerrit Pape]

On Sun, Jan 28, 2007 at 01:02:07PM +0100, Matthijs Melchior wrote:
 When $site_header is in use and some vertical space is added to the top
 of the web page, the search layout with CSS
 div.search {
   position: absolute;
   top: 56px;
   right: 12px
 }
 is incorrect and ends up to cover the git logo.
 
 Correcting this by using position: inherit; is complicated and may
 involve some code reorganization between
git_header_html();   andgit_print_page_nav(...); 
 
 Please forward this upstream for correction.

Hi Matthijs, I did so, but received no response.  It looks like it has
been fixed upstream in the meanwhile though, this is from 1.5.3.7, also
available through backports.org:

 $ git show v1.5.3.7:gitweb/gitweb.css |grep -A7 search
 div.search {
 font-size: 100%;
 font-weight: normal;
 margin: 4px 8px;
 float: right;
 top: 56px;
 right: 12px
 }
 $ git show v1.5.3.7:gitweb/gitweb.css |grep position  
 position: relative;
 position: relative;
 $ 

Can you confirm it's fixed?

Thanks, Gerrit.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#408768: gitweb: incorrect search form layout when $site_header is in use

[Matthijs Melchior]

Package: gitweb
Version: 1:1.4.4.4-1
Severity: normal

When $site_header is in use and some vertical space is added to the top
of the web page, the search layout with CSS
div.search {
position: absolute;
top: 56px;
right: 12px
}
is incorrect and ends up to cover the git logo.

Correcting this by using position: inherit; is complicated and may
involve some code reorganization between
   git_header_html();   andgit_print_page_nav(...); 

Please forward this upstream for correction.

Thanks,
Matthijs Melchior.

-- System Information:
Debian Release: 4.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3-686
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages gitweb depends on:
ii  git-core 1:1.4.4.4-1 content addressable filesystem
ii  perl 5.8.8-7 Larry Wall's Practical Extraction 

Versions of packages gitweb recommends:
ii  git-doc  1:1.4.4.4-1 content addressable filesystem (do

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]