Bug#493409: simutrans-pak64: FTBFS: Invalid image width

2008-08-03 Thread Ansgar Burchardt
reassign 493409 simutrans-makeobj
found 493409 100.0+ds1-2
notfound 493409 100.0-1
retitle 493409 simutrans-makeobj: [amd64] makeobj fails
thanks

This looks like a 64bit problem with makeobj.

I don't have access to an amd64 host right now, but maybe in ~2 weeks.
I will take a look then.

Regards,
Ansgar

-- 
PGP: 1024D/595FAD19  739E 2D09 0969 BEA9 9797  B055 DDB0 2FF7 595F AD19




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#493409: simutrans-pak64: FTBFS: Invalid image width

2008-08-03 Thread peter green
I have managed to fix it up so it doesn't error out but it produces 
different output on the two platforms. and i'm finding the code very 
hard to follow.


The first issue was a relatively simple one.

in utils/dr_rdpng.c some tweaking is required, replace the call to 
png_get_IHDR with


   //png_uint_32 is 64 bit on some architectures!
   png_uint_32 widthpu32,heightpu32;
   png_get_IHDR(
   png_ptr, info_ptr,
   widthpu32, heightpu32, bit_depth, color_type,
   interlace_type, NULL, NULL
   );
   *width = widthpu32;
   *height = heightpu32;

The second problem is that the compbination of calculations in 
obj_node_t::write_data and obj_node_t::write_data_at leads to negative 
offsets. I dunno what the correct fix is for that (I tried both 
replacing 4 with sizeof(obj_besch_t) and replacing sizeof(obj_besch_t) 
with 4) both stopped it crashing neither made it produce the same output 
as the i386 version.






--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#493409: simutrans-pak64: FTBFS: Invalid image width

2008-08-02 Thread Daniel Schepler
Package: simutrans-pak64
Version: 100.0-1
Severity: serious

From my pbuilder build log:

...
dh_testdir
/usr/bin/make all
make[1]: Entering directory `/tmp/buildd/simutrans-pak64-100.0'
=== PAK64 city_extra
libpng error: Invalid image width
make[1]: *** [city_extra] Error 1
make[1]: Leaving directory `/tmp/buildd/simutrans-pak64-100.0'
make: *** [build-stamp] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
-- 
Daniel Schepler




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#493409: simutrans-pak64: FTBFS: Invalid image width

2008-08-02 Thread Ansgar Burchardt
tags 493409 + unreproducible
thanks

Hi,

Daniel Schepler wrote:
 dh_testdir
 /usr/bin/make all
 make[1]: Entering directory `/tmp/buildd/simutrans-pak64-100.0'
 === PAK64 city_extra
 libpng error: Invalid image width
 make[1]: *** [city_extra] Error 1
 make[1]: Leaving directory `/tmp/buildd/simutrans-pak64-100.0'
 make: *** [build-stamp] Error 2
 dpkg-buildpackage: failure: debian/rules build gave error exit status 2

I can build the package in sid on i386 (using pbuilder as well).  What
architecture are you using?  What version of simutrans-makeobj do you
have installed?

Regards,
Ansgar

-- 
PGP: 1024D/595FAD19  739E 2D09 0969 BEA9 9797  B055 DDB0 2FF7 595F AD19




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#493409: simutrans-pak64: FTBFS: Invalid image width

2008-08-02 Thread Daniel Schepler
On Saturday 02 August 2008 10:28:01 Ansgar Burchardt wrote:
 tags 493409 + unreproducible
 thanks

 Hi,

 Daniel Schepler wrote:
  dh_testdir
  /usr/bin/make all
  make[1]: Entering directory `/tmp/buildd/simutrans-pak64-100.0'
  === PAK64 city_extra
  libpng error: Invalid image width
  make[1]: *** [city_extra] Error 1
  make[1]: Leaving directory `/tmp/buildd/simutrans-pak64-100.0'
  make: *** [build-stamp] Error 2
  dpkg-buildpackage: failure: debian/rules build gave error exit status 2

 I can build the package in sid on i386 (using pbuilder as well).  What
 architecture are you using?  What version of simutrans-makeobj do you
 have installed?

 Regards,
 Ansgar

I was using amd64, and simutrans-makeobj was a locally compiled version of 
100.0+ds1-2.
-- 
Daniel Schepler




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]