Bug#522836: zile: Assertion crash in auto-fill-mode

2009-04-07 Thread Reuben Thomas

On Mon, 6 Apr 2009, Tim wrote:


Oh, please take no offense, as none was intended.  I'm not even sure
what bug reports I might have submitted on the issue in the past, and
if I did, it probably didn't have enough detail.  It's just one of
those bugs that only pops up right in the middle of something and I
never find the time to come back and look into it.


Not at all, just wanted to reassure you that I'm on the case.

--
http://rrt.sc3d.org/ | Quidquid latine dictum sit, altum viditur (Anon)



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#522836: zile: Assertion crash in auto-fill-mode

2009-04-06 Thread Tim
Package: zile
Version: 2.3.4-1
Severity: grave
Justification: causes non-serious data loss


This bug has been in zile a *long* time, but I have never managed to
either write a detailed enough bug report or get anyone to care.
Previously this crash was a segfault... I guess we're making progress
now that it's an assert() failure... =P

Anyway, sometimes when zile is wrapping a line for me in
auto-fill-mode it crashes.  The assertion failure in the current
version is:

zile: astr.c:101: astr_nreplace_cstr: Assertion `pos = as-len' failed.
Aborted

This typically occurs when I'm wrapping a long line where I have to
hit the space bar several times in order to get it all wrapped,
leaving a long tail of spaces on the line.  (It would be nice if
auto-fill-mode behaved more like emacs' where it wraps the entire line
in one go.)

In order to reproduce, see the test.txt and .zile files which I will 
attach shortly.

Once you have the .zile in place, run `zile test.txt' and then switch
into auto-fill-mode by typing: M-x auto-fill-mode  

Next, go to the end of the long line (C-e) and start hitting space
bar.  The assertion fails for me after hitting space 3 times.  I'm
guessing this is some kind of integer overflow/underflow but I really
have no idea.  I haven't looked at the code.



-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages zile depends on:
ii  libc6 2.9-6  GNU C Library: Shared libraries
ii  libncurses5   5.7+20090321-1 shared libraries for terminal hand

zile recommends no packages.

zile suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#522836: zile: Assertion crash in auto-fill-mode

2009-04-06 Thread Reuben Thomas

On Mon, 6 Apr 2009, Tim wrote:


This bug has been in zile a *long* time, but I have never managed to
either write a detailed enough bug report or get anyone to care.


My dear sir, I'm not sure whether I've ever had a bug report from you, but I 
certainly *do* care, and have made several attempts over the years to fix 
paragraph filling. I'm sorry it's still causing grief...


Thanks very much for your detailed bug report, which enabled me to reproduce 
the bug. I've committed a fix to git, and will release 2.3.5 shortly. I 
can't promise this is the last bug in line wrapping; this one was specific 
to lines containing multiple spaces, as the call to delete-horizontal-space 
that line wrapping makes was not taken into account in subsequent 
positioning of point. Fortunately (to use a marker rather than making 
incorrect calculations) simplifies the code, so at least there's less to 
debug next time!


--
http://rrt.sc3d.org/
sane, a.  having tragedy in the heart and comedy in the head (Chesterton)
Listening to: 'To every thing there is a season' from 'Mass of the Children
and other sacred music' (The Cambridge Singers / John Rutter)



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#522836: zile: Assertion crash in auto-fill-mode

2009-04-06 Thread Tim
 This bug has been in zile a *long* time, but I have never managed to
 either write a detailed enough bug report or get anyone to care.

 My dear sir, I'm not sure whether I've ever had a bug report from you, 
 but I certainly *do* care, and have made several attempts over the years 
 to fix paragraph filling. I'm sorry it's still causing grief...

Oh, please take no offense, as none was intended.  I'm not even sure
what bug reports I might have submitted on the issue in the past, and
if I did, it probably didn't have enough detail.  It's just one of
those bugs that only pops up right in the middle of something and I
never find the time to come back and look into it.

 Thanks very much for your detailed bug report, which enabled me to 
 reproduce the bug. I've committed a fix to git, and will release 2.3.5 
 shortly. I can't promise this is the last bug in line wrapping; this one 
 was specific to lines containing multiple spaces, as the call to 
 delete-horizontal-space that line wrapping makes was not taken into 
 account in subsequent positioning of point. Fortunately (to use a marker 
 rather than making incorrect calculations) simplifies the code, so at 
 least there's less to debug next time!

Great, I'm glad to hear it.  Thanks for your very quick response and
your ongoing hard work on zile.

Best regards,
tim



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org