Bug#536989: dh-make-perl: FTBFS: tests failed
On Fri, Jul 24, 2009 at 11:45:01AM -0700, Ryan Niebur wrote:
On Mon, Jul 20, 2009 at 11:47:44AM +0300, Damyan Ivanov wrote:
-=| Ryan Niebur, Mon, Jul 20, 2009 at 12:17:46AM -0700 |=-
On Mon, Jul 20, 2009 at 10:00:41AM +0300, Damyan Ivanov wrote:
I assume (and this worked so far) that each module in
/usr/{share,lib}/perl/$version is a core one. If this not true, then
we just can't do anything but trust Module::CoreList and t/corelist.t
shall be rewritten to simply check a couple of modules we know are
core ones instead of going over the directories.
On second thought, I think this is the way to go. The test wanted to
test if the core module detection in dh-make-perl works. Thta
detection heavily relies to Module::CoreList, so a simple test would
work fine. Perhaps adding a negative test about 'Foo::Bar' being core
would suffice to guarantee that there is no a 'return 1' type of
'detection'.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#536989: dh-make-perl: FTBFS: tests failed
Hi!
On Mon, Jul 20, 2009 at 11:47:44AM +0300, Damyan Ivanov wrote:
-=| Ryan Niebur, Mon, Jul 20, 2009 at 12:17:46AM -0700 |=-
On Mon, Jul 20, 2009 at 10:00:41AM +0300, Damyan Ivanov wrote:
I think the right fix would be in Module::CoreList. Luckily we
maintain libmodule-corelist-perl and dh-make-perl already depends on
it. A fix may be propagated upstream in the next point release (and
end up in perl-modules).
I assume (and this worked so far) that each module in
/usr/{share,lib}/perl/$version is a core one. If this not true, then
we just can't do anything but trust Module::CoreList and t/corelist.t
shall be rewritten to simply check a couple of modules we know are
core ones instead of going over the directories.
I somehow that Module::CoreList is wrong here, so this better be fixed
there upstream (and patched in libmodule-correlist-perl until upstream
releases a fixed dist).
I think this module is Debian (or admin) specific tho and not a real
module, since it's for configuration. so it seems very wrong for
Module::CoreList to list this.
OK. What I try to avoid is keeping a list of exceptions. This will
break the next time such a module appears.
true.
I was thinking if we can exclude all modules found under /etc/perl? Or
but it's not under /etc/perl.
is there a non-zero change for true core modules to appear there?
what do you mean by this?
--
_
Ryan Niebur
ryanrya...@gmail.com
signature.asc
Description: Digital signature
Bug#536989: dh-make-perl: FTBFS: tests failed
On Sun, Jul 19, 2009 at 10:16:23PM -0700, Ryan Niebur wrote: On Tue, Jul 14, 2009 at 04:50:28PM +0200, gregor herrmann wrote: From perl's changelog: perl (5.10.0-24) unstable; urgency=low [..] * Save local versions of CPANPLUS::Config::System into /etc/perl. (See #533707) lib/DhMakePerl.pm's is_core_module() uses libmodule-corelist-perl's Module::CoreList which probably doesn't know anything about CPANPLUS::Config::System ... I'm not sure where to fix this actually ... nothing on CPAN will depend on CPANPLUS::Config::System unless it's broken. so I propose this patch. what do others think? Yeah, special-casing it in dh-make-perl is the only good short-term solution I can think of. Patching Module::Corelist for Debian to include CPANPLUS::Config::System doesn't seem right. Longer term, I wonder if we should put together a Module::Corelist::Debian (or Module::Corelist::Distro::*) inheriting from Module::Corelist and containing information about the versions of the Debian perl package and quirks like this. This touches an issue with Debian-specific patches to core modules: the core convention is to always increase $VERSION for any change, but there's no separate namespace for vendors so we can't do that easily. Thus our CPANPLUS::Internals::Constants 0.01 is different from the upstream one. Perhaps this information could go in the prospective Module::Corelist::Debian too... Cheers, -- Niko Tyni nt...@debian.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#536989: dh-make-perl: FTBFS: tests failed
-=| Ryan Niebur, Sun, Jul 19, 2009 at 10:16:23PM -0700 |=-
On Tue, Jul 14, 2009 at 04:50:28PM +0200, gregor herrmann wrote:
From perl's changelog:
perl (5.10.0-24) unstable; urgency=low
[..]
* Save local versions of CPANPLUS::Config::System into /etc/perl.
(See #533707)
lib/DhMakePerl.pm's is_core_module() uses libmodule-corelist-perl's
Module::CoreList which probably doesn't know anything about
CPANPLUS::Config::System ...
I'm not sure where to fix this actually ...
nothing on CPAN will depend on CPANPLUS::Config::System unless it's
broken. so I propose this patch. what do others think?
[...]
+next if($_ eq CPANPLUS::Config::System);
I think the right fix would be in Module::CoreList. Luckily we
maintain libmodule-corelist-perl and dh-make-perl already depends on
it. A fix may be propagated upstream in the next point release (and
end up in perl-modules).
I assume (and this worked so far) that each module in
/usr/{share,lib}/perl/$version is a core one. If this not true, then
we just can't do anything but trust Module::CoreList and t/corelist.t
shall be rewritten to simply check a couple of modules we know are
core ones instead of going over the directories.
I somehow that Module::CoreList is wrong here, so this better be fixed
there upstream (and patched in libmodule-correlist-perl until upstream
releases a fixed dist).
--
dam
signature.asc
Description: Digital signature
Bug#536989: dh-make-perl: FTBFS: tests failed
On Mon, Jul 20, 2009 at 10:00:41AM +0300, Damyan Ivanov wrote:
I think the right fix would be in Module::CoreList. Luckily we
maintain libmodule-corelist-perl and dh-make-perl already depends on
it. A fix may be propagated upstream in the next point release (and
end up in perl-modules).
I assume (and this worked so far) that each module in
/usr/{share,lib}/perl/$version is a core one. If this not true, then
we just can't do anything but trust Module::CoreList and t/corelist.t
shall be rewritten to simply check a couple of modules we know are
core ones instead of going over the directories.
I somehow that Module::CoreList is wrong here, so this better be fixed
there upstream (and patched in libmodule-correlist-perl until upstream
releases a fixed dist).
I think this module is Debian (or admin) specific tho and not a real
module, since it's for configuration. so it seems very wrong for
Module::CoreList to list this.
--
_
Ryan Niebur
ryanrya...@gmail.com
signature.asc
Description: Digital signature
Bug#536989: dh-make-perl: FTBFS: tests failed
-=| Ryan Niebur, Mon, Jul 20, 2009 at 12:17:46AM -0700 |=-
On Mon, Jul 20, 2009 at 10:00:41AM +0300, Damyan Ivanov wrote:
I think the right fix would be in Module::CoreList. Luckily we
maintain libmodule-corelist-perl and dh-make-perl already depends on
it. A fix may be propagated upstream in the next point release (and
end up in perl-modules).
I assume (and this worked so far) that each module in
/usr/{share,lib}/perl/$version is a core one. If this not true, then
we just can't do anything but trust Module::CoreList and t/corelist.t
shall be rewritten to simply check a couple of modules we know are
core ones instead of going over the directories.
I somehow that Module::CoreList is wrong here, so this better be fixed
there upstream (and patched in libmodule-correlist-perl until upstream
releases a fixed dist).
I think this module is Debian (or admin) specific tho and not a real
module, since it's for configuration. so it seems very wrong for
Module::CoreList to list this.
OK. What I try to avoid is keeping a list of exceptions. This will
break the next time such a module appears.
I was thinking if we can exclude all modules found under /etc/perl? Or
is there a non-zero change for true core modules to appear there?
--
dam
signature.asc
Description: Digital signature
Bug#536989: dh-make-perl: FTBFS: tests failed
On Tue, Jul 14, 2009 at 04:50:28PM +0200, gregor herrmann wrote:
From perl's changelog:
perl (5.10.0-24) unstable; urgency=low
[..]
* Save local versions of CPANPLUS::Config::System into /etc/perl.
(See #533707)
lib/DhMakePerl.pm's is_core_module() uses libmodule-corelist-perl's
Module::CoreList which probably doesn't know anything about
CPANPLUS::Config::System ...
I'm not sure where to fix this actually ...
nothing on CPAN will depend on CPANPLUS::Config::System unless it's
broken. so I propose this patch. what do others think?
Index: t/corelist.t
===
--- t/corelist.t(revision 40255)
+++ t/corelist.t(working copy)
@@ -29,5 +29,7 @@
s{/}{::}g;
s/\.pm$//;
+next if($_ eq CPANPLUS::Config::System);
+
ok( $maker-is_core_module($_), $_ is core );
}
--
_
Ryan Niebur
ryanrya...@gmail.com
signature.asc
Description: Digital signature
Bug#536989: dh-make-perl: FTBFS: tests failed
tags 536989 + confirmed thanks On Tue, 14 Jul 2009 09:19:08 -0400, Lucas Nussbaum wrote: During a rebuild of all packages in sid, your package failed to build on amd64. # Failed test 'CPANPLUS::Config::System is core' # at t/corelist.t line 32. # Looks like you failed 1 test of 530. t/corelist..dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 300 Failed 1/530 tests, 99.81% okay Confirmed. From perl's changelog: perl (5.10.0-24) unstable; urgency=low [..] * Save local versions of CPANPLUS::Config::System into /etc/perl. (See #533707) lib/DhMakePerl.pm's is_core_module() uses libmodule-corelist-perl's Module::CoreList which probably doesn't know anything about CPANPLUS::Config::System ... I'm not sure where to fix this actually ... Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG Key IDs: 0x00F3CFE4, 0x8649AA06 : :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `-NP: Sting: Moon Over Bourbon Street signature.asc Description: Digital signature
Bug#536989: dh-make-perl: FTBFS: tests failed
Package: dh-make-perl Version: 0.57 Severity: serious User: debian...@lists.debian.org Usertags: qa-ftbfs-20090713 qa-ftbfs Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part: /usr/bin/fakeroot debian/rules clean dh clean dh_testdir dh_auto_clean dh_clean #rm -f build-stamp # clean after test packages for i in Strange-0.1 Strange-2.1; do\ if test -d t/dists/$i/debian; then \ ( \ cd t/dists/$i \ debian/rules clean \ cd .. \ rm -rf $i/debian; \ ) \ fi \ done dpkg-source -b dh-make-perl-0.57 dpkg-source: info: using source format `1.0' dpkg-source: info: building dh-make-perl in dh-make-perl_0.57.tar.gz dpkg-source: info: building dh-make-perl in dh-make-perl_0.57.dsc debian/rules build NO_NETWORK=1 dh build dh_testdir dh_auto_configure WARNING: the following files are missing in your kit: META.yml Please inform the author. Checking whether your kit is complete... Checking prerequisites... Looks good Creating new 'Build' script for 'DhMakePerl' version '0.57' dh_auto_build Copying lib/Debian/AptContents.pm - blib/lib/Debian/AptContents.pm Copying lib/Debian/Dependency.pm - blib/lib/Debian/Dependency.pm Copying lib/Debian/Version.pm - blib/lib/Debian/Version.pm Copying lib/Debian/Dependencies.pm - blib/lib/Debian/Dependencies.pm Copying lib/Debian/Control/Stanza/Source.pm - blib/lib/Debian/Control/Stanza/Source.pm Copying lib/DhMakePerl.pm - blib/lib/DhMakePerl.pm Copying lib/Debian/Control/Stanza.pm - blib/lib/Debian/Control/Stanza.pm Copying lib/DhMakePerl/PodParser.pm - blib/lib/DhMakePerl/PodParser.pm Copying lib/Debian/Control.pm - blib/lib/Debian/Control.pm Copying lib/Debian/Control/FromCPAN.pm - blib/lib/Debian/Control/FromCPAN.pm Copying lib/DhMakePerl/Config.pm - blib/lib/DhMakePerl/Config.pm Copying lib/Debian/Control/Stanza/Binary.pm - blib/lib/Debian/Control/Stanza/Binary.pm Copying dh-make-perl - blib/script/dh-make-perl Deleting blib/script/dh-make-perl.bak Copying share/rules.dh7.noxs - blib/share/rules.dh7.noxs Copying share/rules.dh7+quilt.xs+noxs - blib/share/rules.dh7+quilt.xs+noxs Copying share/rules.MakeMaker.xs - blib/share/rules.MakeMaker.xs Copying share/rules.MakeMaker.noxs - blib/share/rules.MakeMaker.noxs Copying share/rules.dh7.xs - blib/share/rules.dh7.xs Copying share/rules.Module-Build.xs - blib/share/rules.Module-Build.xs Copying share/rules.dh7.tiny - blib/share/rules.dh7.tiny Copying share/overrides - blib/share/overrides Copying share/rules.Module-Build.noxs - blib/share/rules.Module-Build.noxs Manifying blib/script/dh-make-perl - blib/bindoc/dh-make-perl.1p Manifying blib/lib/Debian/Control/Stanza/Binary.pm - blib/libdoc/Debian::Control::Stanza::Binary.3pm Manifying blib/lib/Debian/Control/FromCPAN.pm - blib/libdoc/Debian::Control::FromCPAN.3pm Manifying blib/lib/Debian/Dependencies.pm - blib/libdoc/Debian::Dependencies.3pm Manifying blib/lib/DhMakePerl.pm - blib/libdoc/DhMakePerl.3pm Manifying blib/lib/Debian/Control.pm - blib/libdoc/Debian::Control.3pm Manifying blib/lib/Debian/Control/Stanza/Source.pm - blib/libdoc/Debian::Control::Stanza::Source.3pm Manifying blib/lib/DhMakePerl/Config.pm - blib/libdoc/DhMakePerl::Config.3pm Manifying blib/lib/Debian/Dependency.pm - blib/libdoc/Debian::Dependency.3pm Manifying blib/lib/Debian/AptContents.pm - blib/libdoc/Debian::AptContents.3pm Manifying blib/lib/DhMakePerl/PodParser.pm - blib/libdoc/DhMakePerl::PodParser.3pm Manifying blib/lib/Debian/Version.pm - blib/libdoc/Debian::Version.3pm Manifying blib/lib/Debian/Control/Stanza.pm - blib/libdoc/Debian::Control::Stanza.3pm dh_auto_test # Testing DhMakePerl 0.57, Perl 5.01, /usr/bin/perl t/00-load...ok t/AptContents...ok t/Control...ok t/Dep...ok t/Dependencies..ok t/core-modules..ok # Failed test 'CPANPLUS::Config::System is core' # at t/corelist.t line 32. # Looks like you failed 1 test of 530. t/corelist..dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 300 Failed 1/530 tests, 99.81% okay t/debian-versionok t/dists.ok t/extract_name_ver_from_makefileok t/perl-deps.ok t/perl-versions.ok t/pod-coverage..skipped all skipped: POD coverage is not full. set TEST_POD_COVERAGE if you want to see what is missing. Failed 1/14 test programs. 1/811 subtests failed. dh_auto_test: perl returned exit code 255 make: *** [build-stamp] Error 1 The full build log is available from:
