Bug#599625: unblock: tcc/0.9.25-5

2010-10-10 Thread Adam D. Barratt 
[Was this intentionally not sent to the bug? If not then please direct
follow-ups there as well]

On Sun, 2010-10-10 at 03:02 +0200, Thomas Preud'homme wrote:
 Le samedi 09 octobre 2010 20:56:01, vous avez écrit :
  +--- a/libtcc.c
   b/libtcc.c
  +@@ -1431,7 +1431,11 @@ static void rt_printline(unsigned long wanted_pc)
  [...]
  ++#ifdef STT_IFUNC
  ++if ((type == STT_FUNC) || (type == STT_GNU_IFUNC)) {
  
  Should the ifdef not also refer to STT_GNU_IFUNC?  This appears to be
  the only occurrence of STT_IFUNC in the package.
 No it should not. In fact the ifdef should simply go away. But part of the 
 code is really not important. It's about displaying source line number in 
 case 
 of runtime error and the function in which the error is. As the ifdef isn't 
 correct (it should  use STT_GNU_IFUNC or simply not exists), and the function 
 where the error happen is a STT_GNU_IFUNC symbol, it won't display the 
 function name but just the PC. In other words, it's not a regression and as 
 only string functions in (e)glibc seems to use STT_GNU_IFUNC the effect is 
 limited.

So the code works, but has unhelpful (at least, not as helpful as it
could be) reporting in the case of errors?

Regards,

Adam




--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#599625: unblock: tcc/0.9.25-5

2010-10-09 Thread Thomas Preud'homme 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: freeze-exception

Please unblock package tcc

tcc in squeeze is unable to link a program into an executable on amd64
when it uses string functions (strlen and co). As almost all C program
use string functions, I consider this bug serious. The version in
unstable contains a fix and it consists of just a few lines. The fix
was introduced in tcc 0.9.25-4 which stayed in unstable for almost 2
months without bringing any new bug. Version 0.9.25-5 is there only for
a few days but the only change is to drop armel architecture as tcc
doesn't build on armel because of a failure in the test suite.

Changes between version 0.9.25-3 are:

tcc (0.9.25-5) unstable; urgency=low

  * Drop support for armel arch.
  = tcc has never built on armel

tcc (0.9.25-4) unstable; urgency=low

  * Fix bashims in configure and gcctestsuite.sh.
  = This is a release goal.

  * Add support for indirect functions as externals.
  = This is the few line fix.

  * Bump Standard-Version from 3.8.4 to 3.9.1 (no changes needed).
  * debian/control:
- Improve package description for libtcc-dev.
  = If this last change causes a problem with regards to the
  translations I can make a new upload without the improved description

Best regards and good luck for the squeeze release.

unblock tcc/0.9.25-5

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#599625: unblock: tcc/0.9.25-5

2010-10-09 Thread Adam D. Barratt 
On Sat, 2010-10-09 at 19:47 +0200, Thomas Preud'homme wrote:
 tcc in squeeze is unable to link a program into an executable on amd64
 when it uses string functions (strlen and co). As almost all C program
 use string functions, I consider this bug serious. The version in
 unstable contains a fix and it consists of just a few lines. The fix
 was introduced in tcc 0.9.25-4 which stayed in unstable for almost 2
 months without bringing any new bug.

+--- a/libtcc.c
 b/libtcc.c
+@@ -1431,7 +1431,11 @@ static void rt_printline(unsigned long wanted_pc)
[...]
++#ifdef STT_IFUNC
++if ((type == STT_FUNC) || (type == STT_GNU_IFUNC)) {

Should the ifdef not also refer to STT_GNU_IFUNC?  This appears to be
the only occurrence of STT_IFUNC in the package.

 Version 0.9.25-5 is there only for
 a few days but the only change is to drop armel architecture as tcc
 doesn't build on armel because of a failure in the test suite.

p-a-s still says that tcc should be built on armel; that should also be
fixed.

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org