Bug#600446: Possible typo in /lib/udev/rules.d/70-acl.rules: closing double quote in last line missing

2010-10-17 Thread Alexander Kurtz
Package: udev
Version: 163-1

Hi,

while comparing /lib/udev/rules.d/70-acl.rules from 163-1 to the version
shipped in 160-1 (because of #593881, full diff attached) I found this:

$ tail udev_163-1_i386/lib/udev/rules.d/70-acl.rules

# Glib is not declared as a package dependency, so check that it is 
actually
# installed before running udev-acl.
TEST!=/lib/libglib-2.0.so.0, GOTO=acl_end

# apply ACL for all locally logged in users
TAG==udev-acl, TEST==/var/run/ConsoleKit/database, \
  RUN+=udev-acl --action=$env{ACTION} --device=$env{DEVNAME}

LABEL=acl_end
$

Is the missing closing double quote in the last line intentional?

Best regards

Alexander Kurtz
--- /lib/udev/rules.d/70-acl.rules	2010-07-12 03:24:40.0 +0200
+++ udev_163-1_i386/lib/udev/rules.d/70-acl.rules	2010-10-17 00:46:27.0 +0200
@@ -13,11 +13,7 @@
 # digicams with proprietary protocol
 ENV{ID_GPHOTO2}==*?, TAG+=udev-acl
 
-# SCSI scanners
-KERNEL==sg[0-9]*, ATTRS{type}==6, TAG+=udev-acl
-KERNEL==sg[0-9]*, ATTRS{type}==3, ATTRS{vendor}==HP|EPSON|Epson, TAG+=udev-acl
-
-# USB scanners
+# SCSI and USB scanners
 ENV{libsane_matched}==yes, TAG+=udev-acl
 
 # HPLIP devices (necessary for ink level check and HP tool maintenance)
@@ -37,21 +33,15 @@
 
 # IIDC devices: industrial cameras and some webcams
 SUBSYSTEM==firewire, ATTR{units}==*0x00a02d:0x00010*,  TAG+=udev-acl
+SUBSYSTEM==firewire, ATTR{units}==*0x00b09d:0x00010*,  TAG+=udev-acl
 # AV/C devices: camcorders, set-top boxes, TV sets, audio devices, and more
 SUBSYSTEM==firewire, ATTR{units}==*0x00a02d:0x010001*, TAG+=udev-acl
+SUBSYSTEM==firewire, ATTR{units}==*0x00a02d:0x014001*, TAG+=udev-acl
 
 # old style firewire devices
 KERNEL==dv1394-[0-9]*, TAG+=udev-acl
 KERNEL==video1394-[0-9]*, TAG+=udev-acl
 
-# fingerprint readers
-SUBSYSTEM==usb, ATTR{idVendor}==0483, ATTR{idProduct}==2016, TAG+=udev-acl
-
-# GPS devices
- # Garmin GPSMap 60
-SUBSYSTEM==usb, ATTR{idVendor}==091e, ATTR{idProduct}==0003, TAG+=udev-acl
-
-
 # DRI video devices
 SUBSYSTEM==drm, KERNEL==card*, TAG+=udev-acl
 
@@ -64,22 +54,23 @@
 # joysticks
 SUBSYSTEM==input, ENV{ID_INPUT_JOYSTICK}==?*, TAG+=udev-acl
 
-# smart phones
-SUBSYSTEM==usb, ATTR{idVendor}==0bb4, ATTR{idProduct}==0c02, TAG+=udev-acl
-
 # color measurement devices
 ENV{COLOR_MEASUREMENT_DEVICE}==*?, TAG+=udev-acl
 
+# DDC/CI device, usually high-end monitors such as the DreamColor
+ENV{DDC_DEVICE}==*?, TAG+=udev-acl
+
 LABEL=acl_apply
 
-ENV{ACL_MANAGE}!=1, GOTO=acl_end
+# workaround to support buggy packages which use the old interface
+ENV{ACL_MANAGE}==1, TAG+=udev-acl
 
 # Glib is not declared as a package dependency, so check that it is actually
 # installed before running udev-acl.
 TEST!=/lib/libglib-2.0.so.0, GOTO=acl_end
 
 # apply ACL for all locally logged in users
-TEST==/var/run/ConsoleKit/database, \
+TAG==udev-acl, TEST==/var/run/ConsoleKit/database, \
   RUN+=udev-acl --action=$env{ACTION} --device=$env{DEVNAME}
 
-LABEL=acl_end
+LABEL=acl_end


signature.asc
Description: This is a digitally signed message part


Bug#600446: Possible typo in /lib/udev/rules.d/70-acl.rules: closing double quote in last line missing

2010-10-17 Thread Marco d'Itri
On Oct 17, Alexander Kurtz kurtz.a...@googlemail.com wrote:

   LABEL=acl_end
   $
 
 Is the missing closing double quote in the last line intentional?
No, looks like the editor eat it.
I will fix this in the next upload, but thankfully it has no noticeable
side effects.

-- 
ciao,
Marco


signature.asc
Description: Digital signature