Bug#634412: ext3grep: FTBFS: superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not, declared in this scope
Le dimanche 08 janv. 2012 à 03:07:39 (+0100 CET), peter green a écrit : Thanks again for your patch. Everything seems to work OK but as I normally don't use ext3grep, I let regular users test by themselves and will then upload the package. It doesn't seem any regular users responded to your request, I tried to put the word out wider on debian-user and the debian forums but noone responded there either. Where do we go from here? I have pinged other members of the forensics team. As a user of ext3grep, do you want me to build packages that you could test? If so, which architecture? P.S. a duplicate of this bug has been filed, I guess the filer didn't spot this one because it was marked as pending. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654201 I have just forcibly merged these bugs. Cheers, Julien -- .''`. Julien Valroff ~ jul...@kirya.net ~ jul...@debian.org : :' : Debian Developer Free software contributor `. `'` http://www.kirya.net/ `- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#634412: ext3grep: FTBFS: superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not, declared in this scope
Thanks again for your patch. Everything seems to work OK but as I normally don't use ext3grep, I let regular users test by themselves and will then upload the package. It doesn't seem any regular users responded to your request, I tried to put the word out wider on debian-user and the debian forums but noone responded there either. Where do we go from here? P.S. a duplicate of this bug has been filed, I guess the filer didn't spot this one because it was marked as pending. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654201 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#634412: ext3grep: FTBFS: superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not, declared in this scope
tags 634412 + pending thanks Hi Peter, Le samedi 10 déc. 2011 à 08:14:27 (+0100 CET), peter green a écrit : I just did a test build on current sid and ran into failures but they were different from the failure reported in the bug report. I guess the headers have changed again since this bug was reported. Anyway the attatched patch makes the code build in current sid. Thanks Peter for your help. I have pushed your patch to the git repository for the upcoming package upload. Could anyone familiar with ext3grep test the new release so that we can upload it to sid ASAP? Cheers, Julien -- .''`. Julien Valroff ~ jul...@kirya.net ~ jul...@debian.org : :' : Debian Developer Free software contributor `. `'` http://www.kirya.net/ `- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#634412: ext3grep: FTBFS: superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not, declared in this scope
Hi Peter, Le samedi 10 déc. 2011 à 08:14:27 (+0100 CET), peter green a écrit : [...] +#ifndef i_reseved2 +//i_reseved2 has been split into two fields in recent Shouldn't it be i_reserved2? Cheers, Julien -- .''`. Julien Valroff ~ jul...@kirya.net ~ jul...@debian.org : :' : Debian Developer Free software contributor `. `'` http://www.kirya.net/ `- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#634412: ext3grep: FTBFS: superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not, declared in this scope
Julien Valroff wrote: Hi Peter, Le samedi 10 déc. 2011 à 08:14:27 (+0100 CET), peter green a écrit : [...] +#ifndef i_reseved2 +//i_reseved2 has been split into two fields in recent Shouldn't it be i_reserved2? Yes, sorry for the typos. The ifndef isn't really nessacery I just thought was nicer to only apply the trick when it was actually needed. Cheers, Julien -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#634412: ext3grep: FTBFS: superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not, declared in this scope
Le samedi 10 déc. 2011 à 14:07:46 (+0100 CET), peter green a écrit : Julien Valroff wrote: Hi Peter, Le samedi 10 déc. 2011 à 08:14:27 (+0100 CET), peter green a écrit : [...] +#ifndef i_reseved2 +//i_reseved2 has been split into two fields in recent Shouldn't it be i_reserved2? Yes, sorry for the typos. I have fixed this in git. The ifndef isn't really nessacery I just thought was nicer to only apply the trick when it was actually needed. Thanks again for your patch. Everything seems to work OK but as I normally don't use ext3grep, I let regular users test by themselves and will then upload the package. Cheers, Julien -- .''`. Julien Valroff ~ jul...@kirya.net ~ jul...@debian.org : :' : Debian Developer Free software contributor `. `'` http://www.kirya.net/ `- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#634412: ext3grep: FTBFS: superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not, declared in this scope
tags 634412 +patch
thanks
I just did a test build on current sid and ran into failures but they
were different from the failure reported in the bug report. I guess the
headers have changed again since this bug was reported.
Anyway the attatched patch makes the code build in current sid.
diff -ur ext3grep-0.10.1/src/ext3.h ext3grep-0.10.1.new/src/ext3.h
--- ext3grep-0.10.1/src/ext3.h 2008-04-09 11:20:31.0 +
+++ ext3grep-0.10.1.new/src/ext3.h 2011-12-10 07:00:50.0 +
@@ -24,6 +24,17 @@
#ifndef EXT3_H
#define EXT3_H
+// this trickery needs to happen before ext2_fs is included so
+// bail out if it has already been included by another path
+#ifdef _LINUX_EXT2_FS_H
+ #error please include this file before any other includes of ext2fs/ext2_fs.h
+#endif
+
+// some versions of the ext2 headers call this s_frags_per_group and some
+// call it s_clusters_per_group, define one to the other so our code works
+// with both
+#define s_clusters_per_group s_frags_per_group
+
// Use the header files from e2progs (http://e2fsprogs.sourceforge.net)
// We can use these headers and then everything named ext2 or ext3.
#include ext2fs/ext2_fs.h // Definitions of ext2, ext3 and ext4.
@@ -110,6 +121,12 @@
__u32 faddr(void) const { return i_faddr; }
__u16 uid_high(void) const { return i_uid_high; }
__u16 gid_high(void) const { return i_gid_high; }
+#ifndef i_reseved2
+//i_reseved2 has been split into two fields in recent
+//versions of the headers, luckilly we can still access
+//it in one peice through the hurd side of the union
+#define i_reserved2 osd2.hurd2.h_i_author
+#endif
__u32 reserved2(void) const { return i_reserved2; }
void set_reserved2(__u32 val) { i_reserved2 = val; }
Bug#634412: ext3grep: FTBFS: superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not declared in this scope
Source: ext3grep Version: 0.10.1-3.1 Severity: serious Tags: wheezy sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20110718 qa-ftbfs Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part: g++ -DHAVE_CONFIG_H -I. -I..-g -O2 -DUSE_MMAP=1 -I/usr/include/ext2fs -I/usr/include/et-include pch.h -c -o ext3grep-custom.o `test -f 'custom.cc' || echo './'`custom.cc In file included from conversion.h:27:0, from custom.cc:35: superblock.h: In function 'int fragment_size(const ext3_super_block)': superblock.h:35:99: error: 'EXT2_FRAG_SIZE' was not declared in this scope make[4]: *** [ext3grep-custom.o] Error 1 The full build log is available from: http://people.debian.org/~lucas/logs/2011/07/18/ext3grep_0.10.1-3.1_lsid64.buildlog A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on about 50 AMD64 nodes of the Grid'5000 platform, using a clean chroot. Internet was not accessible from the build systems. -- | Lucas Nussbaum | lu...@lucas-nussbaum.net http://www.lucas-nussbaum.net/ | | jabber: lu...@nussbaum.fr GPG: 1024D/023B3F4F | -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
