Bug#670412: geli init script fails if /etc/default/geli is unconfigured
Package: geom Version: 9.0+ds1-3 The geli init script fails if no geli devices are configured in /etc/fstab and /etc/default/geli. This prevented an upgrade of geom and freebsd-geom: [...] Setting up geom (9.0+ds1-3) ... Starting GELI subsystem...UNCONFIGURED. See /etc/default/geli ... failed! invoke-rc.d: initscript geli, action start failed. dpkg: error processing geom (--configure): subprocess installed post-installation script returned error exit status 1 configured to not write apport reports dpkg: dependency problems prevent configuration of freebsd-geom: freebsd-geom depends on geom; however: Package geom is not configured yet. dpkg: error processing freebsd-geom (--configure): dependency problems - leaving unconfigured [...] As geom contains more than just geli it is imho wrong to print an error (warning is fine ofc), but it certainly is wrong to fail the init script. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#670412: geli init script fails if /etc/default/geli is unconfigured
On 25/04/12 12:52, Stefan Bühler wrote: Setting up geom (9.0+ds1-3) ... Starting GELI subsystem...UNCONFIGURED. See /etc/default/geli ... failed! invoke-rc.d: initscript geli, action start failed. dpkg: error processing geom (--configure): subprocess installed post-installation script returned error exit status 1 Hi, The initscript will need to return zero exit status in this case (Debian policy seems to allow that, despite contradictory LSB policy). But there is still a choice in how this can be displayed: 1. With existing log_failure_msg: Starting GELI subsystem... UNCONFIGURED. See /etc/default/geli ... failed! 2. With log_success_msg (with implicit log_end_msg 0 = 'ok') : Starting GELI subsystem... UNCONFIGURED. See /etc/default/geli. 3. With log_warning_msg (with implicit log_end_msg 255 = 'warning') : Starting GELI subsystem... UNCONFIGURED. See /etc/default/geli (warning). And if we get the fancy new lsb-base (4.1+Debian0+fancy1) in Wheezy, these would be preceded by [FAIL], [ ok ] or [warn] coloured red/green/yellow respectively. I think I prefer option 3, and also fixing the screaming capital letters. That seems the best way to communicate a not-quite-successful status, so the administrator is encouraged to either properly configure it or remove it. Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#670412: geli init script fails if /etc/default/geli is unconfigured
On 26/04/12 00:21, Steve Fouchet wrote: It can be bypass if you initialise $geli_devices with any value in /etc/default/geli. ex : geli_devices=da75 then geli start and booting process/ packages configuration can continue. Thanks... that would work around this problem, yes. The package needed fixing though, otherwise it breaks the install/upgrade process, like for users who haven't created their geli devices yet. Or some users might want to install the geli tools but don't want to initialise any devices at boot time. I've committed a fix to SVN for the next upload of freebsd-utils which: * exits the initscript with status 0 -- that fixes the error seen during dpkg/apt-get; * shows this warning at startup, if no geli devices are configured: [warn] Starting GELI subsystem: not configured; see /etc/default/geli (warning). Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
