Bug#681387: unblock: resiprocate (follow up)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, Can anyone please let me know about the unblock request? Is more information needed, more time in unstable, etc? Regards, Daniel http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=681387 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJQlq6PAAoJEOm1uwJp1aqDMY0P/09B7KySli+lL1TA6zSS5uF/ LBB52EjW8dAuQajZ3c/D+foSPgl4yVneVuyogG0UvC0fV1vYGJ6eCh8WDjLC+FPY UTwp1i6EU3Wns8P+D7oFJSzjtLZzeT/AbIKvm6s5GyTND6TisMO7y+dVD/wGfsel qGUF+cmVFxXN8rM4wGJyLXgHtTYNMAJnFN79bb2zVxc8jKKev5fcDNyZQZ3P/A67 gHIYBmHgPpAjIYsZY3meLHju8UPdqfxhkjQ+1qdEEsrRL1Zy9UTHMPVjXwQg97+a B3GSw86aIEnUJqMYYqhwwUtTLLJ84JCFpvgHOFey+uP6VOFrugfOAuuvWRvQNUgf MkN2VRYIecBk1jJzCIzVVRniQkFQr4g4ycvtn4ybi0xoAq8AuZJOYMEvcKNFJ/yg wz9PpK6q4SOjzUrBBe8E9HVRiMAaaR+jW19GkiuF2PjnnxXmC9/EijjsSYX2BqUH huIFPOsd5SB6z1RdnAq9UWn7UpTGFBInmnJN8VU59KGm2Qy3bBSiLfBUe1OfUyT3 X2AG2+0CbrjXtlIPEH3gHqOegXaeausql0aAg/J6nfrFK6zszWKeNg5VQNXjQ5Uo C6IwMmEunYNaOn86daYnlpiXdTystCWozAdyVD7dn+NVVFf+2g47OZl0bwHlV6Zt p09dILoS+NBX54MDq+PG =kfYp -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681387: unblock: resiprocate (follow up)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 10/10/12 09:48, Julien Cristau wrote: On Tue, Jul 24, 2012 at 13:06:14 +, Daniel Pocock wrote: --- these changes update the sipdialer binary package only, making it use the config file parser classes. This means it now uses the same config format as repro and reTurnServer What does that mean for existing configuration files? Anyone who has used the sipdialer package from v1.8.2 and created a config file in their home directory will need to adapt the config file (adding an `=' symbol after each parameter name) All parameter names and values remain the same. There is no global config file for sipdialer so the package can't update it. This doesn't impact any of the other packages built from the resiprocate source package. The 1.8.2 release only existed upstream and in Debian for a short period of time (the package is new for wheezy and doesn't exist in squeeze), popcon shows only two installs of sipdialer, so it is unlikely that many people have such config files. http://qa.debian.org/popcon.php?package=resiprocate -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJQdTaGAAoJEOm1uwJp1aqDAiMQAIHiArlBp49uxYhr1wty7K7z ugfrslk+aI9gLxdPX7Jka6OZuYyar4MbKPA28Bez+4VfQzZRSFNfiS/DlT6dNe5Z sjPd8+HcZGrLDYhvq3Bu30zoNxAVKqpHLzGCQDWalwJ9/lka5IDFJxALEzy5HE0m SwjesxnKv604D20bJYtJw9ZxZiM8CBA8eVciWWzEefZuqofKdpO0sfY+VlSGoX3D owUx8vIGTg/dfpkz/hCUjreU9Fqq5DBVFj1EvYRgpU/RtwGBuUNQs891b93v4Gvb +mFgGZAkSH4OCq+oDzkpbDaahTROfIbkzVftC3sU1zLdB9dpOb/sbtYwRx4nyomn hz/MlMK82w+OkXDEUvey9RqNeQbauA4ksmOAclFGeDoGZZbhzNlMG67fxOWqeiEo 0usgmGg1k0U5aiPCFZjA5O198bkx40uI+5TAtN6PKF8l98FSxo46ivnFXM2840ze H2mLE3hACv+ugkVqEpHvRAi8fLVkkdXrh8JZYRa1pgqGHpKDtbeXHEm/mB5e4f7P OOyuPE3qCjXGW52F4+IJdX+Y71mSmWDrv9JmOuMZvAGyRvy95DngO0AwghYK/amH hyqoVYgnlxw0uCosPerFktnfIwPSYPF7YdUJ30M+/1foHle/9OKz5EjmU4YZQaZc dRa8QD8H17rAqsVCMrIJ =q/Hl -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681387: unblock: resiprocate (follow up)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 10/10/12 10:09, Julien Cristau wrote: On Tue, Jul 24, 2012 at 13:06:14 +, Daniel Pocock wrote: Do you need any more detail from me? The build-dep change isn't documented in the changelog, care to explain it? I think you are referring to this entry from git: commit 1bb9328f52fe38c71ab30e1253d602ec1d170b6e Author: Daniel Pocock dan...@pocock.com.au Date: Sat Aug 4 16:51:45 2012 +0200 control/build-deps: add libxerces-c-dev for building B2BUA sample in next 1.8.x release Basically, 1.8.5 has some extra sample code for using libb2bua. It is a trivial example of a B2BUA for SIP. The sample code is under apps/basicB2BUA and it is automatically included in the compile (there is no configure option to avoid building it). Compiling this sample code depends on libxerces-c-dev. However, the sample code and the compiled binary are not added to any of the binary packages, and it does not change any of the other binaries in any way. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJQdTi2AAoJEOm1uwJp1aqDSNMP/20szA5YqUvkx2LSqO6hBcpX FH0yyENbKffQ4d6kYC17efePu5IrZUsau//tRatDH+QN79AMdSN9WtSVqnISXVLq UfHBApJ1q70psGgfhahDs7LU7muB9qVu6hdGZB1lZOoCAgssPnXBuFKS2vPntAuY LQRA2xoMojxUqhVMfyV9KRboLsgteCvPRvY2fQRPcyBOOQfPWyoRurZhAjxPL0wB 16B5fB+ocBX3J2O69DGS4GUU+EvQb+6cqH0xLMHM6WHsexRoLsOaadl3ZLi5idIT M1MuyNOXMC/qb/1mSSQqBwQwEgy57t6xi2XDce/I7GAMw2fhzuxbUK3whnsPY5R9 EhYyYYI1p4yxBDWnWT9JyNHy/YvxeA5LOmPGzow3OwBEJYmxYYD79Pru1H7qszIJ rOiz+T/WZqtzLJ7kgO+9H2uibYu2qII171bxBFahxwWqh4M4YJ6gjSZYhYSFjaim 0d3L9/JFWnqqMt+TdW+bMu0EnG4BR5tTBWdKbseIREbLQqkvHqz04HqD+pTxpNiL NcmrwLYgguB6CjOg8EL47RrBjeTXFfJ3g1mwVvswwkiFEL7eTKo/9rPXI3JNS6Vu PFGj51ykRw4Uv41tSjpeJjPJhnWKF/YqdvnZRKTt8N4JMccyjzYiCYQ0WBFaANph RMMtJb39lBO5cwdSiV4f =RzR0 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681387: unblock: resiprocate (follow up)
On Tue, Jul 24, 2012 at 13:06:14 +, Daniel Pocock wrote: --- these changes update the sipdialer binary package only, making it use the config file parser classes. This means it now uses the same config format as repro and reTurnServer What does that mean for existing configuration files? Cheers, Julien signature.asc Description: Digital signature
Bug#681387: unblock: resiprocate (follow up)
On Tue, Jul 24, 2012 at 13:06:14 +, Daniel Pocock wrote: Do you need any more detail from me? The build-dep change isn't documented in the changelog, care to explain it? Cheers, Julien signature.asc Description: Digital signature
Bug#681387: unblock: resiprocate (follow up)
Hi Cyril, Killian made the upload and a month has passed... do you think it is now OK to unblock? The packages run on various production servers already. If you need extra evidence of testing, there was a live demo of installing this package on the FreeSWITCH webcast/weekly call (also showing off the convenience of Debian and wheezy to a new audience): http://wiki.freeswitch.org/wiki/Weekly_Conference_Call#Past_Calls Please let me know if there is anything else I can do to assist in evaluating this unblock request. Regards, Daniel On 19/08/12 13:08, Cyril Brulebois wrote: Hi, and sorry for the lag. Daniel Pocock dan...@pocock.com.au (08/08/2012): On 08/08/12 00:24, Cyril Brulebois wrote: I think I won't be against having 1.8.4 in unstable, and see what happens on the bug reports front after an extended period of time (say 20 days). It would have been nice to see it uploaded in the meanwhile… 20 days is fine - we've already had some feedback on 1.8.4 and now there is a 1.8.5 release Would you be happy to accept 1.8.5 on the same terms? I attach a debdiff and SVN log output (1.8.4 vs. 1.8.5) Anyway, please upload 1.8.5 to unstable ASAP, we'll see in a month or so what happened. Agreed - that is how most of the fixes came into 1.8.5 - e.g. one user found that the --help output was crashing the program None of these issues are strictly release critical - but they are all fixes that provide a better experience of the package. The diff is indeed large for a --help crasher fix… No promise on our (possibly) unblocking this package after the said period of time. Understood - do I need to put Closes: #681387 in the changelog for upload? Nope, this isn't a bug report against your package anyway. Mraw, KiBi. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681387: unblock: resiprocate (follow up)
Hi, and sorry for the lag. Daniel Pocock dan...@pocock.com.au (08/08/2012): On 08/08/12 00:24, Cyril Brulebois wrote: I think I won't be against having 1.8.4 in unstable, and see what happens on the bug reports front after an extended period of time (say 20 days). It would have been nice to see it uploaded in the meanwhile… 20 days is fine - we've already had some feedback on 1.8.4 and now there is a 1.8.5 release Would you be happy to accept 1.8.5 on the same terms? I attach a debdiff and SVN log output (1.8.4 vs. 1.8.5) Anyway, please upload 1.8.5 to unstable ASAP, we'll see in a month or so what happened. Agreed - that is how most of the fixes came into 1.8.5 - e.g. one user found that the --help output was crashing the program None of these issues are strictly release critical - but they are all fixes that provide a better experience of the package. The diff is indeed large for a --help crasher fix… No promise on our (possibly) unblocking this package after the said period of time. Understood - do I need to put Closes: #681387 in the changelog for upload? Nope, this isn't a bug report against your package anyway. Mraw, KiBi. signature.asc Description: Digital signature
Bug#681387: unblock: resiprocate (follow up)
On 19/08/12 11:08, Cyril Brulebois wrote: 20 days is fine - we've already had some feedback on 1.8.4 and now there is a 1.8.5 release Would you be happy to accept 1.8.5 on the same terms? I attach a debdiff and SVN log output (1.8.4 vs. 1.8.5) Anyway, please upload 1.8.5 to unstable ASAP, we'll see in a month or so what happened. Kilian, would you please be able to make this upload for me? 1.8.2 doesn't include DM-Upload-Allowed: yes so I can't do this myself Everything Cyril has reviewed is in git, I haven't added anything since making the unblock request. Hopefully you can just do git clone git+ssh://kil...@git.debian.org/git/pkg-voip/resiprocate.git resiprocate \ cd resiprocate \ git-buildpackage Agreed - that is how most of the fixes came into 1.8.5 - e.g. one user found that the --help output was crashing the program None of these issues are strictly release critical - but they are all fixes that provide a better experience of the package. The diff is indeed large for a --help crasher fix… Agreed, that was only one of the crashes though, another was in ENUM. The ENUM code is not used by many people though. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681387: unblock: resiprocate (follow up)
Hello, Adam D. Barratt a...@adam-barratt.org.uk (04/08/2012): It'd still really want someone from the team to be happy with the changes before unblocking them however. I think I won't be against having 1.8.4 in unstable, and see what happens on the bug reports front after an extended period of time (say 20 days). I see at least constructor-related, inheritance-related changes, method additions, and so on. While I have read most of those changes are backports to stable branches, I can't help thinking actual tests by actual users are always a good idea. No promise on our (possibly) unblocking this package after the said period of time. Mraw, KiBi. signature.asc Description: Digital signature
Bug#681387: unblock: resiprocate (follow up)
On Wed, 2012-08-01 at 20:16 +, Daniel Pocock wrote: On 27/07/12 18:11, Adam D. Barratt wrote: Sorry for not getting back to you yet. We're still wading through requests, and those which aren't an obvious quick yes/no often take a little while longer to deal with. Would it help if an independent DD (not previously involved with the package) was to look over the request and comment on whether it is appropriate for unblock? A second pair of eyes on the changes for a sanity check and to see if any obvious issues with an unblock within the current policy pop out can't hurt. It'd still really want someone from the team to be happy with the changes before unblocking them however. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681387: unblock: resiprocate (follow up)
On 27/07/12 18:11, Adam D. Barratt wrote: On Tue, 2012-07-24 at 13:06 +, Daniel Pocock wrote: I'm just following up on the previous reply I sent you Sorry for not getting back to you yet. We're still wading through requests, and those which aren't an obvious quick yes/no often take a little while longer to deal with. Would it help if an independent DD (not previously involved with the package) was to look over the request and comment on whether it is appropriate for unblock? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681387: unblock: resiprocate (follow up)
On Tue, 2012-07-24 at 13:06 +, Daniel Pocock wrote: I'm just following up on the previous reply I sent you Sorry for not getting back to you yet. We're still wading through requests, and those which aren't an obvious quick yes/no often take a little while longer to deal with. Do you need any more detail from me? If there is, I'll ask. :-) Thanks for checking. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#681387: unblock: resiprocate (follow up)
Hi Adam, I'm just following up on the previous reply I sent you Do you need any more detail from me? I've attached some more comments about the diff below, showing which files impact which of the binary packages. Regards, Daniel $ grep ^diff debdiff1-dsc.txt --- these changes update the sipdialer binary package only, making it use the config file parser classes. This means it now uses the same config format as repro and reTurnServer diff -Nru resiprocate-1.8.2/apps/sipdial/DialerConfiguration.cpp resiprocate-1.8.4/apps/sipdial/DialerConfiguration.cpp diff -Nru resiprocate-1.8.2/apps/sipdial/DialerConfiguration.hxx resiprocate-1.8.4/apps/sipdial/DialerConfiguration.hxx diff -Nru resiprocate-1.8.2/apps/sipdial/DialInstance.cpp resiprocate-1.8.4/apps/sipdial/DialInstance.cpp diff -Nru resiprocate-1.8.2/apps/sipdial/DialInstance.hxx resiprocate-1.8.4/apps/sipdial/DialInstance.hxx diff -Nru resiprocate-1.8.2/apps/sipdial/MyInviteSessionHandler.cpp resiprocate-1.8.4/apps/sipdial/MyInviteSessionHandler.cpp diff -Nru resiprocate-1.8.2/apps/sipdial/README.txt resiprocate-1.8.4/apps/sipdial/README.txt diff -Nru resiprocate-1.8.2/apps/sipdial/sipdial.cfg resiprocate-1.8.4/apps/sipdial/sipdial.cfg diff -Nru resiprocate-1.8.2/apps/sipdial/sipdialer.cpp resiprocate-1.8.4/apps/sipdial/sipdialer.cpp diff -Nru resiprocate-1.8.2/apps/sipdial/todo.txt resiprocate-1.8.4/apps/sipdial/todo.txt --- adding a ChangeLog of everything changed since 1.7: diff -Nru resiprocate-1.8.2/ChangeLog resiprocate-1.8.4/ChangeLog --- autogenerated configure script, ignore: diff -Nru resiprocate-1.8.2/configure resiprocate-1.8.4/configure --- just updating version number in configure: diff -Nru resiprocate-1.8.2/configure.ac resiprocate-1.8.4/configure.ac --- minor tweaks to improve the Debian packaging: diff -Nru resiprocate-1.8.2/debian/changelog resiprocate-1.8.4/debian/changelog diff -Nru resiprocate-1.8.2/debian/repro.docs resiprocate-1.8.4/debian/repro.docs diff -Nru resiprocate-1.8.2/debian/repro.install resiprocate-1.8.4/debian/repro.install diff -Nru resiprocate-1.8.2/debian/repro.lintian-overrides resiprocate-1.8.4/debian/repro.lintian-overrides diff -Nru resiprocate-1.8.2/debian/repro.postinst resiprocate-1.8.4/debian/repro.postinst diff -Nru resiprocate-1.8.2/debian/repro.postrm resiprocate-1.8.4/debian/repro.postrm --- autogenerated, ignore: diff -Nru resiprocate-1.8.2/Makefile.in resiprocate-1.8.4/Makefile.in --- lot's of little bug fixes impacting the `repro' binary package only: diff -Nru resiprocate-1.8.2/repro/monkeys/RequestFilter.cxx resiprocate-1.8.4/repro/monkeys/RequestFilter.cxx diff -Nru resiprocate-1.8.2/repro/MySqlDb.cxx resiprocate-1.8.4/repro/MySqlDb.cxx diff -Nru resiprocate-1.8.2/repro/ProxyConfig.cxx resiprocate-1.8.4/repro/ProxyConfig.cxx diff -Nru resiprocate-1.8.2/repro/ProxyConfig.hxx resiprocate-1.8.4/repro/ProxyConfig.hxx diff -Nru resiprocate-1.8.2/repro/repro.config resiprocate-1.8.4/repro/repro.config diff -Nru resiprocate-1.8.2/repro/repro.cxx resiprocate-1.8.4/repro/repro.cxx diff -Nru resiprocate-1.8.2/repro/ReproRunner.cxx resiprocate-1.8.4/repro/ReproRunner.cxx diff -Nru resiprocate-1.8.2/repro/ReproRunner.hxx resiprocate-1.8.4/repro/ReproRunner.hxx diff -Nru resiprocate-1.8.2/repro/Store.cxx resiprocate-1.8.4/repro/Store.cxx diff -Nru resiprocate-1.8.2/repro/Store.hxx resiprocate-1.8.4/repro/Store.hxx diff -Nru resiprocate-1.8.2/repro/WebAdmin.cxx resiprocate-1.8.4/repro/WebAdmin.cxx diff -Nru resiprocate-1.8.2/repro/WebAdmin.hxx resiprocate-1.8.4/repro/WebAdmin.hxx --- little bug fixes impacting the core libraries libresiprocate.deb: diff -Nru resiprocate-1.8.2/resip/dum/ContactInstanceRecord.hxx resiprocate-1.8.4/resip/dum/ContactInstanceRecord.hxx diff -Nru resiprocate-1.8.2/resip/dum/Dialog.cxx resiprocate-1.8.4/resip/dum/Dialog.cxx diff -Nru resiprocate-1.8.2/resip/dum/InMemorySyncRegDb.cxx resiprocate-1.8.4/resip/dum/InMemorySyncRegDb.cxx diff -Nru resiprocate-1.8.2/resip/dum/test/basicClientCall.cxx resiprocate-1.8.4/resip/dum/test/basicClientCall.cxx diff -Nru resiprocate-1.8.2/resip/dum/test/basicClientUserAgent.cxx resiprocate-1.8.4/resip/dum/test/basicClientUserAgent.cxx diff -Nru resiprocate-1.8.2/resip/dum/test/basicClientUserAgent.hxx resiprocate-1.8.4/resip/dum/test/basicClientUserAgent.hxx diff -Nru resiprocate-1.8.2/resip/stack/ConnectionManager.cxx resiprocate-1.8.4/resip/stack/ConnectionManager.cxx diff -Nru resiprocate-1.8.2/resip/stack/KeepAlivePong.hxx resiprocate-1.8.4/resip/stack/KeepAlivePong.hxx diff -Nru resiprocate-1.8.2/resip/stack/ssl/Security.cxx resiprocate-1.8.4/resip/stack/ssl/Security.cxx diff -Nru resiprocate-1.8.2/resip.spec resiprocate-1.8.4/resip.spec diff -Nru resiprocate-1.8.2/rutil/ConfigParse.cxx resiprocate-1.8.4/rutil/ConfigParse.cxx diff -Nru resiprocate-1.8.2/rutil/ConfigParse.hxx resiprocate-1.8.4/rutil/ConfigParse.hxx diff -Nru resiprocate-1.8.2/rutil/FileSystem.cxx resiprocate-1.8.4/rutil/FileSystem.cxx diff -Nru
