Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Dear Vincent, One last nitpick (sorry!) is that other gnome-shell extensions packaged in Debian seem to prefix their packages with gnome-shell-extension- (e.g. gnome-shell-extension-weather, gnome-shell-extension-autohidetopbar), so can you please do the same for your binary package as well, i.e. rename it gnome-shell-extension-pomodoro? On that point I'd like to double check with you. Indeed, the app is currently an gnome-shell extension. But in the latest version (using gnome-shell 10), it has been transformed to an independent app based on gnome-shell according to upstream site. So should I be renaming it later? Keep the new name once it has been transformed to an app with the 0.10.0? Best regards, Joseph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Dear Vincent, I first understood that I needed --with quilt and then lintian was complaining about a missing build-dep for quilt. That's why I added them. But I doubled checked, tested on the package and you're right I don't need this! :-) That's great, I removed them. Yep, you guessed why priority was extra: I let them to the default value of dh_make. Changed that! :-) I didn't know this wrap-and-sort script. This is a great tool in its way! It even cleans up the commented Vcs-*! :-D Thanks a lot for all your help and time. I know feel I have a pretty awesome package thanks to you! ;-) I have to make a big sticky note with all your advises for next package with a lot of smileys! Thanks again, Joseph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
On Sun, Feb 2, 2014 at 2:01 AM, Joseph Herlant herla...@gmail.com wrote:
Dear Vincent,
I first understood that I needed --with quilt and then lintian was
complaining about a missing build-dep for quilt. That's why I added
them.
But I doubled checked, tested on the package and you're right I don't
need this! :-)
That's great, I removed them.
Source format '3.0 (quilt)' means that dpkg-source will automatically
deal with (un-)applying patches, so you don't need to use
dh_quilt_{patch,unpatch} to do so. If you were using an older source
format (e.g. 1.0), then yes, you would need to explicitly declare a
build-dep on quilt.
Yep, you guessed why priority was extra: I let them to the default
value of dh_make. Changed that! :-)
I didn't know this wrap-and-sort script. This is a great tool in its
way! It even cleans up the commented Vcs-*! :-D
Thanks a lot for all your help and time. I know feel I have a pretty
awesome package thanks to you! ;-)
I have to make a big sticky note with all your advises for next
package with a lot of smileys!
Great, thanks for fixing all those rather pedantic complaints!
One last nitpick (sorry!) is that other gnome-shell extensions
packaged in Debian seem to prefix their packages with
gnome-shell-extension- (e.g. gnome-shell-extension-weather,
gnome-shell-extension-autohidetopbar), so can you please do the same
for your binary package as well, i.e. rename it
gnome-shell-extension-pomodoro?
Vincent
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
On Thu, Jan 30, 2014 at 12:25 PM, Joseph Herlant herla...@gmail.com wrote: Hi Vincent, Thanks for this advice. :-) I chose to use the patching approach because I found it cleaner (and wanted to play with quilt once again!). I recreated the package from the upstream 0.8 tag and used quilt to integrate the fixes in one patch. Package have been uploaded to mentors. Please tell me if you have remarks. You're already using source format '3.0 (quilt)', so please remove the extraneous build-dep on quilt and the --with quilt invocation in d/rules. Some more extra pedantic comments: - Why priority: extra instead of optional? Most packages should be set to optional by default (yes, I'm aware dh_make uses priority: extra as default for some reason) unless they conflict with packages of higher priority (Policy 2.5). - Please use wrap-and-sort -s from devscripts to have your build-deps and deps in d/control listed one per line and in alphabetical order (this generally makes it a _lot_ easier to review changes to build-dep/dep fields in d/control). - Consider removing the commented lines (the unused Vcs-* fields) in d/control I've run out of things to nitpick, so I think that means your package is about ready to be uploaded. ;) Cheers, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Hi Vincent, Thanks for this advice. :-) I chose to use the patching approach because I found it cleaner (and wanted to play with quilt once again!). I recreated the package from the upstream 0.8 tag and used quilt to integrate the fixes in one patch. Package have been uploaded to mentors. Please tell me if you have remarks. Best regards, Joseph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
retitle 728059 RFS: gnome-shell-pomodoro/0.8.0-1 [ITP] thanks Dear Vincent, Thanks a lot for your advises and your time. Yes, use all instead. any will cause your package to be compiled on all Debian release architectures and introduce different binary packages of gnome-shell-pomodoro for every supported arch; all will save buildd time and will only install a single binary package for use on all archs. I now understand the difference. Thanks a lot. I updated the package to use all. It still doesn't abide by devref guidelines though; you should remove This and the period at the end of your synopsis (devref 6.2.2 [1]). Also, your description has a few other minor issues (e.g. inconsistent capitalization of Pomodoro Technique. You may wish to ask for a review of your package synopsis and description via debian-l10n-engl...@lists.debian.org (at this point I'm just being pedantic, so ignore this if you want, I suppose, but ideally fix the synopsis at least). That was a really really good advice. It helped me a lot. Thanks. :-) The description and synopsis have been reviewed. Please merge your changelog entries into a single one (version 0.8.0-1). You also don't need to reference me in your changelog entry. :) I merged everything to keep the version 0.8.0-1. You can find the dsc file at: http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-1.dsc Also, gnome-shell-pomodoro should not depend on intltool and libglib2.0-dev. Those packages are needed to build gnome-shell-pomodoro (hence why they are listed in build-depends), but not for running g-s-pomodoro itself. Absolutely right. I updated that! :-) Note that after discussing with the upstream author it seems that after a mistake, the compatibility of gnome-shell between 0.8.0 and 0.8.1 have been broken (gnome-shell 3.8 not supported anymore on 0.8.1) so fixes cannot be applied as a new tag. So I updated the package binaries using the latest fixes from the branch supporting gnome-shell 3.8. I installed it, played with it a little and found no issue. Best regards, Joseph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
On Wed, Jan 29, 2014 at 12:59 PM, Joseph Herlant herla...@gmail.com wrote: retitle 728059 RFS: gnome-shell-pomodoro/0.8.0-1 [ITP] thanks Dear Vincent, Thanks a lot for your advises and your time. Yes, use all instead. any will cause your package to be compiled on all Debian release architectures and introduce different binary packages of gnome-shell-pomodoro for every supported arch; all will save buildd time and will only install a single binary package for use on all archs. I now understand the difference. Thanks a lot. I updated the package to use all. It still doesn't abide by devref guidelines though; you should remove This and the period at the end of your synopsis (devref 6.2.2 [1]). Also, your description has a few other minor issues (e.g. inconsistent capitalization of Pomodoro Technique. You may wish to ask for a review of your package synopsis and description via debian-l10n-engl...@lists.debian.org (at this point I'm just being pedantic, so ignore this if you want, I suppose, but ideally fix the synopsis at least). That was a really really good advice. It helped me a lot. Thanks. :-) The description and synopsis have been reviewed. Please merge your changelog entries into a single one (version 0.8.0-1). You also don't need to reference me in your changelog entry. :) I merged everything to keep the version 0.8.0-1. You can find the dsc file at: http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-1.dsc Also, gnome-shell-pomodoro should not depend on intltool and libglib2.0-dev. Those packages are needed to build gnome-shell-pomodoro (hence why they are listed in build-depends), but not for running g-s-pomodoro itself. Absolutely right. I updated that! :-) Note that after discussing with the upstream author it seems that after a mistake, the compatibility of gnome-shell between 0.8.0 and 0.8.1 have been broken (gnome-shell 3.8 not supported anymore on 0.8.1) so fixes cannot be applied as a new tag. So I updated the package binaries using the latest fixes from the branch supporting gnome-shell 3.8. I installed it, played with it a little and found no issue. This means that your source tarball's hashsum doesn't match upstream's tarball anymore, of course: c937a8509bb6cfae596ed459c907e299 gnome-shell-pomodoro_0.8.0.orig.tar.gz e64dc07ed8ef238a566f69ffa4796eae gnome-shell-pomodoro-0.8.tar.gz If you have to repack a tarball for whatever reason (the most common reason is to strip out non-DFSG compatible files), you should have a get-orig-source target in debian/rules (Policy 4.9), and your package version in d/changelog should have some hint that your 0.8.0 version is not the same as 0.8.0 upstream (again, for DFSG purposes, the version number usually has +dfsg appended to it; if you're pulling directly from upstream git, a fairly common approach is to include the timestamp in the version). Alternatively, you can also just use upstream's github tarball and then apply the changes in the gnome-3.8 branch upstream as a patch (ideally with a DEP-3 header) in your package. Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Hi Joseph, On Mon, Jan 20, 2014 at 2:33 PM, Joseph Herlant herla...@gmail.com wrote: - Why Architecture: any if there aren't any arch-specific files in your package? As it means any architecture supported by debian and that it is the most frequently used regarding debina policy 5.6.8. I thought it could stay like this. What's your advice for this? Use all instead of any? Yes, use all instead. any will cause your package to be compiled on all Debian release architectures and introduce different binary packages of gnome-shell-pomodoro for every supported arch; all will save buildd time and will only install a single binary package for use on all archs. - Description synopsis (the short one-liner) should be 60 chars (Policy 3.4.1) Actually it's 80 chars but You're right it was too long. I shorted it. Ack, 80 chars, sorry. It still doesn't abide by devref guidelines though; you should remove This and the period at the end of your synopsis (devref 6.2.2 [1]). Also, your description has a few other minor issues (e.g. inconsistent capitalization of Pomodoro Technique. You may wish to ask for a review of your package synopsis and description via debian-l10n-engl...@lists.debian.org (at this point I'm just being pedantic, so ignore this if you want, I suppose, but ideally fix the synopsis at least). The updated package has been updated to mentors: http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-2.dsc Please merge your changelog entries into a single one (version 0.8.0-1). You also don't need to reference me in your changelog entry. :) Also, gnome-shell-pomodoro should not depend on intltool and libglib2.0-dev. Those packages are needed to build gnome-shell-pomodoro (hence why they are listed in build-depends), but not for running g-s-pomodoro itself. Regards, Vincent [1] https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Hi Vincent, Thanks for the quick answer. How is this different from gnome-shell-timer, which is already packaged in debian? The difference is that it uses pomodoro technique. It's not just a timer. For more information about the pomodoro technique, you can begin with the readme of the package (https://github.com/codito/gnome-shell-pomodoro/blob/gnome-3.8/README.md) Anyways, here's a quick review of your package: debian/control: - Vcs-Browser is present, but not Vcs-Git? I don't have a git:// url on github. I don't know what to use instead. Also, ideally your packaging would be hosted on alioth, although I don't think there's anything in Policy that prohibits it from being hosted elsewhere. I don't have the rights to create a repo on alioth. I was waiting to prove myself against Debian dev before finding a sponsor and getting a real account in alioth. If you create a repo and give me rights on it I'll put it on alioth with pleasure. - Standards version needs a bump to 3.9.5 Updated. - Why Architecture: any if there aren't any arch-specific files in your package? As it means any architecture supported by debian and that it is the most frequently used regarding debina policy 5.6.8. I thought it could stay like this. What's your advice for this? Use all instead of any? - Description synopsis (the short one-liner) should be 60 chars (Policy 3.4.1) Actually it's 80 chars but You're right it was too long. I shorted it. debian/README.source is empty, just remove it Removed. debian/watch is missing I added it. But be carefull, this generates warnings telling you there's a newer version of the package available. But the new versions are ONLY compatible gnome-shell 3.9 and 3.10, not build in debian yet. The updated package has been updated to mentors: http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-2.dsc Thanks for your help, Joseph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
On Wed, Oct 30, 2013 at 2:16 PM, Joseph Herlant herla...@gmail.com wrote: Package: sponsorship-requests Severity: wishlist Dear mentors, I repackaged the gnome-shell-pomodoro to support gnome-shell-3.8 (to work with unstable). I am now looking for a sponsor for my package gnome-shell-pomodoro * Package name: gnome-shell-pomodoro Version : 0.8.0-1 Upstream Authors : Arun Mahapatra pratika...@gmail.com and Kamil Prusko kamilpru...@gmail.com * URL : https://github.com/codito/gnome-shell-pomodoro * License : GPLv3 Section : gnome It builds those binary packages: gnome-shell-pomodoro - This GNOME Shell extension helps managing time according to Pomodoro technique (slices of 25/5-15minutes) To access further information about this package, please visit the following URL: http://mentors.debian.net/package/gnome-shell-pomodoro Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-1.dsc More information about hello can be obtained from https://github.com/codito/gnome-shell-pomodoro. Changes since the last upload: - Last time I uploaded the version 0.6 that only fits testing (gnome 3.4) which I packaged for my personal usage. This one packages the version 0.8 that works with the unstable release (gnome-shell-3.8. Notes: - As it is the first package I really do for the community, don't hesitate to tell me if I did anything wrong. Note that I put gnome-shell = 3.7 in the depends field because it requires gnome-shell 3.7 or 3.8. And as I didn't find a way to tell that it's not compatible with version 3.9 and higher, I put the gnome-shell = 3.8 in the Recommends field. Please let me know it there's a better way to do that. You'd want Breaks: gnome-shell (= 3.8) instead. Perhaps this should be included as part of the gnome-shell-extensions package instead? There's also the fact that gnome-shell extensions often break between each major release; if the upstream developer(s) for your package don't keep their extension updated, this package might not last very long in Debian. Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Hi Vincent, Thanks for the suggestion for the usage of the Breaks keyword. I personally prefer to do as the gnome-shell-extensions do which is adding gnome-shell (= 3.8), gnome-shell ( 3.9) to the package. I'll update the package accordingly for the next release. For the integration of the gnome-shell-extensions, it was my first idea, but as the author explained on the Github's readme: *Until recently it was just an GNOME Shell extension, with latest release it became an app. It was necessary change to make ground for coming features, a todo list for instance. However, it no longer will be possible to distribute it via extensions.gnome.org http://extensions.gnome.org, we need to figure out packaging and it will take a few months...* So I followed the author's mind and created an independent package. Anyway, I'm using it (installed using the package I've done) on 2 computer for quite some times now without issue. PS: I added you to the to reply because I'm not sure you've subscribed to the bug. My apologies if you receive this mail twice. Regards, Joseph On Fri, Jan 17, 2014 at 1:01 PM, Vincent Cheng vch...@debian.org wrote: On Wed, Oct 30, 2013 at 2:16 PM, Joseph Herlant herla...@gmail.com wrote: Package: sponsorship-requests Severity: wishlist Dear mentors, I repackaged the gnome-shell-pomodoro to support gnome-shell-3.8 (to work with unstable). I am now looking for a sponsor for my package gnome-shell-pomodoro * Package name: gnome-shell-pomodoro Version : 0.8.0-1 Upstream Authors : Arun Mahapatra pratika...@gmail.com and Kamil Prusko kamilpru...@gmail.com * URL : https://github.com/codito/gnome-shell-pomodoro * License : GPLv3 Section : gnome It builds those binary packages: gnome-shell-pomodoro - This GNOME Shell extension helps managing time according to Pomodoro technique (slices of 25/5-15minutes) To access further information about this package, please visit the following URL: http://mentors.debian.net/package/gnome-shell-pomodoro Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-1.dsc More information about hello can be obtained from https://github.com/codito/gnome-shell-pomodoro. Changes since the last upload: - Last time I uploaded the version 0.6 that only fits testing (gnome 3.4) which I packaged for my personal usage. This one packages the version 0.8 that works with the unstable release (gnome-shell-3.8. Notes: - As it is the first package I really do for the community, don't hesitate to tell me if I did anything wrong. Note that I put gnome-shell = 3.7 in the depends field because it requires gnome-shell 3.7 or 3.8. And as I didn't find a way to tell that it's not compatible with version 3.9 and higher, I put the gnome-shell = 3.8 in the Recommends field. Please let me know it there's a better way to do that. You'd want Breaks: gnome-shell (= 3.8) instead. Perhaps this should be included as part of the gnome-shell-extensions package instead? There's also the fact that gnome-shell extensions often break between each major release; if the upstream developer(s) for your package don't keep their extension updated, this package might not last very long in Debian. Vincent
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Control: tag -1 moreinfo On Fri, Jan 17, 2014 at 9:40 AM, Joseph Herlant herla...@gmail.com wrote: Hi Vincent, Thanks for the suggestion for the usage of the Breaks keyword. I personally prefer to do as the gnome-shell-extensions do which is adding gnome-shell (= 3.8), gnome-shell ( 3.9) to the package. I'll update the package accordingly for the next release. Sure, that works too. Don't forget to fix that in the current package you have on mentors (as well as a few other things which I'll mention below). For the integration of the gnome-shell-extensions, it was my first idea, but as the author explained on the Github's readme: Until recently it was just an GNOME Shell extension, with latest release it became an app. It was necessary change to make ground for coming features, a todo list for instance. However, it no longer will be possible to distribute it via extensions.gnome.org, we need to figure out packaging and it will take a few months... So I followed the author's mind and created an independent package. Anyway, I'm using it (installed using the package I've done) on 2 computer for quite some times now without issue. How is this different from gnome-shell-timer, which is already packaged in debian? Anyways, here's a quick review of your package: debian/control: - Vcs-Browser is present, but not Vcs-Git? Also, ideally your packaging would be hosted on alioth, although I don't think there's anything in Policy that prohibits it from being hosted elsewhere. - Standards version needs a bump to 3.9.5 - Why Architecture: any if there aren't any arch-specific files in your package? - Description synopsis (the short one-liner) should be 60 chars (Policy 3.4.1) debian/README.source is empty, just remove it debian/watch is missing PS: I added you to the to reply because I'm not sure you've subscribed to the bug. My apologies if you receive this mail twice. No need to send it to me directly or cc me; sending mail to any bug against sponsorship-requests also gets sent to the debian-mentors mailing list, which I'm subscribed to. I don't particularly care about this though, so feel free to cc me all you want. Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#728059: RFS: gnome-shell-pomodoro/0.6.20131027-1 [ITA]
Package: sponsorship-requests Severity: wishlist Dear mentors, I repackaged the gnome-shell-pomodoro to support gnome-shell-3.8 (to work with unstable). I am now looking for a sponsor for my package gnome-shell-pomodoro * Package name: gnome-shell-pomodoro Version : 0.8.0-1 Upstream Authors : Arun Mahapatra pratika...@gmail.com and Kamil Prusko kamilpru...@gmail.com * URL : https://github.com/codito/gnome-shell-pomodoro * License : GPLv3 Section : gnome It builds those binary packages: gnome-shell-pomodoro - This GNOME Shell extension helps managing time according to Pomodoro technique (slices of 25/5-15minutes) To access further information about this package, please visit the following URL: http://mentors.debian.net/package/gnome-shell-pomodoro Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/g/gnome-shell-pomodoro/gnome-shell-pomodoro_0.8.0-1.dsc More information about hello can be obtained from https://github.com/codito/gnome-shell-pomodoro. Changes since the last upload: - Last time I uploaded the version 0.6 that only fits testing (gnome 3.4) which I packaged for my personal usage. This one packages the version 0.8 that works with the unstable release (gnome-shell-3.8. Notes: - As it is the first package I really do for the community, don't hesitate to tell me if I did anything wrong. Note that I put gnome-shell = 3.7 in the depends field because it requires gnome-shell 3.7 or 3.8. And as I didn't find a way to tell that it's not compatible with version 3.9 and higher, I put the gnome-shell = 3.8 in the Recommends field. Please let me know it there's a better way to do that. Best regards, Joseph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
